zkCleanup.sh is buggy

2009-07-17 Thread Fernando Padilla
I am playing with the zookeeper 3.2.0 build, and it looks like the zkCleanup.sh script is a little buggy. :) It calls: PurgeTxnLog $dataDir but doesn't pass through the count of snapshots.. you could do it simply by adding: PurgeTxnLog $dataDir $* Though I just realized, it only uses

Re: zkCleanup.sh is buggy

2009-07-17 Thread Fernando Padilla
Actually.. this is the patch I would suggest: remove everything below and including the eval, and change to: ZOODATADIR=$(grep '^dataDir=' $ZOOCFG | sed -e 's/.*=//') ZOODATALOGDIR=$(grep '^dataLogDir=' $ZOOCFG | sed -e 's/.*=//') if [ x${ZOODATALOGDIR} = x ] then java

Re: zkCleanup.sh is buggy

2009-07-17 Thread Mahadev Konar
Hi Fernando, Please do file a jira ( http://issues.apache.org/jira/browse/ZOOKEEPER ) and the patch below as an attachment to the created jira. Here is how to contribute: http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute thnaks Mahadev On 7/17/09 11:59 AM, Fernando Padilla

Queue code

2009-07-17 Thread kishore g
Hi All, Zookeeper recipe queue code has a bug. byte[] b = zk.getData(root + /element + min, false, stat); zk.delete(root + /element + min, 0); It throws an error saying the node element0 does not exists. Node actually created by

Multiple ZK clusters or a single, shared cluster?

2009-07-17 Thread Jonathan Gray
Hey guys, Been using ZK indirectly for a few months now in the HBase and Katta realms. Both of these applications make it really easy so you don't have to be involved much with managing your ZK cluster to support it. I'm now using ZK for a bunch of things internally, so now I'm manually

Re: Queue code

2009-07-17 Thread Patrick Hunt
Thanks for the report, looks like something we need to address, would you mind going the extra step and adding a JIRA on this? https://issues.apache.org/jira/browse/ZOOKEEPER Thanks, Patrick kishore g wrote: Hi All, Zookeeper recipe queue code has a bug. byte[] b = zk.getData(root +

Re: Queue code

2009-07-17 Thread Mahadev Konar
Also are there any performance numbers of zookeeeper based queues. How does it compare with JMS. thanks Kishore G Hi Kishore, We do not have any performance number fr queues on zookeeper. I think you can get a rough idea of those numbers from your usage of zookeeper (number of reads/writes

Re: Multiple ZK clusters or a single, shared cluster?

2009-07-17 Thread Benjamin Reed
we designed zk to have high performance so that it can be shared by multiple applications. the main thing is that you use dedicated zk machines (with a dedicated disk for logging). once you have that in place, watch the load on your cluster, as long as you aren't saturating the cluster you

Re: Multiple ZK clusters or a single, shared cluster?

2009-07-17 Thread Jonathan Gray
Thanks for the input. Honestly, I'm thinking I need to have separate clusters. The version of ZK is one thing; but also for an application like HBase, we have had periods where we needed to patch ZK before it became part of a release. Keeping track of that on a shared cluster will be

Re: Queue code

2009-07-17 Thread Ted Dunning
Depending on your needs, there may be other recipes as well that would give higher performance. For example, it might be preferable to keep the queue itself in a small-ish set of files that each hold many task items. Different implementations will give different trade-offs on speed, especially