Re: [Zope] Monkey patch for BLOB support in OFS.Image Images and Files

2011-01-08 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 01/08/2011 05:58 AM, Jens Vagelpohl wrote:
> On 1/7/11 22:28 , William Heymann wrote:
>> I have a monkey patch here that I would like comments on it and to see how it
>> works for others.
> 
> Hi William,
> 
> A huge monkey patch like that makes it very hard to compare it with the
> original implementation and see the actual changes. You could help the
> review *greatly* by providing a diff to the original implementation
> instead, and post that to the Zope bug tracker on Launchpad:
> 
> https://bugs.launchpad.net/zope2

The developer docs help explain how to create such a patch as a
non-committer:  in particular:

 http://docs.zope.org/developer/noncommitter-svn.html

shows how to use SVN to generate the patch without needing write access.


Tres.
- -- 
===
Tres Seaver  +1 540-429-0999  tsea...@palladion.com
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0omvYACgkQ+gerLs4ltQ5aLACeJTsnaKuyRAi6uEnFePwBR+eP
YzgAn1P7M20BpM2/H5JncUFv7QLhCgSZ
=Xfvp
-END PGP SIGNATURE-

___
Zope maillist  -  Zope@zope.org
https://mail.zope.org/mailman/listinfo/zope
**   No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope-dev )


Re: [Zope] Monkey patch for BLOB support in OFS.Image Images and Files

2011-01-08 Thread Jens Vagelpohl
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 1/7/11 22:28 , William Heymann wrote:
> I have a monkey patch here that I would like comments on it and to see how it 
> works for others.

Hi William,

A huge monkey patch like that makes it very hard to compare it with the
original implementation and see the actual changes. You could help the
review *greatly* by providing a diff to the original implementation
instead, and post that to the Zope bug tracker on Launchpad:

https://bugs.launchpad.net/zope2

jens

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.8 (Darwin)

iEYEARECAAYFAk0oQ1kACgkQRAx5nvEhZLJk5gCgtnVBC7XF6PbOlOf1NPr6Ge70
gZoAn3VM6J8ecvLvXZzlFP55LQ4/Szr6
=Bfle
-END PGP SIGNATURE-
___
Zope maillist  -  Zope@zope.org
https://mail.zope.org/mailman/listinfo/zope
**   No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope-dev )