[Zope-CMF] CMF Tests: 9 OK
Summary of messages to the cmf-tests list. Period Wed Sep 3 11:00:00 2008 UTC to Thu Sep 4 11:00:00 2008 UTC. There were 9 messages: 9 from CMF Tests. Tests passed OK --- Subject: OK : CMF-1.6 Zope-2.8 Python-2.3.6 : Linux From: CMF Tests Date: Wed Sep 3 21:28:40 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009776.html Subject: OK : CMF-1.6 Zope-2.9 Python-2.4.4 : Linux From: CMF Tests Date: Wed Sep 3 21:30:10 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009777.html Subject: OK : CMF-2.0 Zope-2.9 Python-2.4.4 : Linux From: CMF Tests Date: Wed Sep 3 21:31:40 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009778.html Subject: OK : CMF-2.0 Zope-2.10 Python-2.4.4 : Linux From: CMF Tests Date: Wed Sep 3 21:33:10 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009779.html Subject: OK : CMF-2.1 Zope-2.10 Python-2.4.4 : Linux From: CMF Tests Date: Wed Sep 3 21:34:40 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009780.html Subject: OK : CMF-2.1 Zope-2.11 Python-2.4.4 : Linux From: CMF Tests Date: Wed Sep 3 21:36:10 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009781.html Subject: OK : CMF-trunk Zope-2.10 Python-2.4.4 : Linux From: CMF Tests Date: Wed Sep 3 21:37:41 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009782.html Subject: OK : CMF-trunk Zope-2.11 Python-2.4.4 : Linux From: CMF Tests Date: Wed Sep 3 21:39:11 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009783.html Subject: OK : CMF-trunk Zope-trunk Python-2.4.4 : Linux From: CMF Tests Date: Wed Sep 3 21:40:41 EDT 2008 URL: http://mail.zope.org/pipermail/cmf-tests/2008-September/009784.html ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
[Zope-CMF] Bug in FSPythonScript?
In CMFCore.FSPythonScript.py around line 170 in the _exec method, a volatile attribute is checked to see if a script has been compiled properly. The lifetime of volatile attributes cannot be guaranteed right, so I would assume that this code is not being careful enough. This is the code I'm talking about: # Prepare the function. f = self._v_f if f is None: # The script has errors. __traceback_supplement__ = ( FSPythonScriptTracebackSupplement, self, 0) raise RuntimeError, '%s has errors.' % self._filepath I have a few Plone sites that work perfectly 99% of the time, but under heavy load they raise RuntimeErrors on scripts at precisely this point in the code. The only explanation seems to be that the volatile attribute has lost its state. When I customise the scripts to force a recompile it works again. Seems like a bug? -- Roché Compaan Upfront Systems http://www.upfrontsystems.co.za ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] Bug in FSPythonScript?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Roché Compaan wrote: In CMFCore.FSPythonScript.py around line 170 in the _exec method, a volatile attribute is checked to see if a script has been compiled properly. The lifetime of volatile attributes cannot be guaranteed right, so I would assume that this code is not being careful enough. This is the code I'm talking about: # Prepare the function. f = self._v_f if f is None: # The script has errors. __traceback_supplement__ = ( FSPythonScriptTracebackSupplement, self, 0) raise RuntimeError, '%s has errors.' % self._filepath I have a few Plone sites that work perfectly 99% of the time, but under heavy load they raise RuntimeErrors on scripts at precisely this point in the code. The only explanation seems to be that the volatile attribute has lost its state. When I customise the scripts to force a recompile it works again. Seems like a bug? I've never seen the behavior you report, but inspection suggests that an extra check would not hurt. E.g., before the 'if f is None' above, adding: if f is None: self._readFile(True) f = self._v_f should do the trick. If you can generate a patch for this, which includes a test (calling 'script._p_deactivate()' should mimic the behavior you are seing), I would be glad to merge it (assuming you don't have SVN privileges). Tres. - -- === Tres Seaver +1 540-429-0999 [EMAIL PROTECTED] Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIwFDZ+gerLs4ltQ4RAnpvAKCV3e3C9TPOQiygwY/TtHn4e2DiawCgidlU DZakIRreq4bJejN8RgWbF9Y= =+jUJ -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
