Re: [Zope-CMF] Products.CMFCore release

2013-10-15 Thread Jens Vagelpohl
On Oct 14, 2013, at 23:02 , Harald Friessnegger har...@webmeisterei.com wrote: hi jens i've added a test for my change. http://svn.zope.org/Products.CMFCore/branches/2.2/Products/CMFCore/tests/test_SkinsTool.py?rev=130325view=rev can you fix the other tests and make a new release? Hi

Re: [Zope-CMF] Products.CMFCore release

2013-10-15 Thread yuppie
Jens Vagelpohl wrote: I have created a new release and uploaded it to PyPI. -2.2.8 (unreleased) +2.2.8 (2014-10-15) You've got a time machine? Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@zope.org

Re: [Zope-CMF] Products.CMFCore release

2013-10-15 Thread Jens Vagelpohl
On Oct 15, 2013, at 9:09 , yuppie y.2...@wcm-solutions.de wrote: Jens Vagelpohl wrote: I have created a new release and uploaded it to PyPI. -2.2.8 (unreleased) +2.2.8 (2014-10-15) You've got a time machine? Cheers, Yuppie Sorry, typo. I have corrected the file in SVN, but IMHO a new

Re: [Zope-CMF] Products.CMFCore release

2013-10-15 Thread yuppie
Hi Jens! Jens Vagelpohl wrote: On Oct 15, 2013, at 9:09 , yuppie y.2013-E2EsyBC0hj3+aS/vkh9...@public.gmane.org wrote: Jens Vagelpohl wrote: I have created a new release and uploaded it to PyPI. -2.2.8 (unreleased) +2.2.8 (2014-10-15) You've got a time machine? Cheers, Yuppie

Re: [Zope-CMF] Products.CMFCore release

2013-10-14 Thread Jens Vagelpohl
On Oct 14, 2013, at 13:31, Harald Friessnegger har...@webmeisterei.com wrote: hi jens you're right about a missing test for the change. however, the method getSkinNameFromRequest is not involved in any unit-test by now. if you wont' add the change to the next release w/o a propert test,

Re: [Zope-CMF] Products.CMFCore release

2013-10-13 Thread Jens Vagelpohl
On Oct 11, 2013, at 19:11 , Tres Seaver tsea...@palladion.com wrote: Signed PGP part On 10/11/2013 07:34 AM, Harald Friessnegger wrote: hi tres sorry for the last mail. it got sent accidentally before i could finish it. i did a minor change to cmfcore that i'd love to see in the

Re: [Zope-CMF] Products.CMFCore release

2013-10-13 Thread yuppie
Hi! Jens Vagelpohl wrote: On 10/11/2013 07:34 AM, Harald Friessnegger wrote: i did a minor change to cmfcore that i'd love to see in the next releases of plone. http://dev.plone.org/ticket/10071#comment:8 could you please review the change and do a new release on pypi? [...] If it was just