Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-29 Thread yuppie
Hi Maurits, Maurits van Rees wrote: > Op 25-09-15 om 10:31 schreef yuppie: >> But I hope these assertions are true: >> >> - a profile that depends on more than one base profile is broken anyway > > Agreed. > >> - if there is a base profile in the chain, it is always the first in the >> chain >

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-28 Thread Maurits van Rees
Hi yuppie, Op 25-09-15 om 10:31 schreef yuppie: Hi Maurits, Maurits van Rees wrote: Op 24-09-15 om 13:54 schreef yuppie: if you run a base profile in purge mode, you usually want to undo all previous configuration and start from scratch. In theory you could do that just with some setup

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-24 Thread yuppie
Hi Maurits, Maurits van Rees wrote: > Op 23-09-15 om 16:53 schreef yuppie: >> if you run a base profile in purge mode, shouldn't that purge profile >> versions automatically? > > GenericSetup itself is not doing this currently. > It might be good to do that, but I guess it is not always needed.

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-23 Thread Jens W. Klein
On 2015-09-22 12:30, yuppie wrote: [...] >> - pep8. This fixes over 6000 pep8 errors... Most of them fixed with the >> autopep8 command line tool. Small in scope yes, but due to all those >> errors a *very* large pull request. All tests pass. > > -1 > > I agree with the goal to try to respect

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-23 Thread yuppie
Hi Maurits, Maurits van Rees wrote: > Adding 'purgeProfileVersions' is also on my wish list now, which is > really simple: > > portal_setup._profile_upgrade_versions = {} > > There were a few problems in Plone due to my change with the dependency > strategies. I found that those were

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-23 Thread yuppie
Hi Jens, Jens W. Klein wrote: > On 2015-09-22 12:30, yuppie wrote: > [...] >>> - pep8. This fixes over 6000 pep8 errors... Most of them fixed with the >>> autopep8 command line tool. Small in scope yes, but due to all those >>> errors a *very* large pull request. All tests pass. >> >> -1 >> >>

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-22 Thread Maurits van Rees
Op 22-09-15 om 12:30 schreef yuppie: Hi Maurits, Maurits van Rees wrote: Meanwhile, I have added two more pull requests, far smaller in scope: - Add 'unsetLastVersionForProfile' method to portal_setup. This removes the profile id from the profile upgrade versions. +1 Adding

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-22 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/22/2015 06:30 AM, yuppie wrote: > -1 > > I agree with the goal to try to respect pep8 rules and to use tools > that help doing this. But this is a massive reformatting that adds a > lot of noise if you use blame or similar techniques. And I use

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-22 Thread yuppie
Hi Maurits, Maurits van Rees wrote: > Meanwhile, I have added two more pull requests, far smaller in scope: > > - Add 'unsetLastVersionForProfile' method to portal_setup. This removes > the profile id from the profile upgrade versions. +1 > - pep8. This fixes over 6000 pep8 errors... Most of

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-21 Thread Maurits van Rees
Op 18-09-15 om 09:45 schreef yuppie: Hi Maurits, Maurits van Rees wrote: Op 14-09-15 om 09:02 schreef Charlie Clark: This sounds like a good idea. The ZMI has traditionally suffered from just having more and more knobs to twiddle with little thought of the actual UI. I don't think that should

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-18 Thread yuppie
Hi Maurits, Maurits van Rees wrote: > Op 14-09-15 om 09:02 schreef Charlie Clark: >> This sounds like a good idea. The ZMI has traditionally suffered from >> just having more and more knobs to twiddle with little thought of the >> actual UI. I don't think that should block this PR (if it's

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-17 Thread Maurits van Rees
Op 14-09-15 om 09:02 schreef Charlie Clark: I didn't have a look at the Plone 5 control panel, but as you describe it, something similar would be quite useful in the portal_setup UI. But the Import tab has already too many options for rare use cases. It might be better to add a new tab for

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-14 Thread Charlie Clark
Your mail with the screen shot was delayed, so I didn't see it before I wrote my reply. X-Mailman-Approved-At: Fri, 11 Sep 2015 15:20:01 +0200 Did someone have to approve that manually? Yes, I think that there's a limit to 100 KB per e-mail, though I'm surprised that the screenshot is as

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-11 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/10/2015 11:43 PM, Maurits van Rees wrote: > I thought I would add a link to my branch on Launchpad, but apparently > only the master and 1.6 branches are synced, so mine is not visible: > https://code.launchpad.net/zope-genericsetup The

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-11 Thread Maurits van Rees
Hi yuppie, Op 11-09-15 om 09:00 schreef yuppie: The Import tab wasn't built with extension profiles and upgrade steps in mind. It is not exactly the UI you expect for installing add-ons. One issue you want to fix is this: Someone installs an add-on on a site that has outdated configuration.

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-10 Thread Maurits van Rees
Hi yuppie, Op 09-09-15 om 11:43 schreef yuppie: Hi Maurits, Maurits van Rees wrote: Dependency profiles from metadata.xml that are already applied, are not applied again. Instead, its upgrade steps, if any, are applied. In code you can choose the old behavior of always applying the

Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-09 Thread yuppie
Hi Maurits, Maurits van Rees wrote: > Dependency profiles from metadata.xml that are already applied, are not > applied again. Instead, its upgrade steps, if any, are applied. In code > you can choose the old behavior of always applying the dependencies, by > calling runAllImportStepsFromProfile

[Zope-CMF] GenericSetup: Apply profile dependencies only once

2015-09-07 Thread Maurits van Rees
Hi, Can someone have a look at this pull request I made? https://github.com/zopefoundation/Products.GenericSetup/pull/16 It does two changes. I think they are both sane, but the first one could be tricky, so feedback would be good. This is the change: Dependency profiles from metadata.xml