Re: [Zope-CMF] Pending pull requests GenericSetup

2015-10-27 Thread Maurits van Rees
Op 26/10/15 om 14:43 schreef Maurits van Rees: Conflict was to be expected. I have rebased the other pull request. I have merged that one too. Ready for a release I would say. -- Maurits van Rees: http://maurits.vanrees.org/ Zest Software: http://zestsoftware.nl

Re: [Zope-CMF] Pending pull requests GenericSetup

2015-10-26 Thread Maurits van Rees
Op 26/10/15 om 09:27 schreef yuppie: Hi Maurits, Maurits van Rees wrote: Just a friendly reminder that there are two pending pull requests by me for GenericSetup. Pep8, mostly in tests: https://github.com/zopefoundation/Products.GenericSetup/pull/21 Add unsetLastVersionForProfile and

Re: [Zope-CMF] Pending pull requests GenericSetup

2015-10-26 Thread yuppie
Hi Maurits, Maurits van Rees wrote: > Just a friendly reminder that there are two pending pull requests by me > for GenericSetup. > > Pep8, mostly in tests: > https://github.com/zopefoundation/Products.GenericSetup/pull/21 > > Add unsetLastVersionForProfile and purgeProfileVersions. Call >

Re: [Zope-CMF] Pending pull requests GenericSetup

2015-10-26 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/26/2015 07:04 AM, Maurits van Rees wrote: > Op 26/10/15 om 09:27 schreef yuppie: >> Hi Maurits, >> >> Maurits van Rees wrote: >>> Just a friendly reminder that there are two pending pull requests >>> by me for GenericSetup. >>> >>> Pep8,

Re: [Zope-CMF] Pending pull requests GenericSetup

2015-10-26 Thread Maurits van Rees
Op 26/10/15 om 14:29 schreef Tres Seaver: I merged the PEP8 one. Ironically, it causes conflicts with the other one (#18). Thanks. Conflict was to be expected. I have rebased the other pull request. -- Maurits van Rees: http://maurits.vanrees.org/ Zest Software: http://zestsoftware.nl