Re: [Zope-CMF] Products.CMFCore release
On Oct 14, 2013, at 23:02 , Harald Friessnegger har...@webmeisterei.com wrote: hi jens i've added a test for my change. http://svn.zope.org/Products.CMFCore/branches/2.2/Products/CMFCore/tests/test_SkinsTool.py?rev=130325view=rev can you fix the other tests and make a new release? Hi Harald, You have not forward-ported the test to the trunk. Please do so. I have created a new release and uploaded it to PyPI. jens signature.asc Description: Message signed with OpenPGP using GPGMail ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] Products.CMFCore release
Jens Vagelpohl wrote: I have created a new release and uploaded it to PyPI. -2.2.8 (unreleased) +2.2.8 (2014-10-15) You've got a time machine? Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] Products.CMFCore release
On Oct 15, 2013, at 9:09 , yuppie y.2...@wcm-solutions.de wrote: Jens Vagelpohl wrote: I have created a new release and uploaded it to PyPI. -2.2.8 (unreleased) +2.2.8 (2014-10-15) You've got a time machine? Cheers, Yuppie Sorry, typo. I have corrected the file in SVN, but IMHO a new egg won't be required, right? I have also managed to fix the issue with the svn.zope.org mail hook, even though that's not my job anymore. jens signature.asc Description: Message signed with OpenPGP using GPGMail ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] Products.CMFCore release
Hi Jens! Jens Vagelpohl wrote: On Oct 15, 2013, at 9:09 , yuppie y.2013-E2EsyBC0hj3+aS/vkh9...@public.gmane.org wrote: Jens Vagelpohl wrote: I have created a new release and uploaded it to PyPI. -2.2.8 (unreleased) +2.2.8 (2014-10-15) You've got a time machine? Cheers, Yuppie Sorry, typo. I have corrected the file in SVN, but IMHO a new egg won't be required, right? Yes, that should be sufficient. I have also managed to fix the issue with the svn.zope.org mail hook, even though that's not my job anymore. Great! Thanks! Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] Products.CMFCore release
On Oct 14, 2013, at 13:31, Harald Friessnegger har...@webmeisterei.com wrote: hi jens you're right about a missing test for the change. however, the method getSkinNameFromRequest is not involved in any unit-test by now. if you wont' add the change to the next release w/o a propert test, i'll add it. just let me know Please do. That would have caught the trunk mess-up, too, so you can see there's a good reason to test every change in behavior, even if the behavior is not fully tested at present. jens signature.asc Description: Message signed with OpenPGP using GPGMail ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] Products.CMFCore release
On Oct 11, 2013, at 19:11 , Tres Seaver tsea...@palladion.com wrote: Signed PGP part On 10/11/2013 07:34 AM, Harald Friessnegger wrote: hi tres sorry for the last mail. it got sent accidentally before i could finish it. i did a minor change to cmfcore that i'd love to see in the next releases of plone. http://dev.plone.org/ticket/10071#comment:8 could you please review the change and do a new release on pypi? thanks for your reply and have a nice weekend I can't get to this before sometime next week. Hanno and Jens are the other two release-makers (CC'ed). If it was just about making a release I could have done it quickly. However, I see two issues I don't have time to look into right now: - the change has no unit test - two others are failing: snip Failure in test test_getActionObject_oldskool_action_deprecated (Products.CMFCore.tests.test_ActionsTool.ActionsToolTests) Traceback (most recent call last): File /usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py, line 331, in run testMethod() File /usr/local/src/Products.CMFCore-2.2/Products/CMFCore/tests/test_ActionsTool.py, line 94, in test_getActionObject_oldskool_action_deprecated '2.4. Use Action and Action Category objects instead.' in warning) File /usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py, line 424, in assertTrue raise self.failureException(msg) AssertionError: False is not true Failure in test test_getDiff (Products.CMFCore.tests.test_FSPythonScript.CustomizedPythonScriptTests) Traceback (most recent call last): File /usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py, line 331, in run testMethod() File /usr/local/src/Products.CMFCore-2.2/Products/CMFCore/tests/test_FSPythonScript.py, line 274, in test_getDiff self.assertEqual(list(cps.getDiff()), _DIFF_TEXT.splitlines()) File /usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py, line 515, in assertEqual assertion_func(first, second, msg=msg) File /usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py, line 744, in assertListEqual self.assertSequenceEqual(list1, list2, msg, seq_type=list) File /usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py, line 726, in assertSequenceEqual self.fail(msg) File /usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py, line 412, in fail raise self.failureException(msg) AssertionError: Lists differ: ['--- original', '+++ modified... != ['--- original ', '+++ modifie... First differing element 0: --- original --- original - ['--- original', + ['--- original ', ? + - '+++ modified', + '+++ modified ', ? + '@@ -7,4 +7,4 @@', ' ##parameters=', ' ##title=', ' ##', -return 'cps', +return 'cps -- replaced'] Ran 235 tests with 2 failures and 0 errors in 0.541 seconds. Tearing down left over layers: Tear down zope.testing.testrunner.layer.UnitTests in 0.000 seconds. Total: 612 tests, 2 failures, 0 errors in 8.445 seconds. jens signature.asc Description: Message signed with OpenPGP using GPGMail ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] Products.CMFCore release
Hi! Jens Vagelpohl wrote: On 10/11/2013 07:34 AM, Harald Friessnegger wrote: i did a minor change to cmfcore that i'd love to see in the next releases of plone. http://dev.plone.org/ticket/10071#comment:8 could you please review the change and do a new release on pypi? [...] If it was just about making a release I could have done it quickly. However, I see two issues I don't have time to look into right now: - the change has no unit test And the port to trunk was completely broken: http://svn.zope.org/?rev=130319view=rev I fixed it here: http://svn.zope.org/?rev=130321view=rev - two others are failing: snip Failure in test test_getActionObject_oldskool_action_deprecated (Products.CMFCore.tests.test_ActionsTool.ActionsToolTests) Traceback (most recent call last): File /usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py, line 331, in run testMethod() CMF 2.2 requires Python 2.6, not 2.7. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
