[Zope-CMF] Re: [dev] tseaver-catalog_events branch
Hi! Jens Vagelpohl wrote: I finally found some time to have a look at the tseaver-catalog_events branch. The last failing test is fixed now and I have some questions: Thanks for that, I think I was at a point where I didn't see the forest for the trees. 1.) The ContentishSublocations adapter is not registered by default, just for unit tests. Why? 2.) Instead of using a customized ISublocations adapter and _recurseOpaques in handleObjectEvent: Can't we just add a new subscriber that dispatches to opaque items like dispatchToSublocations dispatches to sublocations? I think Tres would know best what the original aim was. Well. That doesn't help me if he doesn't tell me :( 3.) Does this branch make the unmerged part of the efge-1.5-five-compatible branch obsolete? Not sure what's in there. Would it make sense to prevent this branch from being left behind more as normal development continues by merging it into the trunk and continuing the remaining polishing there? I did have an other look at tseaver-catalog_events branch and efge-1.5-five-compatible branch. I propose to split these changes into 2 steps: The first step would be to use the events machinery for dispatching to first class sublocations of containers. The necessary work seems to be done on those two branches. If there are no objections I'll merge this work into the trunk and delete the two branches. The second step would be to use the events machinery for dispatching to opaque items. The necessary work is not done jet. I plan to create a new branch for that and to copy related code fragments from the tseaver-catalog_events branch to that new branch. Any objections? Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: [dev] tseaver-catalog_events branch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: Hi! Jens Vagelpohl wrote: I finally found some time to have a look at the tseaver-catalog_events branch. The last failing test is fixed now and I have some questions: Thanks for that, I think I was at a point where I didn't see the forest for the trees. 1.) The ContentishSublocations adapter is not registered by default, just for unit tests. Why? 2.) Instead of using a customized ISublocations adapter and _recurseOpaques in handleObjectEvent: Can't we just add a new subscriber that dispatches to opaque items like dispatchToSublocations dispatches to sublocations? I think Tres would know best what the original aim was. Well. That doesn't help me if he doesn't tell me :( I'm sorry to have dropped the ball. At this point, I've lost most of the context for the original work. I think the answers are: 1) It wasn't quite done yet, so I hadn't wired it up. 2) A separate adapter sounds now like a better plan; I don't remember why the '_recurseOpaques' stuff is there. 3.) Does this branch make the unmerged part of the efge-1.5-five-compatible branch obsolete? Not sure what's in there. Would it make sense to prevent this branch from being left behind more as normal development continues by merging it into the trunk and continuing the remaining polishing there? I did have an other look at tseaver-catalog_events branch and efge-1.5-five-compatible branch. I propose to split these changes into 2 steps: The first step would be to use the events machinery for dispatching to first class sublocations of containers. The necessary work seems to be done on those two branches. If there are no objections I'll merge this work into the trunk and delete the two branches. +1. The second step would be to use the events machinery for dispatching to opaque items. The necessary work is not done jet. I plan to create a new branch for that and to copy related code fragments from the tseaver-catalog_events branch to that new branch. +1 as well. Tres. - -- === Tres Seaver +1 202-558-7113 [EMAIL PROTECTED] Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFEbHOM+gerLs4ltQ4RAn00AKCXJtzHRax3pYMrYqn9aiZNekGDpQCfdtxE WHsCXpPRIhKAvw8Js6o6hbY= =Spsn -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: [dev] tseaver-catalog_events branch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I did have an other look at tseaver-catalog_events branch and efge-1.5-five-compatible branch. I propose to split these changes into 2 steps: The first step would be to use the events machinery for dispatching to first class sublocations of containers. The necessary work seems to be done on those two branches. If there are no objections I'll merge this work into the trunk and delete the two branches. The second step would be to use the events machinery for dispatching to opaque items. The necessary work is not done jet. I plan to create a new branch for that and to copy related code fragments from the tseaver-catalog_events branch to that new branch. You basically put my request to merge the existing work into the trunk and then continuing from there a different way. Yay, that's what I hoped we could get to! ;) jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (Darwin) iD8DBQFEbHTmRAx5nvEhZLIRAoz7AJwPYk9obhjrTZ8FZsI161xUz7kqugCeIZVL ph3WRYLtEyXIuD0DFws7f/M= =o5cg -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: [dev] tseaver-catalog_events branch
Hi! Florent Guillaume wrote: Jens Vagelpohl wrote: 1.) The ContentishSublocations adapter is not registered by default, just for unit tests. Why? 2.) Instead of using a customized ISublocations adapter and _recurseOpaques in handleObjectEvent: Can't we just add a new subscriber that dispatches to opaque items like dispatchToSublocations dispatches to sublocations? I think Tres would know best what the original aim was. I think both ways work. Whichever is best is a matter of taste. Having a second subscriber would mean two recursions more or less in parallel (even though in practice I don't think it would matter); I think I prefer the new ISublocations adapter way. This is the code on the branch: http://svn.zope.org/CMF/branches/tseaver-catalog_events/CMFCore/CMFCatalogAware.py?rev=67268view=markup There are two reasons why I don't like the new ISublocations adapter: 1.) ISublocations might be used for other purposes as well. Adding opaque items to the list returned by sublocations seems not to be in sync with the way the adapter is implemented in Zope 3. 2.) It relies on the fact that SimpleItem implements a dummy objectValues method. But the more important issue is that currently no subscriber is used. Calling _recurseOpaques from handleObjectEvent *is* nasty and the XXX comment should be resolved. 3.) Does this branch make the unmerged part of the efge-1.5-five-compatible branch obsolete? Not sure what's in there. I haven't looked at it in a while or compared it to Tres's, but keep in mind it was just an early experiment to show the way, I'm pretty sure Tres's work obsoletes it. So either someone has to compare those branches or the efge-1.5-five-compatible branch can be removed without looking at it again. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: [dev] tseaver-catalog_events branch
Jens Vagelpohl wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I finally found some time to have a look at the tseaver-catalog_events branch. The last failing test is fixed now and I have some questions: Thanks for that, I think I was at a point where I didn't see the forest for the trees. 1.) The ContentishSublocations adapter is not registered by default, just for unit tests. Why? 2.) Instead of using a customized ISublocations adapter and _recurseOpaques in handleObjectEvent: Can't we just add a new subscriber that dispatches to opaque items like dispatchToSublocations dispatches to sublocations? I think Tres would know best what the original aim was. I think both ways work. Whichever is best is a matter of taste. Having a second subscriber would mean two recursions more or less in parallel (even though in practice I don't think it would matter); I think I prefer the new ISublocations adapter way. 3.) Does this branch make the unmerged part of the efge-1.5-five-compatible branch obsolete? Not sure what's in there. I haven't looked at it in a while or compared it to Tres's, but keep in mind it was just an early experiment to show the way, I'm pretty sure Tres's work obsoletes it. Florent Would it make sense to prevent this branch from being left behind more as normal development continues by merging it into the trunk and continuing the remaining polishing there? -- Florent Guillaume, Nuxeo (Paris, France) Director of RD +33 1 40 33 71 59 http://nuxeo.com [EMAIL PROTECTED] ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
