Re: [Zope-CMF] Re: SVN: CMF/branches/1.6/ Avoid deprecation warnings with Zope 2.10.
Jens Vagelpohl wrote: I'd love to nail this one, it gets boring seeing it in a project's nightly test runs every night... A bit of grepping might find that one. :) Cool, lemme know when you're done :-P Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Re: SVN: CMF/branches/1.6/ Avoid deprecation warnings with Zope 2.10.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12 Jun 2006, at 08:41, Chris Withers wrote: ERROR:foo.bar:eek None 2006-06-09 20:44:24 ERROR foo.bar eek None INFO:foo.bar:blah blah I'd love to nail this one, it gets boring seeing it in a project's nightly test runs every night... A bit of grepping might find that one. :) jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (Darwin) iD8DBQFEjQ39RAx5nvEhZLIRAmCoAJsG+ctpXD9kjW6EanivNWXMBOJXAACfdOLp wW1BryS9ZmYu67mNGrCEJ4Y= =Z3Bv -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Re: SVN: CMF/branches/1.6/ Avoid deprecation warnings with Zope 2.10.
Jens Vagelpohl wrote: 2006-06-09 20:43:01 WARNING ZODB.DB DB.open() has 13 open connections with a pool_size of 7 Looks like someone somewhere ain't closing their zodb connection in a test... ERROR:foo.bar:eek None 2006-06-09 20:44:24 ERROR foo.bar eek None INFO:foo.bar:blah blah I'd love to nail this one, it gets boring seeing it in a project's nightly test runs every night... Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Re: SVN: CMF/branches/1.6/ Avoid deprecation warnings with Zope 2.10.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 9 Jun 2006, at 20:39, Tres Seaver wrote: Florent Guillaume wrote: Tres Seaver wrote: Florent: 1.6 is explicitly supposed to work with Zope 2.8. Have you tested that this change doesn't break that (I don't think 'zope.contenttype.guessContentType' was importable in ZopeX3.0). I've added just another level of try/except ImportError, I don't think it can break as the zope.contentype package didn't exist in Zope 2.8. FWIW, the unit tests run fine under Zope 2.8. The only output I get, which has always been the case on this combination, is a bunch of... 2006-06-09 20:43:01 WARNING ZODB.DB DB.open() has 13 open connections with a pool_size of 7 and this block: ERROR:foo.bar:eek None 2006-06-09 20:44:24 ERROR foo.bar eek None INFO:foo.bar:blah blah But in the end it says OK. jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (Darwin) iD8DBQFEicI9RAx5nvEhZLIRAtvmAKC8AREULUMA4C8qRDhlcsa6mmVGtgCfYQAA yT+gn2533qyZscu/uUPChk0= =nrRK -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: SVN: CMF/branches/1.6/ Avoid deprecation warnings with Zope 2.10.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Florent Guillaume wrote: > Tres Seaver wrote: >> Florent: 1.6 is explicitly supposed to work with Zope 2.8. Have you >> tested that this change doesn't break that (I don't think >> 'zope.contenttype.guessContentType' was importable in ZopeX3.0). > > I've added just another level of try/except ImportError, I don't think > it can break as the zope.contentype package didn't exist in Zope 2.8. > >> 1.6 is a "stepping-stone" for projects which needed the new GenericSetup >> features, but couldn't move all the way to CMF 2.0; making it less >> noisy under 2.10 has to give precedence to preserving BBB. > > Sure, I keep that in mind. Great, thanks! Tres. - -- === Tres Seaver +1 202-558-7113 [EMAIL PROTECTED] Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.2.2 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFEicB6+gerLs4ltQ4RAopdAKCnvLhnf3GHGf6OO2zlhgejDWy4uwCgr9te R2ez0iOJKKADx6TOE+cS5NQ= =lqaH -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: SVN: CMF/branches/1.6/ Avoid deprecation warnings with Zope 2.10.
Tres Seaver wrote: Modified: CMF/branches/1.6/CMFCore/FSFile.py === --- CMF/branches/1.6/CMFCore/FSFile.py 2006-06-09 12:41:27 UTC (rev 68536) +++ CMF/branches/1.6/CMFCore/FSFile.py 2006-06-09 13:40:32 UTC (rev 68537) @@ -22,9 +22,14 @@ from OFS.Cache import Cacheable from OFS.Image import File try: -from zope.app.content_types import guess_content_type -except ImportError: # BBB: for Zope < 2.9 -from OFS.content_types import guess_content_type +from zope.contenttype import guess_content_type +except ImportError: +# BBB: for Zope < 2.10 +try: +from zope.app.content_types import guess_content_type +except ImportError: +# BBB: for Zope < 2.9 +from OFS.content_types import guess_content_type Florent: 1.6 is explicitly supposed to work with Zope 2.8. Have you tested that this change doesn't break that (I don't think 'zope.contenttype.guessContentType' was importable in ZopeX3.0). I've added just another level of try/except ImportError, I don't think it can break as the zope.contentype package didn't exist in Zope 2.8. 1.6 is a "stepping-stone" for projects which needed the new GenericSetup features, but couldn't move all the way to CMF 2.0; making it less noisy under 2.10 has to give precedence to preserving BBB. Sure, I keep that in mind. Florent -- Florent Guillaume, Nuxeo (Paris, France) Director of R&D +33 1 40 33 71 59 http://nuxeo.com [EMAIL PROTECTED] ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: SVN: CMF/branches/1.6/ Avoid deprecation warnings with Zope 2.10.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Florent Guillaume wrote: > Log message for revision 68537: > Avoid deprecation warnings with Zope 2.10. > > Changed: > U CMF/branches/1.6/CMFCore/FSFile.py > U CMF/branches/1.6/DCWorkflow/Expression.py > > -=- > Modified: CMF/branches/1.6/CMFCore/FSFile.py > === > --- CMF/branches/1.6/CMFCore/FSFile.py2006-06-09 12:41:27 UTC (rev > 68536) > +++ CMF/branches/1.6/CMFCore/FSFile.py2006-06-09 13:40:32 UTC (rev > 68537) > @@ -22,9 +22,14 @@ > from OFS.Cache import Cacheable > from OFS.Image import File > try: > -from zope.app.content_types import guess_content_type > -except ImportError: # BBB: for Zope < 2.9 > -from OFS.content_types import guess_content_type > +from zope.contenttype import guess_content_type > +except ImportError: > +# BBB: for Zope < 2.10 > +try: > +from zope.app.content_types import guess_content_type > +except ImportError: > +# BBB: for Zope < 2.9 > +from OFS.content_types import guess_content_type > > from DirectoryView import registerFileExtension > from DirectoryView import registerMetaType > > Modified: CMF/branches/1.6/DCWorkflow/Expression.py > === > --- CMF/branches/1.6/DCWorkflow/Expression.py 2006-06-09 12:41:27 UTC (rev > 68536) > +++ CMF/branches/1.6/DCWorkflow/Expression.py 2006-06-09 13:40:32 UTC (rev > 68537) > @@ -24,9 +24,26 @@ > from Products.CMFCore.WorkflowCore import ObjectDeleted, ObjectMoved > from Products.CMFCore.Expression import Expression > from Products.PageTemplates.Expressions import getEngine > -from Products.PageTemplates.TALES import SafeMapping > from Products.PageTemplates.Expressions import SecureModuleImporter > > + > +# We don't import SafeMapping from Products.PageTemplates.TALES > +# because it's deprecated in Zope 2.10 > +from MultiMapping import MultiMapping > +class SafeMapping(MultiMapping): > +"""Mapping with security declarations and limited method exposure. > + > +Since it subclasses MultiMapping, this class can be used to wrap > +one or more mapping objects. Restricted Python code will not be > +able to mutate the SafeMapping or the wrapped mappings, but will be > +able to read any value. > +""" > +__allow_access_to_unprotected_subobjects__ = 1 > +push = pop = None > +_push = MultiMapping.push > +_pop = MultiMapping.pop > + > + > class StateChangeInfo: > ''' > Provides information for expressions and scripts. Florent: 1.6 is explicitly supposed to work with Zope 2.8. Have you tested that this change doesn't break that (I don't think 'zope.contenttype.guessContentType' was importable in ZopeX3.0). 1.6 is a "stepping-stone" for projects which needed the new GenericSetup features, but couldn't move all the way to CMF 2.0; making it less noisy under 2.10 has to give precedence to preserving BBB. Tres. - -- === Tres Seaver +1 202-558-7113 [EMAIL PROTECTED] Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.2.2 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFEiaUZ+gerLs4ltQ4RAmxEAJ4lYDMzW2Wnc6wUP9ZbAp8iP9aQkgCbBkWj 4vjYlv3ipHBNOxHgyAR1Rlo= =u2Nf -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
