Re: [Zope-CMF] Removing ancient LoginManager-compatibility code
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12 Mar 2007, at 19:48, Dieter Maurer wrote: Jens Vagelpohl wrote at 2007-3-12 10:11 +0100: There's some LoginManager compatibility code in CMFCore.MembershipTool (see __getPUS and addMember) that I would like to remove. LoginManager has gone the way of the Dodo several years ago, I'd say at least 4 years ago. IMHO with this stuff there is no need for a deprecation period. Comments or suggestions? Silence is consent ;) I often wonder whether you do not have more pressing tasks :-) Me would never come to the idea to do such cosmetic changes... I don't consider this a cosmetic change at all. The code is cruft, its existence serves no purpose other than to bloat the code base and possibly confuse the reader. I noticed the code as I was working on the tool-utility task. I'm not sitting and reading every module to point out cruft. I'm glad I currently have the time to look at these little things. What I do and don't do in my spare time is domething I'd like to decide myself, and it's not up to the casual observer to judge how I spend it :P jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFF9bw/RAx5nvEhZLIRAnRqAJ4t6pYHRQFEFfPJz0kkg7Pub07oWACgp3Fx M61nIco8jx9NVmTIV2Lejw0= =kfkD -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Removing ancient LoginManager-compatibility code
Jens Vagelpohl wrote at 2007-3-12 10:11 +0100: >There's some LoginManager compatibility code in >CMFCore.MembershipTool (see __getPUS and addMember) that I would like >to remove. LoginManager has gone the way of the Dodo several years >ago, I'd say at least 4 years ago. IMHO with this stuff there is no >need for a deprecation period. > >Comments or suggestions? Silence is consent ;) I often wonder whether you do not have more pressing tasks :-) Me would never come to the idea to do such cosmetic changes... -- Dieter ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Removing ancient LoginManager-compatibility code
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There's some LoginManager compatibility code in CMFCore.MembershipTool (see __getPUS and addMember) that I would like to remove. LoginManager has gone the way of the Dodo several years ago, I'd say at least 4 years ago. IMHO with this stuff there is no need for a deprecation period. Comments or suggestions? Silence is consent ;) jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFF9Rk1RAx5nvEhZLIRAkjYAJ9jhePrAW7NrtJpxrP/BlJ2rGziQACggx2w G5gAjK4tk86C+4sNdA1UyHA= =yXUB -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
