Re: [Zope-CMF] [dev] 'request' in expression context

2006-04-27 Thread Jens Vagelpohl

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


On 26 Apr 2006, at 17:25, yuppie wrote:


Hi!


In createExprContext 'request' is currently set to getattr(object,  
'REQUEST', None). 'object' might be None, making 'request' None as  
well.


Would anybody mind if I change that to getattr(portal, 'REQUEST',  
None)?


I don't mind, just wondering what cases you came up against where  
object was None.


jens

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFEUIHwRAx5nvEhZLIRAnOeAKC1yq5eAkIMhcBrNyWysjYbZhzhiQCdE3dV
PSJdOPBpoxJ95cUPRWI6a4w=
=eoXA
-END PGP SIGNATURE-
___
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests


Re: [Zope-CMF] [dev] 'request' in expression context

2006-04-27 Thread Dieter Maurer
yuppie wrote at 2006-4-26 18:25 +0200:
In createExprContext 'request' is currently set to getattr(object, 
'REQUEST', None). 'object' might be None, making 'request' None as well.

Would anybody mind if I change that to getattr(portal, 'REQUEST', None)?

AFAICS portal is always available and can acquire REQUEST.


If there are no objections I'll fix this in CMF 1.5, 1.6, 2.0 and trunk.

A very good idea!


-- 
Dieter
___
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests