Re: [Zope-CMF] Five's local sitemanager, CMF, etc
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26 Feb 2007, at 17:03, Martin Aspeli wrote: To get to the portal root / CMF site, I suggest a pattern that is sometimes used in Zope3: We register the CMF site object as a utility providing ICMFSite (or whatever). Then whichever code that's executed below the portal (and that includes CMF tools) can do getUtility(ICMFSite) to get to the site. +1 - in fact, we already have Products.CMFCore.interfaces.ISiteRoot. I use it all the time. :) This is now completed on the branch. I did not try to locate every single place in the code where the site is looked up, though. I patched a couple specific places pointed out by Yuppie, and the main URLTool.getPortalObject method to use the utility. jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFF6szDRAx5nvEhZLIRAihRAJ9HejiRPThS2Tck/nbFnPv3s1jVUQCgmnck L4NMFaWpqLE0zozhuc5oo/g= =6FX+ -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Five's local sitemanager, CMF, etc
Philipp von Weitershausen wrote: Rocky wrote: On Feb 23, 3:50 pm, Martin Aspeli [EMAIL PROTECTED] wrote: yuppie wrote: Maybe I'm missing something. But wasn't a major goal of five.localsitemanager to return acquisition wrapped tools? That was my understanding, too. I thought this would just mean aq_base'ing the utility and aq-wrapping it back into the context (the portal root). Without this, we start requiring users of the interface to know when aq wrapping is needed and do it explicitly with __of__() which I think we agreed was unacceptably detailed and ugly. :) Alright, I've gone ahead and put code in place for this (albeit a bit naively) with r72810. The next question is whether we should be doing the same with adapters and subscribers as well (even though this doesn't affect the whole tools-getting-acquired-properly issue). One more thing: This acquisition wrapping should clearly be marked (with comments) as something that's done to for BBB because some tools happen to want acquisition. I think in the future, it should be discouraged to expect acquisition in CMF tools. To get to the portal root / CMF site, I suggest a pattern that is sometimes used in Zope3: We register the CMF site object as a utility providing ICMFSite (or whatever). Then whichever code that's executed below the portal (and that includes CMF tools) can do getUtility(ICMFSite) to get to the site. +1 - in fact, we already have Products.CMFCore.interfaces.ISiteRoot. I use it all the time. :) Martin -- View this message in context: http://www.nabble.com/Five%27s-local-sitemanager%2C-CMF%2C-etc-tf3219557.html#a9161398 Sent from the Zope - CMF list2 mailing list archive at Nabble.com. ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Five's local sitemanager, CMF, etc
Previously Jens Vagelpohl wrote: On 12 Feb 2007, at 17:42, Rocky wrote: First off, please forgive me if this comes through twice... not sure if I sent it the first time or not. So here's what the consensus seems to be regarding CMF and the local site manager business. Hey Rocky, any progress? Haven't heard and loud yelling from Wichert yet, but I think he's getting close to the Plone 3.0 beta by now... I'm hoping for upcoming monday.. I'ld also love to see the yuppie-collector467 merged. It has tests and it works for me :) Wichert. -- Wichert Akkerman [EMAIL PROTECTED]It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Five's local sitemanager, CMF, etc
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22 Feb 2007, at 09:03, Wichert Akkerman wrote: Hey Rocky, any progress? Haven't heard and loud yelling from Wichert yet, but I think he's getting close to the Plone 3.0 beta by now... I'm hoping for upcoming monday.. Merging the branch into the trunk is going to be a bit of work. I'm volunteering to do it, but I really need something from Rocky today or tomorrow to meet your Monday deadline. jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFF3Vf+RAx5nvEhZLIRAoMYAJ46nEcrapTuMePcl90OZWQhDR4ptQCfaU1c 1G7Dlj3F3cwFPIfDBAKSA7E= =DUGu -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Five's local sitemanager, CMF, etc
yuppie-3 wrote: Jens Vagelpohl wrote: On 22 Feb 2007, at 09:03, Wichert Akkerman wrote: Hey Rocky, any progress? Haven't heard and loud yelling from Wichert yet, but I think he's getting close to the Plone 3.0 beta by now... I'm hoping for upcoming monday.. Merging the branch into the trunk is going to be a bit of work. I'm volunteering to do it, but I really need something from Rocky today or tomorrow to meet your Monday deadline. IIRC existing CMF sites stop working with that branch. That has to be resolved before releasing a beta. In general I'm no fan of last minute merges. There should be several days between merging a big branch like that and releasing a beta. In my opinion only: I'm sure we can release a Plone beta 1 that depends on a CMF alpha if that needs to be. It's not ideal, but we can synchronise a little later if it's impractical for everyone involved. So, Rocky - progress? Martin -- View this message in context: http://www.nabble.com/Five%27s-local-sitemanager%2C-CMF%2C-etc-tf3219557.html#a9098256 Sent from the Zope - CMF list2 mailing list archive at Nabble.com. ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Five's local sitemanager, CMF, etc
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12 Feb 2007, at 17:42, Rocky wrote: First off, please forgive me if this comes through twice... not sure if I sent it the first time or not. So here's what the consensus seems to be regarding CMF and the local site manager business. Hey Rocky, any progress? Haven't heard and loud yelling from Wichert yet, but I think he's getting close to the Plone 3.0 beta by now... jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFF3I8PRAx5nvEhZLIRAhX7AJ4rySZGJ6nWvpKzL8bFf9nuvAHyTQCdFF+8 bDRMmRwNRkRFzrWGb6lMQLc= =HGQ6 -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
Re: [Zope-CMF] Five's local sitemanager, CMF, etc
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12 Feb 2007, at 17:42, Rocky wrote: So here's what the consensus seems to be regarding CMF and the local site manager business. Your description sounds good to me. Questions? Comments? Any suggestions on which CMF product to do this in? I'm leaning towards CMFCore personally as without this part of the intended CMF functionality is not available. It must be CMFCore. jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFF0Y0GRAx5nvEhZLIRArHgAJ4xzaEuyr01YFSphxgTz0BoJxMqFwCbBL2R Q15cvigHJXJqv1Wg2UysCgA= =M9/j -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
