Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
I'd like some review before merging the fix into trunk.
I do not know for sure that I can remove the type check.
Thanks
Gotcha
Le 13/01/11 12:00, Godefroid Chapelle a écrit :
Log message for revision 119561:
On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
Aren't you risking double encoding now? That patch looks like it makes
things worse, not better.
Wichert.
___
Zope-CMF
Summary of messages to the cmf-tests list.
Period Wed Jan 12 12:00:00 2011 UTC to Thu Jan 13 12:00:00 2011 UTC.
There were 7 messages: 7 from CMF Tests.
Tests passed OK
---
Subject: OK : CMF-2.1 Zope-2.10 Python-2.4.6 : Linux
From: CMF Tests
Date: Thu Jan 13 01:31:13 EST 2011
URL:
Le 13/01/11 12:07, Wichert Akkerman a écrit :
On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
Aren't you risking double encoding now? That patch looks like it makes
things worse, not better.
I am not sure I
On 1/13/11 14:01 , Godefroid Chapelle wrote:
Le 13/01/11 12:07, Wichert Akkerman a écrit :
On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
Aren't you risking double encoding now? That patch looks like it
Le 13/01/11 14:02, Wichert Akkerman a écrit :
On 1/13/11 14:01 , Godefroid Chapelle wrote:
Le 13/01/11 12:07, Wichert Akkerman a écrit :
On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
Aren't you risking
Le 13/01/11 14:17, Godefroid Chapelle a écrit :
Le 13/01/11 14:02, Wichert Akkerman a écrit :
On 1/13/11 14:01 , Godefroid Chapelle wrote:
Le 13/01/11 12:07, Wichert Akkerman a écrit :
On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see
Am 13.01.2011, 14:01 Uhr, schrieb Godefroid Chapelle got...@bubblenet.be:
Aren't you risking double encoding now? That patch looks like it makes
things worse, not better.
I am not sure I understand what you mean.
Hi Godefroid,
the unpatched code checks to see whether a self.Title() or
Le 13/01/11 14:41, Charlie Clark a écrit :
Am 13.01.2011, 14:01 Uhr, schrieb Godefroid Chapellegot...@bubblenet.be:
Aren't you risking double encoding now? That patch looks like it makes
things worse, not better.
I am not sure I understand what you mean.
Hi Godefroid,
the unpatched code
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/13/2011 11:03 AM, Godefroid Chapelle wrote:
Le 13/01/11 15:04, Tres Seaver a écrit :
This change should be reverted -- you now double-encode any
already-encoded UTF=8 strings. We should probably add a test for that
condition.
Change
Godefroid Chapelle wrote:
One buildout per package is the practice in ZTK world.
I have come to really appreciate it; it really lowers the barrier for
contributions.
checkout
bootstrap
buildout
run tests to check state before changes
fix
run tests
commit
That only works if someone
Le 13/01/11 17:03, Godefroid Chapelle a écrit :
Le 13/01/11 15:04, Tres Seaver a écrit :
This change should be reverted -- you now double-encode any
already-encoded UTF=8 strings. We should probably add a test for that
condition.
Change reverted, test added in 119566.
After having tuned
Le 13/01/11 17:50, yuppie a écrit :
Godefroid Chapelle wrote:
One buildout per package is the practice in ZTK world.
I have come to really appreciate it; it really lowers the barrier for
contributions.
checkout
bootstrap
buildout
run tests to check state before changes
fix
run tests
13 matches
Mail list logo