Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
I'd like some review before merging the fix into trunk.
I do not know for sure that I can remove the type check.
Thanks
Gotcha
Le 13/01/11 12:00, Godefroid Chapelle a écrit :
> Log message for revision 119561:
On 1/13/11 12:04 , Godefroid Chapelle wrote:
> Hi,
>
> I have fixed an exportimport bug on branch 2.2 : see tests in revision
> 119560.
Aren't you risking double encoding now? That patch looks like it makes
things worse, not better.
Wichert.
___
Zope-C
Summary of messages to the cmf-tests list.
Period Wed Jan 12 12:00:00 2011 UTC to Thu Jan 13 12:00:00 2011 UTC.
There were 7 messages: 7 from CMF Tests.
Tests passed OK
---
Subject: OK : CMF-2.1 Zope-2.10 Python-2.4.6 : Linux
From: CMF Tests
Date: Thu Jan 13 01:31:13 EST 2011
URL: ht
Le 13/01/11 12:07, Wichert Akkerman a écrit :
> On 1/13/11 12:04 , Godefroid Chapelle wrote:
>> Hi,
>>
>> I have fixed an exportimport bug on branch 2.2 : see tests in revision
>> 119560.
>
> Aren't you risking double encoding now? That patch looks like it makes
> things worse, not better.
I am no
On 1/13/11 14:01 , Godefroid Chapelle wrote:
>
>
> Le 13/01/11 12:07, Wichert Akkerman a écrit :
>> On 1/13/11 12:04 , Godefroid Chapelle wrote:
>>> Hi,
>>>
>>> I have fixed an exportimport bug on branch 2.2 : see tests in revision
>>> 119560.
>>
>> Aren't you risking double encoding now? That patc
Le 13/01/11 14:02, Wichert Akkerman a écrit :
> On 1/13/11 14:01 , Godefroid Chapelle wrote:
>>
>>
>> Le 13/01/11 12:07, Wichert Akkerman a écrit :
>>> On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
Le 13/01/11 14:17, Godefroid Chapelle a écrit :
> Le 13/01/11 14:02, Wichert Akkerman a écrit :
>> On 1/13/11 14:01 , Godefroid Chapelle wrote:
>>>
>>>
>>> Le 13/01/11 12:07, Wichert Akkerman a écrit :
On 1/13/11 12:04 , Godefroid Chapelle wrote:
> Hi,
>
> I have fixed an exportimp
Am 13.01.2011, 14:01 Uhr, schrieb Godefroid Chapelle :
>> Aren't you risking double encoding now? That patch looks like it makes
>> things worse, not better.
> I am not sure I understand what you mean.
Hi Godefroid,
the unpatched code checks to see whether a self.Title() or
self.Description()
Le 13/01/11 14:41, Charlie Clark a écrit :
> Am 13.01.2011, 14:01 Uhr, schrieb Godefroid Chapelle:
>
>>> Aren't you risking double encoding now? That patch looks like it makes
>>> things worse, not better.
>> I am not sure I understand what you mean.
>
> Hi Godefroid,
>
> the unpatched code checks
On Thu, Jan 13, 2011 at 2:17 PM, Godefroid Chapelle wrote:
> You make me wonder if I am actually reproducing something wrong in my
> tests setup : am I allowed to set a unicode value in Title and Description ?
I'm not sure what the Unicode story is like for CMF. I'd expect there
to be no conversi
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/13/2011 06:00 AM, Godefroid Chapelle wrote:
> Log message for revision 119561:
> remove type check that seem useless
>
> Changed:
> U Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py
>
> -=-
> Modified:
> Products.C
Le 13/01/11 15:03, Hanno Schlichting a écrit :
> On Thu, Jan 13, 2011 at 2:17 PM, Godefroid Chapelle
> wrote:
>> You make me wonder if I am actually reproducing something wrong in my
>> tests setup : am I allowed to set a unicode value in Title and Description ?
>
> I'm not sure what the Unicode
Am 13.01.2011, 15:27 Uhr, schrieb Godefroid Chapelle :
>
> http://zope3.pov.lt/trac/changeset/119560/Products.CMFCore/branches/2.2
That looks okay to me but I'm not sure if it should stay quite that way -
a dedicated method for encoding might be preferable. But I'm not sure if
the encoding sh
Le 13/01/11 15:52, Charlie Clark a écrit :
> Am 13.01.2011, 15:27 Uhr, schrieb Godefroid Chapelle:
>
>>
>> http://zope3.pov.lt/trac/changeset/119560/Products.CMFCore/branches/2.2
>
> That looks okay to me but I'm not sure if it should stay quite that way -
> a dedicated method for encoding might be
Le 13/01/11 15:04, Tres Seaver a écrit :
>
> This change should be reverted -- you now double-encode any
> already-encoded UTF=8 strings. We should probably add a test for that
> condition.
Change reverted, test added in 119566.
>
>
> Tres.
> - --
--
Godefroid Chapelle (aka __gotcha) http://bu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/13/2011 11:03 AM, Godefroid Chapelle wrote:
> Le 13/01/11 15:04, Tres Seaver a écrit :
>>
>> This change should be reverted -- you now double-encode any
>> already-encoded UTF=8 strings. We should probably add a test for that
>> condition.
>
>
Hi!
Godefroid Chapelle wrote:
> I even added the missing buildout (copied from trunk - see revision 119553).
You know http://svn.zope.org/CMF/branches/2.2/ and
http://svn.zope.org/CMF/trunk/ ?
These buildouts are used for developing and testing all CMF Products. Do
we also need bootstrap and
Le 13/01/11 17:25, yuppie a écrit :
> Hi!
>
>
> Godefroid Chapelle wrote:
>> I even added the missing buildout (copied from trunk - see revision 119553).
>
> You know http://svn.zope.org/CMF/branches/2.2/ and
> http://svn.zope.org/CMF/trunk/ ?
>
> These buildouts are used for developing and testing
Godefroid Chapelle wrote:
> One buildout per package is the practice in ZTK world.
>
> I have come to really appreciate it; it really lowers the barrier for
> contributions.
>
> checkout
> bootstrap
> buildout
> run tests to check state before changes
> fix
> run tests
> commit
That only works if
Le 13/01/11 17:03, Godefroid Chapelle a écrit :
> Le 13/01/11 15:04, Tres Seaver a écrit :
>>
>> This change should be reverted -- you now double-encode any
>> already-encoded UTF=8 strings. We should probably add a test for that
>> condition.
>
> Change reverted, test added in 119566.
>
After ha
Le 13/01/11 17:50, yuppie a écrit :
> Godefroid Chapelle wrote:
>> One buildout per package is the practice in ZTK world.
>>
>> I have come to really appreciate it; it really lowers the barrier for
>> contributions.
>>
>> checkout
>> bootstrap
>> buildout
>> run tests to check state before changes
21 matches
Mail list logo