Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Godefroid Chapelle
Hi, I have fixed an exportimport bug on branch 2.2 : see tests in revision 119560. I'd like some review before merging the fix into trunk. I do not know for sure that I can remove the type check. Thanks Gotcha Le 13/01/11 12:00, Godefroid Chapelle a écrit : Log message for revision 119561:

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Wichert Akkerman
On 1/13/11 12:04 , Godefroid Chapelle wrote: Hi, I have fixed an exportimport bug on branch 2.2 : see tests in revision 119560. Aren't you risking double encoding now? That patch looks like it makes things worse, not better. Wichert. ___ Zope-CMF

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Godefroid Chapelle
Le 13/01/11 12:07, Wichert Akkerman a écrit : On 1/13/11 12:04 , Godefroid Chapelle wrote: Hi, I have fixed an exportimport bug on branch 2.2 : see tests in revision 119560. Aren't you risking double encoding now? That patch looks like it makes things worse, not better. I am not sure I

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Wichert Akkerman
On 1/13/11 14:01 , Godefroid Chapelle wrote: Le 13/01/11 12:07, Wichert Akkerman a écrit : On 1/13/11 12:04 , Godefroid Chapelle wrote: Hi, I have fixed an exportimport bug on branch 2.2 : see tests in revision 119560. Aren't you risking double encoding now? That patch looks like it

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Godefroid Chapelle
Le 13/01/11 14:02, Wichert Akkerman a écrit : On 1/13/11 14:01 , Godefroid Chapelle wrote: Le 13/01/11 12:07, Wichert Akkerman a écrit : On 1/13/11 12:04 , Godefroid Chapelle wrote: Hi, I have fixed an exportimport bug on branch 2.2 : see tests in revision 119560. Aren't you risking

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Godefroid Chapelle
Le 13/01/11 14:17, Godefroid Chapelle a écrit : Le 13/01/11 14:02, Wichert Akkerman a écrit : On 1/13/11 14:01 , Godefroid Chapelle wrote: Le 13/01/11 12:07, Wichert Akkerman a écrit : On 1/13/11 12:04 , Godefroid Chapelle wrote: Hi, I have fixed an exportimport bug on branch 2.2 : see

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Charlie Clark
Am 13.01.2011, 14:01 Uhr, schrieb Godefroid Chapelle got...@bubblenet.be: Aren't you risking double encoding now? That patch looks like it makes things worse, not better. I am not sure I understand what you mean. Hi Godefroid, the unpatched code checks to see whether a self.Title() or

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Godefroid Chapelle
Le 13/01/11 14:41, Charlie Clark a écrit : Am 13.01.2011, 14:01 Uhr, schrieb Godefroid Chapellegot...@bubblenet.be: Aren't you risking double encoding now? That patch looks like it makes things worse, not better. I am not sure I understand what you mean. Hi Godefroid, the unpatched code

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/13/2011 11:03 AM, Godefroid Chapelle wrote: Le 13/01/11 15:04, Tres Seaver a écrit : This change should be reverted -- you now double-encode any already-encoded UTF=8 strings. We should probably add a test for that condition. Change

Re: [Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

2011-01-13 Thread Godefroid Chapelle
Le 13/01/11 17:03, Godefroid Chapelle a écrit : Le 13/01/11 15:04, Tres Seaver a écrit : This change should be reverted -- you now double-encode any already-encoded UTF=8 strings. We should probably add a test for that condition. Change reverted, test added in 119566. After having tuned