[Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-12 Thread Yuppie
Evan Simpson wrote: Argh. A bug in my refactoring of the tests made them all pass without really testing. I *think* it's fixed now. Thanks! Looks much better now :-) Cheers, Yuppie ___ Zope-Dev maillist - [EMAIL PROTECTED]

[Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-11 Thread Yuppie
Hi Evan! Evan Simpson wrote: Done and done! ??? Are you sure? Today I built Zope 2.7 from a new checkout. And all icons in the ZMI are broken :-( They have src paths starting with // I didn't have a closer look at your checkin, but I'm afraid something went wrong. Cheers, Yuppie

[Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-11 Thread Evan Simpson
Yuppie wrote: Today I built Zope 2.7 from a new checkout. And all icons in the ZMI are broken :-( They have src paths starting with // Argh. A bug in my refactoring of the tests made them all pass without really testing. I *think* it's fixed now. Sorry, Evan @ 4-am

Re: [Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-10 Thread Lennart Regebro
From: Evan Simpson [EMAIL PROTECTED] Lennart proposed additional methods, but I'm going to work on that in the post-2.7 branches, since I really want to clean up this mess properly, and beta 3 isn't the time. I totally agree. This is new features, introducing that in a beta3 seems very bad. I

Re: [Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-10 Thread Evan Simpson
Brian Lloyd wrote: Good call. I think it would be best to make sure the docstring of the new method is clear on its reason for being. I think somewhere there is an interface file that is used to generate some of the api docs - ideally that can get updated too. Done and done! Cheerios, Evan

[Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-09 Thread Evan Simpson
Summary: absolute_url(1) didn't include the path to the virtual root, which broke code that assumed that it could just prepend / in all cases. I changed it to include the base path, and broke code that prepends BASEPATH1. Since the old behavior existed for two years (including part of the 2.7

Re: [Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-09 Thread Toby Dickenson
On Tuesday 09 December 2003 16:24, Evan Simpson wrote: Summary: absolute_url(1) Looks good. -- Toby Dickenson ___ Zope-Dev maillist - [EMAIL PROTECTED] http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! **

Re: [Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-09 Thread Paul Winkler
On Tue, Dec 09, 2003 at 10:24:47AM -0600, Evan Simpson wrote: def absolute_url_path(self): '''Return the entire path of the absolute URL for this object. This includes the leading slash, and can be used as an absolute-path reference as defined in RFC 2396. ''' OK. But maybe

RE: [Zope-dev] Re: Post-mortem [Was: Zope 2.7.0 b3 regressions]

2003-12-09 Thread Brian Lloyd
Summary: absolute_url(1) didn't include the path to the virtual root, which broke code that assumed that it could just prepend / in all cases. I changed it to include the base path, and broke code that prepends BASEPATH1. Since the old behavior existed for two years (including part of