Re: [Zope-dev] zope-tests - FAILED: 6, OK: 12

2013-09-18 Thread Marius Gedminas
On Wed, Sep 18, 2013 at 01:00:02AM +0200, Zope tests summarizer wrote: [1]winbot / ZODB_dev py_265_win64 Non-deterministic test failure: Failure in test c:\buildslave\zodb_dev_py_265_win64\build\src\ZODB\historical_connections.txt

Re: [Zope-dev] zope-tests - FAILED: 6, OK: 12

2013-09-18 Thread Marius Gedminas
On Wed, Sep 18, 2013 at 11:11:50AM +0300, Marius Gedminas wrote: On Wed, Sep 18, 2013 at 01:00:02AM +0200, Zope tests summarizer wrote: [6]winbot / zope.testbrowser_py_265_32 The fix that was supposed to fix this didn't because https://github.com/Pylons/webtest/pull/87/files#r6427276

[Zope-dev] (optional) CSRF protection in zope.formlib

2013-09-18 Thread Jan-Wijbrand Kolman
Hi, I've been working on CSRF protection for zope.formlib. I have a csrfprotection branch in my zope.formlib fork on github. The changes against the current zope.formlib mainline can be found here: https://github.com/janwijbrand/zope.formlib/compare/csrfprotection When creating form

Re: [Zope-dev] (optional) CSRF protection in zope.formlib

2013-09-18 Thread Leonardo Rochael Almeida
Hi Jan-Wij, +1 for implementing convenient CSRF. I wonder if you could make your implementation more orthogonal by implementing a CSRF field/widget, and make your `protected` attribute simply trigger the inclusion of this field implicitly. This way you wouldn't need to change the `*pageform.pt`

Re: [Zope-dev] (optional) CSRF protection in zope.formlib

2013-09-18 Thread Jan-Wijbrand Kolman
On 9/18/13 5:26 PM, Leonardo Rochael Almeida wrote: +1 for implementing convenient CSRF. I wonder if you could make your implementation more orthogonal by implementing a CSRF field/widget, and make your `protected` attribute simply trigger the inclusion of this field implicitly. This way you

[Zope-dev] zope-tests - FAILED: 5, OK: 13

2013-09-18 Thread Zope tests summarizer
This is the summary for test reports received on the zope-tests list between 2013-09-17 00:00:00 UTC and 2013-09-18 00:00:00 UTC: See the footnotes for test reports of unsuccessful builds. An up-to date view of the builders is also available in our buildbot documentation: