Re: [Zope-dev] PathIndex unindex fix

2002-11-24 Thread Andreas Jung
If you have write access to the Zope CVS, go ahead. Thanks, Andreas --On Donnerstag, 21. November 2002 17:35 + seb bacon [EMAIL PROTECTED] wrote: I've already fixed it; should I commit it or do you want the patches? Andreas Jung wrote: Please file a collector issue and assign it to me.

Re: [Zope-dev] PathIndex unindex fix

2002-11-22 Thread Chris Withers
Leonardo Rochael Almeida wrote: If you are to ignore errors, please ignore specific errors that are known to happen. Please don't use a generic except. ...or re-raise only ConflictErrors. Hmmm... this issue is perhaps deeper than it first appeared. Are conflict errors swallowed by the other

[Zope-dev] PathIndex unindex fix

2002-11-21 Thread seb bacon
Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? On upgrading to Zope 2.6 some if the unindex paths seem to have got hosed, and I don't want this breaking my site. ___ Zope-Dev maillist -

Re: [Zope-dev] PathIndex unindex fix

2002-11-21 Thread Jens Vagelpohl
+1 from me... most other PluginIndexes already fail gracefully when something to be unindexed has disappeared. IMHO all indexes should behave that way. jens On Thursday, Nov 21, 2002, at 08:24 US/Eastern, seb bacon wrote: Anyone object to me changing PathIndex so it swallows exceptions and

Re: [Zope-dev] PathIndex unindex fix

2002-11-21 Thread Sidnei da Silva
On Thu, Nov 21, 2002 at 08:52:41AM -0500, Jens Vagelpohl wrote: | +1 from me... most other PluginIndexes already fail gracefully when | something to be unindexed has disappeared. IMHO all indexes should | behave that way. Now that you mentioned, I got an error while trying to index NZO using

Re: [Zope-dev] PathIndex unindex fix

2002-11-21 Thread Andreas Jung
Please file a collector issue and assign it to me. -aj --On Donnerstag, 21. November 2002 13:24 + seb bacon [EMAIL PROTECTED] wrote: Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? On upgrading to Zope 2.6 some if the unindex paths

Re: [Zope-dev] PathIndex unindex fix

2002-11-21 Thread Chris Withers
Sidnei da Silva wrote: Now that you mentioned, I got an error while trying to index NZO using ZCTextIndex, so I guess it is suffering from the same issue. Anyone can confirm? No, no, failure during _indexing_ is a good thing (tm). Failure during _unindexing_ is a bad thing (r). cheers,

Re: [Zope-dev] PathIndex unindex fix

2002-11-21 Thread Leonardo Rochael Almeida
On Thu, 2002-11-21 at 11:24, seb bacon wrote: Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? This sounds REALLY LOUD ALARMS in my head. There is a class of errors (subclasses of ConflictError) that should never be ingored because they're

Re: [Zope-dev] PathIndex unindex fix

2002-11-21 Thread seb bacon
I've already fixed it; should I commit it or do you want the patches? Andreas Jung wrote: Please file a collector issue and assign it to me. -aj --On Donnerstag, 21. November 2002 13:24 + seb bacon [EMAIL PROTECTED] wrote: Anyone object to me changing PathIndex so it swallows exceptions