Re: [Zope-dev] SVN: z3c.form/trunk/ ``GroupForm`` and ``Group`` now use ``getContent`` method when instantiating group classes instead of directly accessing ``self.context``, as this is the usual way

2010-01-19 Thread Laurent Mignon
Hi, I doesn't understand the motivation behind this change and I've the feeling that it'll break some existing code May be am I wrong but ``getContent`` method is used to provides values to widgets and actions as described into the interface: '''Return the content to be displayed and/or

Re: [Zope-dev] SVN: z3c.form/trunk/ ``GroupForm`` and ``Group`` now use ``getContent`` method when instantiating group classes instead of directly accessing ``self.context``, as this is the usual way

2010-01-19 Thread Michael Howitz
Am 19.01.2010 um 09:44 schrieb Laurent Mignon: Hi, I doesn't understand the motivation behind this change and I've the feeling that it'll break some existing code The motivation is the following: self.getContent() seems to be the pattern to access the context of a form. I used grep:

Re: [Zope-dev] SVN: z3c.form/trunk/ ``GroupForm`` and ``Group`` now use ``getContent`` method when instantiating group classes instead of directly accessing ``self.context``, as this is the usual way

2010-01-19 Thread Laurent Mignon
Michael Howitz wrote: The motivation is the following: self.getContent() seems to be the pattern to access the context of a form. I used grep: there is no place where self.context is used directly besides in group.py. So it seems to be an error in the code not to use the common pattern.

Re: [Zope-dev] SVN: z3c.form/trunk/ ``GroupForm`` and ``Group`` now use ``getContent`` method when instantiating group classes instead of directly accessing ``self.context``, as this is the usual way

2010-01-19 Thread Michael Howitz
Am 19.01.2010 um 16:58 schrieb Laurent Mignon: Michael Howitz wrote: The motivation is the following: self.getContent() seems to be the pattern to access the context of a form. I used grep: there is no place where self.context is used directly besides in group.py. So it seems to be an

Re: [Zope-dev] SVN: z3c.form/trunk/ ``GroupForm`` and ``Group`` now use ``getContent`` method when instantiating group classes instead of directly accessing ``self.context``, as this is the usual way

2010-01-19 Thread Michael Howitz
Am 19.01.2010 um 21:30 schrieb Stephan Richter: On Tuesday 19 January 2010, Michael Howitz wrote: My understand of ``getContent`` is to provide a way to give values used by the widgets. By default, since the common use case is to edit / display values from the context, the implementation

Re: [Zope-dev] SVN: z3c.form/trunk/ ``GroupForm`` and ``Group`` now use ``getContent`` method when instantiating group classes instead of directly accessing ``self.context``, as this is the usual way

2010-01-19 Thread Laurent Mignon
On Tue, 2010-01-19 at 15:33 -0500, Stephan Richter wrote: On Tuesday 19 January 2010, Michael Howitz wrote: class AddressGroup(group.Group): label = 'Address' fields = field.Fields(zope.schema.TextLine( __name__ = 'owner', title='Owner',