Nitpicking about coding standards (was Re: [Zope-dev] zope.sendmail grantma-retryfixes branch review)

2008-03-21 Thread Marius Gedminas
On Thu, Mar 20, 2008 at 10:33:10PM +, Chris Withers wrote: > Marius Gedminas wrote: >>> +"""Process results of an SMTP error >>> + returns True to indicate break needed""" >> The standard docstring convention is to do this: >>"""Process results of an SMTP error. T

Re: [Zope-dev] zope.sendmail grantma-retryfixes branch review

2008-03-20 Thread Chris Withers
Marius Gedminas wrote: +"""Process results of an SMTP error + returns True to indicate break needed""" The standard docstring convention is to do this: """Process results of an SMTP error. Returns True to indicate break needed. """ This sta

[Zope-dev] zope.sendmail grantma-retryfixes branch review

2008-03-19 Thread Marius Gedminas
I'm starting a new thread, because the original one got hijacked by the doctest/unittest flamefest. I appear to have unsubscribed from zope3-checkins a while ago, which is why I'm posting here. Disclaimer: I'm not very good at doing code reviews. I tend to mention every little detail that could'