[Zope-dev] zcml layer argument removed zope.component 4.0?

2012-11-21 Thread johannes raggam
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hey,

Why was the 'layer' ZCML argument removed in zope.component 4.0?
Until now, I didn't recognize that it was long deprecated.

Here ist the CHANGES.txt entry from pypi:
http://pypi.python.org/pypi/zope.component

Removed the long-deprecated layer argument to the
zope.component.zcml.view and zope.component.zcml.resource ZCML directives.


Looking at zope.component.zcml.py in 3.12.1, it says:

The 'layer' argument of the 'view' directive has been deprecated.  Use
the 'type' argument instead. If you have an existing 'type' argument
IBrowserRequest, replace it with the 'layer' argument (the layer
subclasses IBrowserRequest). which subclasses BrowserRequest.


The statement, that we should use the 'type' argument instead should
go into zope.component - otherwise, this helpful info is lost, since
it's removed in 4.0.

Looking at zope.component.zcml, the 'type' argument seems to define an
Interface type. So, can it be used just like the 'layer' argument?

Plone and lots of it's addons make heavy use of the 'layer' argument
in view and resource definitions.

Best,
Johannes Raggam

- -- 
programmatic  web development
di(fh) johannes raggam / thet
python plone zope development
mail: off...@programmatic.pro
web:  http://programmatic.pro
  http://bluedynamics.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlCssQ0ACgkQW4mNMQxDgAcgIQCfcI1XDEZe4TuE4CouNXHZ+6of
7vAAnRK7RKxkoctsslym82PEMttet+LK
=6pX8
-END PGP SIGNATURE-
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Small fix in Products.ZCTextIndex, how to go further?

2012-11-21 Thread Gauthier Bastien

  
  
Hi,
  
  does the current version of
  Products.ZCTextIndex.ZCTextIndex.ZCTextIndex.index_object method
  seems ok about keeping optimization?
  
  If so, what is the process to release a new version because we
  really need this in our projects and in Plone...  And as it fixes
  a bug, I think everybody using it needs it ;-)
  
  How to process?
  
  Thank you very much and have a nice end of day,
  
  

  

  

  
  
Gauthier Bastien
Support IMIO - CommunesPlone
rue de la Vieille Sambre 34
5190 Mornimont
Tél: +32(0)71 780979
  


  
Disclaimer


Les informations contenues dans ce courrier électronique
(annexes incluses) sont confidentielles et réservées à
l'usage exclusif des destinataires repris ci-dessus. Si
vous n'êtes pas le destinataire, soyez informé par la
présente que vous ne pouvez ni divulguer, ni reproduire,
ni faire usage de ces informations pour vous-même ou
toute tierce personne. Si vous avez reçu ce courrier
électronique par erreur, vous êtes prié d'en avertir
immédiatement l'expéditeur et d'effacer le message
e-mail de votre ordinateur.


De informatie in deze e-mail, bijlagen inbegrepen, is
vertrouwelijk en is als dus danig voorbehouden voor
exclusief gebruik door de hierboven vermelde
bestemmeling(en). Indien u niet de bestemmeling bent,
willen wij u erop wijzen dat u deze informatie niet mag
aanwenden voor eigen gebruik noch verspreiden aan
derden. Indien u deze e-mail per ongeluk hebt ontvangen,
gelieve de afzender onmiddellijk te verwittigen en deze
e-mail van uw computer te verwijderen.


The information contained in this e-mail and the annexed
documents is confidential and exclusively available to
the here above mentioned addressee(s).Should you not be
the addressee, please be informed that you may neither
disclose nor reproduce this e-mail, nor may the
information contained in this e-mail and its eventually
annexed documents be used by yourself or by a third
party. If you erroneously received this e-mail, could
you kindly and immediately inform the addresser and
delete the message on your computer.
  

  

  
  Le 14/11/12 16:26, Hanno Schlichting a écrit :

Hi.
  
  The change looks ok. But I think you broke an optimization. IIRC
  the code compares the old and new values for the index, and skips
  the indexing step if they are the same. The typical
  item.reindexObject() call sents data for all indexes, even if just
  one or two them have changed. The optimization made sure to skip
  any extra work, if there wasn't really any change for the text
  index. Without that check, you end up updating and writing a bunch
  of internal data structures in the text index every time. Those
  lead to slower write performance and more conflict errors.
  
  Could you have another look, and see if you can preserve the
  optimization?
  
  Thanks,
  Hanno
  

On Wed, Nov 14, 2012 at 4:16 PM,
  Gauthier Bastien gauth...@imio.be wrote:
  
 Hi everybody,
  
  I made a small change in the current Products.ZCTextIndex
  product, the change can be saw here :
  
  http://svn.zope.org/Products.ZCTextIndex/trunk/src/Products/ZCTextIndex/ZCTextIndex.py?rev=128273sortby=logr2=128273r1=113689
  
  and I added a test here :
  
  http://svn.zope.org/Products.ZCTextIndex/trunk/src/Products/ZCTextIndex/tests/testZCTextIndex.py?rev=128273sortby=logr2=128273r1=113689
  
  This fixes ticket : https://dev.plone.org/ticket/13310 :
  while reindexing, if the new content is empty, the index
  is not reindexed and the last indexed value is kept.
  
  I just wonder if it was the way to go, and if it was and
  if a reviewer can confirm that changes are OK, what to do
  to release a new version because this is a huge bug for
  us...
  
  Thank you and have a nice end of day,
  
  -- 

  
   

Re: [Zope-dev] zope-tests - FAILED: 1, OK: 21

2012-11-21 Thread Patrick Gerken
On Wed, Nov 21, 2012 at 2:00 AM, Zope tests summarizer nore...@zope.orgwrote:

 This is the summary for test reports received on the
 zope-tests list between 2012-11-19 00:00:00 UTC and 2012-11-20 00:00:00
 UTC:

 See the footnotes for test reports of unsuccessful builds.

 An up-to date view of the builders is also available in our
 buildbot documentation:
 http://docs.zope.org/zopetoolkit/process/buildbots.html#the-nightly-builds

 Reports received
 

Successful - zopetoolkit_trunk - Build # 82
Successful - zopetoolkit_trunk_app - Build # 66
Zope-2.10 Python-2.4.6 : Linux
Zope-2.11 Python-2.4.6 : Linux
Zope-2.12 Python-2.6.8 : Linux
Zope-2.13 Python-2.6.8 : Linux
Zope-2.13 Python-2.7.3 : Linux
Zope-trunk Python-2.6.8 : Linux
Zope-trunk Python-2.7.3 : Linux
winbot / ZODB_dev py_265_win32
winbot / ZODB_dev py_265_win64
winbot / ZODB_dev py_270_win32
winbot / ZODB_dev py_270_win64
 [1]winbot / zc.lockfile_py_265_32
winbot / ztk_10 py_254_win32
winbot / ztk_10 py_265_win32
winbot / ztk_10 py_265_win64
winbot / ztk_11 py_254_win32
winbot / ztk_11 py_265_win32
winbot / ztk_11 py_265_win64
winbot / ztk_11 py_270_win32
winbot / ztk_11 py_270_win64

 Non-OK results
 --

 [1]FAILED  winbot / zc.lockfile_py_265_32

 https://mail.zope.org/pipermail/zope-tests/2012-November/069449.html


Some problem with mandatory file locking on windows. Could be a transient
error. Else somebody might need to get into action on winbot.
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 1, OK: 21

2012-11-21 Thread Jim Fulton
On Wed, Nov 21, 2012 at 8:56 AM, Patrick Gerken do3cc...@googlemail.com wrote:



 On Wed, Nov 21, 2012 at 2:00 AM, Zope tests summarizer nore...@zope.org
 wrote:

 This is the summary for test reports received on the
 zope-tests list between 2012-11-19 00:00:00 UTC and 2012-11-20 00:00:00
 UTC:

 See the footnotes for test reports of unsuccessful builds.

 An up-to date view of the builders is also available in our
 buildbot documentation:
 http://docs.zope.org/zopetoolkit/process/buildbots.html#the-nightly-builds

 Reports received
 

Successful - zopetoolkit_trunk - Build # 82
Successful - zopetoolkit_trunk_app - Build # 66
Zope-2.10 Python-2.4.6 : Linux
Zope-2.11 Python-2.4.6 : Linux
Zope-2.12 Python-2.6.8 : Linux
Zope-2.13 Python-2.6.8 : Linux
Zope-2.13 Python-2.7.3 : Linux
Zope-trunk Python-2.6.8 : Linux
Zope-trunk Python-2.7.3 : Linux
winbot / ZODB_dev py_265_win32
winbot / ZODB_dev py_265_win64
winbot / ZODB_dev py_270_win32
winbot / ZODB_dev py_270_win64
 [1]winbot / zc.lockfile_py_265_32
winbot / ztk_10 py_254_win32
winbot / ztk_10 py_265_win32
winbot / ztk_10 py_265_win64
winbot / ztk_11 py_254_win32
winbot / ztk_11 py_265_win32
winbot / ztk_11 py_265_win64
winbot / ztk_11 py_270_win32
winbot / ztk_11 py_270_win64

 Non-OK results
 --

 [1]FAILED  winbot / zc.lockfile_py_265_32

 https://mail.zope.org/pipermail/zope-tests/2012-November/069449.html


 Some problem with mandatory file locking on windows. Could be a transient
 error. Else somebody might need to get into action on winbot.

This is my fault.  I updated zc.lockfile to fix a bug and didn't check
it on windows.

I'll look at this.

Jim

-- 
Jim Fulton
http://www.linkedin.com/in/jimfulton
Jerky is better than bacon! http://zo.pe/Kqm
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] zope-tests - FAILED: 1, OK: 21

2012-11-21 Thread Zope tests summarizer
This is the summary for test reports received on the 
zope-tests list between 2012-11-20 00:00:00 UTC and 2012-11-21 00:00:00 UTC:

See the footnotes for test reports of unsuccessful builds.

An up-to date view of the builders is also available in our 
buildbot documentation: 
http://docs.zope.org/zopetoolkit/process/buildbots.html#the-nightly-builds

Reports received


   Successful - zopetoolkit_trunk - Build # 83
   Successful - zopetoolkit_trunk_app - Build # 67
   Zope-2.10 Python-2.4.6 : Linux
   Zope-2.11 Python-2.4.6 : Linux
   Zope-2.12 Python-2.6.8 : Linux
   Zope-2.13 Python-2.6.8 : Linux
   Zope-2.13 Python-2.7.3 : Linux
   Zope-trunk Python-2.6.8 : Linux
   Zope-trunk Python-2.7.3 : Linux
   winbot / ZODB_dev py_265_win32
   winbot / ZODB_dev py_265_win64
   winbot / ZODB_dev py_270_win32
   winbot / ZODB_dev py_270_win64
[1]winbot / zc.lockfile_py_265_32
   winbot / ztk_10 py_254_win32
   winbot / ztk_10 py_265_win32
   winbot / ztk_10 py_265_win64
   winbot / ztk_11 py_254_win32
   winbot / ztk_11 py_265_win32
   winbot / ztk_11 py_265_win64
   winbot / ztk_11 py_270_win32
   winbot / ztk_11 py_270_win64

Non-OK results
--

[1]FAILED  winbot / zc.lockfile_py_265_32
   https://mail.zope.org/pipermail/zope-tests/2012-November/069450.html


___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )