Re: [Zope-dev] Re: [Zope-Checkins] CVS: Zope/lib/python/TAL -TALInterpreter.py:1.69.6.10
But why? Why escape double quotes when it's not a reserved character? I really don't understand the need, and the example in the collector doesn't convince me. What is the problem? Escaping quotes is needed in double quotes-delimited attributes but not elsewhere. Florent On Mon, 2002-12-23 at 01:49, Andy McKay wrote: Collector number 735: http://collector.zope.org/Zope/735 This was prompted by some bugs people found with Plone. For a two character fix that to me looked like a simple oversight I didn't bother with a unit test. -- Andy McKay - Original Message - From: Florent Guillaume [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Sent: Sunday, December 22, 2002 11:01 AM Subject: [Zope-dev] Re: [Zope-Checkins] CVS: Zope/lib/python/TAL - TALInterpreter.py:1.69.6.10 What prompted this? What does it fix? I don't see that quotes need escaping here. Also, there should be a unit test for it. (And if it's a fix it should be in HEAD too.) Florent In article [EMAIL PROTECTED] you write: Modified Files: Tag: Zope-2_6-branch TALInterpreter.py Log Message: Escape quotes correctly === Zope/lib/python/TAL/TALInterpreter.py 1.69.6.9 = 1.69.6.10 === --- Zope/lib/python/TAL/TALInterpreter.py:1.69.6.9 Wed Oct 9 10:37:38 2002 +++ Zope/lib/python/TAL/TALInterpreter.py Tue Dec 17 19:33:43 2002 @@ -486,7 +486,7 @@ if text is self.Default: self.interpret(stuff[1]) return -s = escape(text) +s = escape(text, 1) self._stream_write(s) i = s.rfind('\n') if i 0: -- Florent Guillaume, Nuxeo (Paris, France) +33 1 40 33 79 87 http://nuxeo.com mailto:[EMAIL PROTECTED] ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope ) -- Florent Guillaume, Nuxeo (Paris, France) +33 1 40 33 79 87 http://nuxeo.com mailto:[EMAIL PROTECTED] ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope-Checkins] CVS: Zope/lib/python/TAL - TALInterpreter.py:1.69.6.10
Andy McKay wrote: Collector number 735: http://collector.zope.org/Zope/735 This was prompted by some bugs people found with Plone. For a two character fix that to me looked like a simple oversight I didn't bother with a unit test. I'm not going to comment on whether or not page templates should work this way. There good reasons to write a unit test in just this kind of situation: It is only a two character fix. So, someone else might come along later, and think that those two characters shouldn't be there -- just as you think those two characters should be there. They could remove those characters, and no tests would fail. Also, in a refactoring, this behaviour couild be easily lost if there is no unit test to demonstrate correct behaviour. -- Steve Alexander ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope-Checkins] CVS: Zope/lib/python/TAL - TALInterpreter.py:1.69.6.10
Andy McKay wrote: Collector number 735: http://collector.zope.org/Zope/735 This was prompted by some bugs people found with Plone. For a two character fix that to me looked like a simple oversight I didn't bother with a unit test. *bzzzt* bad. Everything should be unittested, please correct ;-) Chris ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
[Zope-dev] FYI: added Web Services Zope 3 sub-project
(Copying zope-dev because I'm not sure all of the people who started on this discussion are on zope3-dev yet. Lets use zope3-dev moving forward) Hi all - There has been a bit of discussion recently regarding plans for web services in Zope 3, with a number of people expressing interest in moving this forward (and possibly scheduling some WS sprints to kick-start the process). For those who've been paying attention to those threads, I've set up a Zope 3 sub-project at: http://dev.zope.org/Wikis/DevSite/Projects/ComponentArchitecture/WebServices ...with a start at some organization and artifacts (largely cribbed from the old Z2 WS project). Please take a look and feel free to jump in an refine, comment or refactor. One of the first things we need to do is find someone (or a group of someones) to spearhead the effort and own the project area. Any volunteers? :^) Brian Lloyd[EMAIL PROTECTED] V.P. Engineering 540.361.1716 Zope Corporation http://www.zope.com ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope-Checkins] CVS: Zope/lib/python/TAL-TALInterpreter.py:1.69.6.10
Thanks a lot. However it doesn't test the case you describe below, does it? Its just tests that a is always escaped. (And if it's a fix it should be in HEAD too.) Why? Well, because otherwise 2.7 won't have the fix :-) Really, so all the changes and bug fixes done for 2.6.1 have to be put in HEAD too? Thats a pain. -- Andy McKay ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )