Re: [Zope-dev] SVN: Zope/branches/2.12/src/Products/Five/browser/absoluteurl.py Fix _getContextName; does anyone test this stuff?

2010-02-26 Thread Martijn Pieters
2010/2/26 Tres Seaver : > Kettle to pot: Did you add a test? I ran out of time; the current tests weren't easily molded to add a case for this. I felt that at least the simple 'return' statement fix should go in. I'll get the test case in this weekend, hopefully. -- Martijn Pieters _

Re: [Zope-dev] SVN: Zope/branches/2.12/src/Products/Five/browser/absoluteurl.py Fix _getContextName; does anyone test this stuff?

2010-02-26 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Martijn Pieters wrote: > Log message for revision 109473: > Fix _getContextName; does anyone test this stuff? > > Changed: > U Zope/branches/2.12/src/Products/Five/browser/absoluteurl.py > > -=- > Modified: Zope/branches/2.12/src/Products/Five/

Re: [Zope-dev] redirect burps on unicode URLs

2010-02-26 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Wichert Akkerman wrote: > On 2/25/10 17:08 , Tres Seaver wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Adam GROSZER wrote: >>> Hello, >>> >>> Looks like zope.publisher burps on unicode URL which contain non-ascii >>> chars. This is f

Re: [Zope-dev] z3c.form vs. Invalid exceptions

2010-02-26 Thread Stephan Richter
On Friday 26 February 2010, Martin Aspeli wrote: > > Feel free to fix the bug with a test. You can also release a new z3c.form > > version if you like. I can give you access > > Fixed. > > I also added the behaviour to not render anything for a non-200 request. > > My PyPI username is optilude i

Re: [Zope-dev] z3c.form vs. Invalid exceptions

2010-02-26 Thread Christian Theune
On 02/26/2010 04:23 PM, Martin Aspeli wrote: > Stephan Richter wrote: >> On Friday 26 February 2010, Martin Aspeli wrote: >>> The z3c.form doctests make it look like raising zope.interface.Invalid() >>> would be an acceptable thing for a validator to do. It also makes it >>> look like the argument

Re: [Zope-dev] redirect burps on unicode URLs

2010-02-26 Thread Christian Theune
On 02/26/2010 04:12 PM, Adam GROSZER wrote: > Hello, > > Some background: > This arises when you try to access a url which has non-ascii in it > (but is well encoded), usually a document uploaded by a user. > Then the loginform comes with it's camefrom parameter. > On successful login yo uget redi

Re: [Zope-dev] z3c.form vs. Invalid exceptions

2010-02-26 Thread Martin Aspeli
Stephan Richter wrote: > On Friday 26 February 2010, Martin Aspeli wrote: >> The z3c.form doctests make it look like raising zope.interface.Invalid() >> would be an acceptable thing for a validator to do. It also makes it >> look like the argument passed to the Invalid() constructor is a string >>

Re: [Zope-dev] redirect burps on unicode URLs

2010-02-26 Thread Adam GROSZER
Hello, Some background: This arises when you try to access a url which has non-ascii in it (but is well encoded), usually a document uploaded by a user. Then the loginform comes with it's camefrom parameter. On successful login yo uget redirected to the camefrom url, which gets unencoded to unicod

Re: [Zope-dev] z3c.form vs. Invalid exceptions

2010-02-26 Thread Stephan Richter
On Friday 26 February 2010, Martin Aspeli wrote: > The z3c.form doctests make it look like raising zope.interface.Invalid() > would be an acceptable thing for a validator to do. It also makes it > look like the argument passed to the Invalid() constructor is a string > that would be displayed as

[Zope-dev] z3c.form vs. Invalid exceptions

2010-02-26 Thread Martin Aspeli
Hi, The z3c.form doctests make it look like raising zope.interface.Invalid() would be an acceptable thing for a validator to do. It also makes it look like the argument passed to the Invalid() constructor is a string that would be displayed as an error message. However, when I do this (in a co

[Zope-dev] Zope Tests: 6 OK

2010-02-26 Thread Zope Tests Summarizer
Summary of messages to the zope-tests list. Period Thu Feb 25 12:00:00 2010 UTC to Fri Feb 26 12:00:00 2010 UTC. There were 6 messages: 6 from Zope Tests. Tests passed OK --- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Thu Feb 25 20:36:26 EST 2010 URL: http://

Re: [Zope-dev] redirect burps on unicode URLs

2010-02-26 Thread Wichert Akkerman
On 2/25/10 17:08 , Tres Seaver wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Adam GROSZER wrote: >> Hello, >> >> Looks like zope.publisher burps on unicode URL which contain non-ascii >> chars. This is from a KGS 3.4 application, but looking at the source >> it still seems to have th