Re: [Zope-dev] zope.testbrowser and python2.7
Hello, * Jan-Jaap Driessen jdries...@thehealthagency.com [2010-10-14 19:19]: The httplib.HTTPConnection API changed from python2.6 to python2.7. These changes are reflected in the handleErrors property of zope.testbrowser.browser.Browser - it is no longer possible to pass a boolean into the request headers. Thanks for looking into this. Forward compatibility is a good thing. A fix is available on the trunk of zope.testbrowser [1]. In this implementation, a boolean is provided to the consumers of the testbrowser API and a string is used in the request headers. This implementation is sub-optimal in my opinion. In the branch 'janjaapdriessen-handle-errors' [2] you will find a cleaner implementation, where the switch to handle_errors is controlled by the presence of a zope-do-not-handle-errors header. I agree that the boolean-string translating is a bit ugly, but to be honest, I also don't not dislike the double negative in your alternative solution. ;-) This change is backwards incompatible. Code relying on the 'x-zope-handle-errors' header will break. I have tested this implementation against the ZTK trunk on python2.7 and have found no breakage of this kind. I'm definitely fine with changing that header name if necessary, though. Since that's an implementation detail of zope.testbrowser, it should be nobody else's business, and your tests seem to confirm this -- excellent. Please let me know if either of these solutions is OK with you. If so, grant me pypi rights (my handle is 'janjaapdriessen') so I can release zope.testbrowser and get a step closer to making the ZTK run on python2.7. I don't have a *strong* opinion which serialization of that flag is less ugly. I'm leaning towards the trunk one (no double negatives), but either one is basically fine by me. I've given you pypi rights for zope.testbrowser. Wolfgang ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testbrowser and python2.7
On Thu, Oct 14, 2010 at 07:19:17PM +0200, Jan-Jaap Driessen wrote: The httplib.HTTPConnection API changed from python2.6 to python2.7. These changes are reflected in the handleErrors property of zope.testbrowser.browser.Browser - it is no longer possible to pass a boolean into the request headers. A fix is available on the trunk of zope.testbrowser [1]. In this implementation, a boolean is provided to the consumers of the testbrowser API and a string is used in the request headers. That seems sane. This implementation is sub-optimal in my opinion. Why? In the branch 'janjaapdriessen-handle-errors' [2] you will find a cleaner implementation, where the switch to handle_errors is controlled by the presence of a zope-do-not-handle-errors header. The value of the header is no longer interpreted. This change is backwards incompatible. In what way? This header is an internal zope.testbrowser implementation detail, isn't it? Or do things like z3c.testbrowser also use it? I'm -1 for breaking backwards compatibility. Code relying on the 'x-zope-handle-errors' header will break. I have tested this implementation against the ZTK trunk on python2.7 and have found no breakage of this kind. It's times like this when I want to have a full checkout of everything in svn.zope.org (or, better yet, a search page on the web). Grepping in my shared buildout egg cache, I see that 'x-zope-handle-errors' appears in zope.testbrowser only. It is documented in the README as an API between testbrowser and the server it's testing, so I'm inclined to prefer the first, backwards-compatible solution. Please let me know if either of these solutions is OK with you. If so, grant me pypi rights (my handle is 'janjaapdriessen') so I can release zope.testbrowser and get a step closer to making the ZTK run on python2.7. Someone gave you rights already. Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting and development signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope Toolkit 1.0 release
On 10/13/2010 05:57 PM, Jan-Wijbrand Kolman wrote: On behalf of the Zope Toolkit release team and the Zope community, I'm happy to announce the release of Zope Toolkit version 1.0! Congrats to the ZTK release team! Regards, Martijn ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testbrowser and python2.7
On 15 October 2010 11:49, Marius Gedminas mar...@gedmin.as wrote: On Thu, Oct 14, 2010 at 07:19:17PM +0200, Jan-Jaap Driessen wrote: The httplib.HTTPConnection API changed from python2.6 to python2.7. These changes are reflected in the handleErrors property of zope.testbrowser.browser.Browser - it is no longer possible to pass a boolean into the request headers. A fix is available on the trunk of zope.testbrowser [1]. In this implementation, a boolean is provided to the consumers of the testbrowser API and a string is used in the request headers. That seems sane. This implementation is sub-optimal in my opinion. Why? In my opinion, the booleanness of handling errors in the testbrowser is expressed more elegantly by the presence/absence of a request header than by converting a 'true'/'false' string to a boolean (and reverse). As Wolfgang however pointed out, the double negative in the alternative solution is -1. In the branch 'janjaapdriessen-handle-errors' [2] you will find a cleaner implementation, where the switch to handle_errors is controlled by the presence of a zope-do-not-handle-errors header. The value of the header is no longer interpreted. This change is backwards incompatible. In what way? This header is an internal zope.testbrowser implementation detail, isn't it? Or do things like z3c.testbrowser also use it? As far as I know it is an implementation detail. I'm -1 for breaking backwards compatibility. Code relying on the 'x-zope-handle-errors' header will break. I have tested this implementation against the ZTK trunk on python2.7 and have found no breakage of this kind. It's times like this when I want to have a full checkout of everything in svn.zope.org (or, better yet, a search page on the web). Grepping in my shared buildout egg cache, I see that 'x-zope-handle-errors' appears in zope.testbrowser only. I have also not found the x-zope-handle-errors in my local eggs. It is documented in the README as an API between testbrowser and the server it's testing, so I'm inclined to prefer the first, backwards-compatible solution. Conclusion: with the -1*-1*-1 of Wolfgang and the -1 of Marius, I will choose the first option. Thank you for your feedback, -- Jan-Jaap Driessen ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope Tests: 74 OK, 31 Failed
Summary of messages to the zope-tests list. Period Thu Oct 14 12:00:00 2010 UTC to Fri Oct 15 12:00:00 2010 UTC. There were 105 messages: 6 from Zope Tests, 4 from buildbot at pov.lt, 20 from buildbot at winbot.zope.org, 11 from ccomb at free.fr, 64 from jdriessen at thehealthagency.com. Test failures - Subject: FAILED : Zope Buildbot / zope2.13-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Thu Oct 14 08:43:55 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021551.html Subject: FAILED : Zope Buildbot / zope2.14-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Thu Oct 14 08:47:53 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021553.html Subject: FAILED : Zope Buildbot / zope2.13-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Thu Oct 14 09:10:56 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021560.html Subject: FAILED : Zope Buildbot / zope2.14-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Thu Oct 14 09:14:36 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021563.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Thu Oct 14 09:16:18 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021564.html Subject: FAILED : Zope Buildbot / zope2.13_win-py2.6 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 09:45:30 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021570.html Subject: FAILED : Zope Buildbot / zope2.13_win-py2.7 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 09:46:04 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021571.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Thu Oct 14 09:46:25 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021572.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.5 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 10:08:50 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021575.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.6 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 10:16:09 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021576.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.7 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 10:16:41 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021577.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.5 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 10:43:50 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021578.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Thu Oct 14 10:51:00 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021580.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.6 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 10:51:10 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021581.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.7 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 10:51:42 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021582.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Thu Oct 14 11:03:01 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021585.html Subject: FAILED : Zope Buildbot / zope2.13_win-py2.7 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 12:33:45 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021591.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.6 slave-osx From: jdriessen at thehealthagency.com Date: Thu Oct 14 13:22:00 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021597.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-osx From: jdriessen at thehealthagency.com Date: Thu Oct 14 13:28:05 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021598.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.7 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 13:28:22 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021599.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.7 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 13:43:11 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021600.html Subject: FAILED : Zope Buildbot / zopetoolkit_win-py2.5 slave-win From: jdriessen at thehealthagency.com Date: Thu Oct 14 13:43:46 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/021601.html Subject:
Re: [Zope-dev] zope.testbrowser and python2.7
On 15 October 2010 13:15, Jan-Jaap Driessen jdries...@thehealthagency.com wrote: On 15 October 2010 11:49, Marius Gedminas mar...@gedmin.as wrote: ... snip ... Code relying on the 'x-zope-handle-errors' header will break. I have tested this implementation against the ZTK trunk on python2.7 and have found no breakage of this kind. It's times like this when I want to have a full checkout of everything in svn.zope.org (or, better yet, a search page on the web). Grepping in my shared buildout egg cache, I see that 'x-zope-handle-errors' appears in zope.testbrowser only. I have also not found the x-zope-handle-errors in my local eggs. The code in the testlayer of zope.app.wsgi uses this header. zope.testbrowser 3.10.3 fixes this; 3.10.3 is *more* backwards compatible than 3.10.2. -- Jan-Jaap Driessen ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Developer meeting TODAY at 15:00 UTC
Hi, so, here's this week's summary: We talked a bit about the summary goals. I will (have to) do some nagging to get everyone who signed up to fill in his details and timeframe. If anyone feels nagged already, you can go straight here: http://wiki.zope.org/ztk/ZopeSummit2010Summary Some of us already put in our time frames and some more detailed explanations. Also, we talked about the bug days. This time we seem to have quite low interest, maybe the week is bad or so... However, we'd like to point out (or remind) that you don't have to schedule your whole day for participating with a bug day: spending an hour or so to fix some bug makes a much larger difference than not being able to join for a whole day. ;) In addition to that, we'd like to encourage everyone to pick some bugs they'd like to work on *before* the bug day. Especially if you pick bugs that need some discussion/explanation it will help you actually achieve something on the bug day if you understand what's going on and what needs to be done - that's going to be much more satisfying. Christian -- Christian Theune · c...@gocept.com gocept gmbh co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Developer meeting next Tuesday at 15:00 UTC
Hi, here's the reminder and agenda for next week's meeting: We'll meet, as always, in #z...@freenode at 15:00 UTC. Topics will be: - Follow-up on summit goals - Planning the next bug day - The bicycle toolkit I hope you enjoy your weekend and see you next week, Christian ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
