Re: [Zope-dev] Fwd: [Checkins] SVN: zope.component/branches/adamg-fix-getSiteManager/ - Fix _api.getSiteManager in the way that it returns now
On Wednesday, October 27, 2010, Adam GROSZER wrote: > This change is needed because z3c.baseregistry does not work > otherwise. It registers everything in the global registry. > This is a blocker for us to move to ZTK 1.0. > > Raise your hands until 28th October midnight UTC. > If noone objects until then, I'll merge to trunk and make a new > release. I am going to need z3c.baseregistry in the next few days as well and we are on Bluebream 1.0b5, so I am all for getting this in ASAP. :-) Regards, Stephan -- Entrepreneur and Software Geek Google me. "Zope Stephan Richter" ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Fwd: [Checkins] SVN: zope.component/branches/adamg-fix-getSiteManager/ - Fix _api.getSiteManager in the way that it returns now
Hello, Anyone against this change? This change is needed because z3c.baseregistry does not work otherwise. It registers everything in the global registry. This is a blocker for us to move to ZTK 1.0. Raise your hands until 28th October midnight UTC. If noone objects until then, I'll merge to trunk and make a new release. This is a forwarded message From: Adam Groszer To: check...@zope.org Date: Wednesday, October 27, 2010, 2:25:11 PM Subject: [Checkins] SVN: zope.component/branches/adamg-fix-getSiteManager/ - Fix _api.getSiteManager in the way that it returns now ===8<==Original message text=== Log message for revision 117961: - Fix _api.getSiteManager in the way that it returns now globalregistry.getGlobalSiteManager() if context is None. What's anyway expected according to the docs. Changed: U zope.component/branches/adamg-fix-getSiteManager/CHANGES.txt U zope.component/branches/adamg-fix-getSiteManager/src/zope/component/_api.py -=- Modified: zope.component/branches/adamg-fix-getSiteManager/CHANGES.txt === --- zope.component/branches/adamg-fix-getSiteManager/CHANGES.txt 2010-10-27 12:11:58 UTC (rev 117960) +++ zope.component/branches/adamg-fix-getSiteManager/CHANGES.txt 2010-10-27 12:25:10 UTC (rev 117961) @@ -4,7 +4,12 @@ 3.10.1 (unreleased) === -- Nothing changed yet. +- Fix _api.getSiteManager in the way that it returns now + globalregistry.getGlobalSiteManager() if context is None. What's anyway + expected according to the docs. + Before it returned a cached local variable (which was init'ed with + globalregistry.base). This made z3c.baseregisty burp, because z3c.baseregisty + modifies globalregistry.globalSiteManager. Insane. 3.10.0 (2010-09-25) Modified: zope.component/branches/adamg-fix-getSiteManager/src/zope/component/_api.py === --- zope.component/branches/adamg-fix-getSiteManager/src/zope/component/_api.py 2010-10-27 12:11:58 UTC (rev 117960) +++ zope.component/branches/adamg-fix-getSiteManager/src/zope/component/_api.py 2010-10-27 12:25:10 UTC (rev 117961) @@ -39,14 +39,16 @@ # getSiteManager() returns a component registry. Although the term # "site manager" is deprecated in favor of "component registry", # the old term is kept around to maintain a stable API. -base = None @hookable def getSiteManager(context=None): -global base if context is None: -if base is None: -from zope.component.globalregistry import base -return base +# avoid cyclic import +# adhere to the doc and return the globalSiteManager, +# not some wannabe variable +# do not cache the value either, because at least z3c.baseregistry +# modifies it +from zope.component.globalregistry import getGlobalSiteManager +return getGlobalSiteManager() else: # Use the global site manager to adapt context to `IComponentLookup` # to avoid the recursion implied by using a local `getAdapter()` call. ___ checkins mailing list check...@zope.org https://mail.zope.org/mailman/listinfo/checkins ===8<===End of original message text=== -- Best regards, Adam GROSZERmailto:agros...@gmail.com ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope Tests: 80 OK, 13 Failed
Summary of messages to the zope-tests list. Period Tue Oct 26 12:00:00 2010 UTC to Wed Oct 27 12:00:00 2010 UTC. There were 93 messages: 6 from Zope Tests, 4 from buildbot at pov.lt, 19 from buildbot at winbot.zope.org, 11 from ccomb at free.fr, 53 from jdriessen at thehealthagency.com. Test failures - Subject: FAILED : Zope Buildbot / zope2.13-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:22:55 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022341.html Subject: FAILED : Zope Buildbot / zope2.14-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:26:34 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022344.html Subject: FAILED : Zope Buildbot / zope2.13-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:29:27 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022346.html Subject: FAILED : Zope Buildbot / zope2.14-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:32:46 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022348.html Subject: FAILED : Zope Buildbot / zope2.13-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 14:42:34 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022352.html Subject: FAILED : Zope Buildbot / zope2.14-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 14:46:01 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022354.html Subject: FAILED : Zope Buildbot / zope2.13-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 15:11:25 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022362.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 15:14:31 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022364.html Subject: FAILED : Zope Buildbot / zope2.14-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 15:14:51 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022365.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 15:46:45 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022378.html Subject: FAILED : winbot / ZODB_dev py_254_win32 From: buildbot at winbot.zope.org Date: Tue Oct 26 19:21:31 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022397.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Wed Oct 27 04:49:22 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022426.html Subject: FAILED : Zope Buildbot / zopetoolkit-py2.7 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Wed Oct 27 04:49:43 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022427.html Tests passed OK --- Subject: OK : Zope Buildbot / zope2.12-py2.6 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:19:13 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022339.html Subject: OK : Zope Buildbot / zope2.13-py2.6 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:21:07 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022340.html Subject: OK : Zope Buildbot / zope2.14-py2.6 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:24:42 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022342.html Subject: OK : Zope Buildbot / zope2.12-py2.6 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:26:02 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022343.html Subject: OK : Zope Buildbot / zope2.13-py2.6 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:27:45 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022345.html Subject: OK : Zope Buildbot / zope2.14-py2.6 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:31:08 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022347.html Subject: OK : Zope Buildbot / zopetoolkit-1.0-py2.4 slave-ubuntu32 From: jdriessen at thehealthagency.com Date: Tue Oct 26 11:33:03 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022349.html Subject: OK : Zope Buildbot / zope2.12-py2.6 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 14:39:06 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022350.html Subject: OK : Zope Buildbot / zope2.13-py2.6 slave-ubuntu64 From: jdriessen at thehealthagency.com Date: Tue Oct 26 14:40:53 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-October/022351.html Subject: OK : Zope Buildbot / zope2.14-
