RE: [Zope-dev] Greedy except clauses

2001-02-12 Thread Barry A. Warsaw
> "TJ" == Tom Jenkins <[EMAIL PROTECTED]> writes: TJ> I agree. I think this would be a good project for new zope TJ> developers to get into the zope code. Would we need an TJ> ZopeException class hierarchy? IME, it's been a good idea to have a root exception class per subsyste

RE: [Zope-dev] Greedy except clauses

2001-02-12 Thread Tom Jenkins
> -Original Message- > From: Jeremy Hylton [mailto:[EMAIL PROTECTED]] > Sent: Saturday, February 10, 2001 1:49 AM > To: Chris Withers > Cc: Anthony Baxter; Chris McDonough; [EMAIL PROTECTED]; > [EMAIL PROTECTED] > Subject: Re: [Zope-dev] Greedy except clauses >

Re: [Zope-dev] Greedy except clauses

2001-02-11 Thread Jeremy Hylton
> "CW" == Chris Withers <[EMAIL PROTECTED]> writes: >> I am probably a bit idiosyncratic, but I prefer to avoid bare >> excepts at all costs. I often use "except Exception:", otherwise >> I add a CW> Will that catch string exceptions? eg: raise 'Something bad CW> happened' No.

Re: [Zope-dev] Greedy except clauses

2001-02-11 Thread richard
Anthony Baxter wrote: > > Ok, my last for tonight - I put the output of my horrible script at > > http://www.zope.org/Members/anthony/BarewordExcepts > > I'll work over it a bit probably early next week - an obviousish next > step is to make it note when the body of the except: contains a 'rais

Re: [Zope-dev] Greedy except clauses

2001-02-11 Thread Chris Withers
Jeremy Hylton wrote: > > I am probably a bit idiosyncratic, but I prefer to avoid bare excepts > at all costs. I often use "except Exception:", otherwise I add a Will that catch string exceptions? eg: raise 'Something bad happened' If not, then it's not much use in Zope, which is unfortunatel

Re: [Zope-dev] Greedy except clauses

2001-02-09 Thread Anthony Baxter
I took the list I generated, and started looking at a number of them. There seems to be a number of different types of case: There's the "just too slack to specify the exception" case -- generally easy, if tedious, to fix. There's the "we're rendering DTML, it could raise an exception of some so

Re: [Zope-dev] Greedy except clauses

2001-02-09 Thread Jeremy Hylton
> "AB" == Anthony Baxter <[EMAIL PROTECTED]> writes: AB> Now, it's obvious that not all of these are bad - some are AB> probably fine - but there's also many that are _not_ good. The AB> one in MailHost.py does eat exceptions. I'm sure there are AB> others. I am probably a bit idiosy

Re: [Zope-dev] Greedy except clauses

2001-02-09 Thread Chris McDonough
Whoo hoo! Thanks very much Anthony. - Original Message - From: "Anthony Baxter" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Friday, February 09, 2001 1:31 PM Subject: Re: [Zope-dev] Greedy except clauses > Ok, my last for tonight - I put the output

Re: [Zope-dev] Greedy except clauses

2001-02-08 Thread Anthony Baxter
Ok, my last for tonight - I put the output of my horrible script at http://www.zope.org/Members/anthony/BarewordExcepts I'll work over it a bit probably early next week - an obviousish next step is to make it note when the body of the except: contains a 'raise' statement. Anthony

Re: [Zope-dev] Greedy except clauses

2001-02-08 Thread Anthony Baxter
ooo. Richard didn't do it right - there's actually over _600_ bareword except: clauses in the current zope-2_3-branch A quick breakdown of some of the biggies: 71 in OFS/ 61 in ZODB/ 56 in ZServer/ 53 in ZGadflyDA 50 or so in what seems to be test scripts or modules (probably ok) 42 in ZPublishe

Re: [Zope-dev] Greedy except clauses

2001-02-08 Thread Anthony Baxter
> > Is it the sort of thing where it's just work putting a list of all of > > them (line numbers, &c) up on a web page, maybe crosslinked into cvsweb? > > Then people can go and pick them off, one at a time. ok dokey - so, is DC still running a source view web system? If so, you could easily eno

Re: [Zope-dev] Greedy except clauses

2001-02-08 Thread Chris McDonough
Yes! > Is it the sort of thing where it's just work putting a list of all of > them (line numbers, &c) up on a web page, maybe crosslinked into cvsweb? > Then people can go and pick them off, one at a time. ___ Zope-Dev maillist - [EMAIL PROTECTED

Re: [Zope-dev] Greedy except clauses

2001-02-08 Thread Anthony Baxter
>>> [EMAIL PROTECTED] wrote > I've run into several greedy except: clauses now, and have submitted > patches to make them a little less greedy. Out of curiosity, I searched the > Zope source for "unfiltered" except: clauses... > % grep -rl "except:$" . |wc -l > 102 > ... erk Erk and a lot. This

[Zope-dev] Greedy except clauses

2001-02-08 Thread richard
I've run into several greedy except: clauses now, and have submitted patches to make them a little less greedy. Out of curiosity, I searched the Zope source for "unfiltered" except: clauses... % grep -rl "except:$" . |wc -l 102 ... erk Just picking some of the results of that search at random,