Re: [Zope-dev] SVN: zope.publisher/trunk/ Moved dependency on zope.testing from install_requires to tests_require.

2009-08-25 Thread Martijn Faassen
Jim Fulton wrote:
 On Tue, Aug 11, 2009 at 8:02 AM, Martijn Faassenfaas...@startifact.com 
 wrote:
[snip]
 Ah, that's cool. I take it it's not yet possible to do without the test
 extra entirely and let buildout rely on the test_require section? That
 way we could do without duplication.
 
 That's what Tres' setuptools plugin allows. It seems to me to be less
 work to just repeat the information. Even then, you don't really have
 to repeat it.
 You can define the test requirements as a module-level variable and
 then refer to the variable in both tests_require and the extras
 definition.

Sure, but someone needs to document it, otherwise this practice will 
never be adopted. Any progress on that?

Regards,

Martijn


___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] SVN: zope.publisher/trunk/ Moved dependency on zope.testing from install_requires to tests_require.

2009-08-11 Thread Martijn Faassen
Hey,

Jim Fulton wrote:
[snip]
 Id like us to say something along the lines of:
 
 If your tests have additional dependencies, define test extra with
 these dependencies.  Also define tests_require and test_suite so that
 your package supports the test command.
 
 (Not verbatim and we should give examples.)
 
 Note I used to object to tests_require because the information wasn't
 available after installation.  I still do, but I've started using it
 anyway.  Tres wrote a plugin to fix this (thanks Tres), but I think
 it's easier just to define tests_require (and test suite) along with
 tests_require.

Ah, that's cool. I take it it's not yet possible to do without the test 
extra entirely and let buildout rely on the test_require section? That 
way we could do without duplication.

Regards,

Martijn



___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] SVN: zope.publisher/trunk/ Moved dependency on zope.testing from install_requires to tests_require.

2009-08-11 Thread Jim Fulton
On Tue, Aug 11, 2009 at 8:02 AM, Martijn Faassenfaas...@startifact.com wrote:
 Hey,

 Jim Fulton wrote:
 [snip]
 Id like us to say something along the lines of:

 If your tests have additional dependencies, define test extra with
 these dependencies.  Also define tests_require and test_suite so that
 your package supports the test command.

 (Not verbatim and we should give examples.)

 Note I used to object to tests_require because the information wasn't
 available after installation.  I still do, but I've started using it
 anyway.  Tres wrote a plugin to fix this (thanks Tres), but I think
 it's easier just to define tests_require (and test suite) along with
 tests_require.

 Ah, that's cool. I take it it's not yet possible to do without the test
 extra entirely and let buildout rely on the test_require section? That
 way we could do without duplication.

That's what Tres' setuptools plugin allows. It seems to me to be less
work to just repeat the information. Even then, you don't really have
to repeat it.
You can define the test requirements as a module-level variable and
then refer to the variable in both tests_require and the extras
definition.

Jim

-- 
Jim Fulton
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] SVN: zope.publisher/trunk/ Moved dependency on zope.testing from install_requires to tests_require.

2009-08-08 Thread Martijn Faassen
Hey,

Fabio Tranchitella wrote:
[snip]
 In zope.component we use tests_require, in the very same way, for example.
 Shall I remove it there, too? Is there a policy/document which explains how
 we use extras and tests_require?

Probably not. I think it'd be very good to add something like this to 
the Zope Toolkit documentation in SVN. Do you think you can write 
something? Please send it to the list so people can review it before we 
add it to SVN.

 I'm a bit hesitant to introduce a test extra if it is just for
 zope.testing, though. The complication introduced by the extra doesn't
 seem to outweigh the advantage of loosing that one package to me.
 
 To me it looks weird: tests_extra is there for this specific reason.
 Why shouldn't we use it?

There are reasons which I forget that are discussed on this mailing list 
some time ago, quite extensively at the time...

One of the things we want to do with the Zope Toolkit project is to 
document decisions so that the same stuff doesn't keep coming up. This 
is a good example.

Regards,

Martijn


___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] SVN: zope.publisher/trunk/ Moved dependency on zope.testing from install_requires to tests_require.

2009-08-08 Thread Jim Fulton
On Sat, Aug 8, 2009 at 1:33 PM, Martijn Faassenfaas...@startifact.com wrote:
 Hey,

 Fabio Tranchitella wrote:
 [snip]
 In zope.component we use tests_require, in the very same way, for example.
 Shall I remove it there, too? Is there a policy/document which explains how
 we use extras and tests_require?

 Probably not. I think it'd be very good to add something like this to
 the Zope Toolkit documentation in SVN. Do you think you can write
 something? Please send it to the list so people can review it before we
 add it to SVN.

Id like us to say something along the lines of:

If your tests have additional dependencies, define test extra with
these dependencies.  Also define tests_require and test_suite so that
your package supports the test command.

(Not verbatim and we should give examples.)

Note I used to object to tests_require because the information wasn't
available after installation.  I still do, but I've started using it
anyway.  Tres wrote a plugin to fix this (thanks Tres), but I think
it's easier just to define tests_require (and test suite) along with
tests_require.

Letting people run tests via the setup command is a lot better than
trying to tell them how to use a buildout.

Jim

-- 
Jim Fulton
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )