Re: [Zope-dev] AcceleratedHTTPCache and virtual hosting (collector 1447)

2005-12-05 Thread Chris Withers
Dieter Maurer wrote: We could use monkey patching for this -- used only for testing purposes. Yup, I've had extensive success with this too, for example, to get consistent dates during date-based tests. I'm also -1 on havign functionality in production code that's there purely to support un

Re: [Zope-dev] AcceleratedHTTPCache and virtual hosting (collector 1447)

2005-12-04 Thread Dieter Maurer
Jens Vagelpohl wrote at 2005-12-3 16:08 +: > ... >> Another thought: Maybe before doing anything else, I should make the >> client class used by AcceleratedHTTPCache configurable, so I can more >> easily get a mock in there. Something like: > >I like the secondary route, but I'm not sure the p

Re: [Zope-dev] AcceleratedHTTPCache and virtual hosting (collector 1447)

2005-12-03 Thread Chris McDonough
On Dec 3, 2005, at 11:08 AM, Jens Vagelpohl wrote: On 3 Dec 2005, at 15:57, Paul Winkler wrote: One thought that occurs to me is to replace httplib.HTTPConnection with a mock object of some sort that allows easy verification of its input. So we assume that httplib works, as a proper unit t

Re: [Zope-dev] AcceleratedHTTPCache and virtual hosting (collector 1447)

2005-12-03 Thread Jens Vagelpohl
On 3 Dec 2005, at 15:57, Paul Winkler wrote: One thought that occurs to me is to replace httplib.HTTPConnection with a mock object of some sort that allows easy verification of its input. So we assume that httplib works, as a proper unit test should I think. How to do this? One idea is to monk

[Zope-dev] AcceleratedHTTPCache and virtual hosting (collector 1447)

2005-12-03 Thread Paul Winkler
Hi folks, need some advice here. http://www.zope.org/Collectors/Zope/1447 ("AcceleratedHTTPCacheManager doesn't PURGE correctly for virtual hosts") has been assigned to me like forever, and I've determined to not let another year go by with this one unfixed ;-) I'd like to apply the patch and co