Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-05 Thread Andy McKay
Paul Winkler wrote: yeah, it might be an unpopular change. I dunno. Anything that forces me to use better style is OK with me ;-) Ideally we need to set a zope config option that states what HTML standard is being rendered too, then all parts that render HTML use those conventions. We've found

[Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Paul Winkler
I used to be able to browse to an image's tag method and see its output in my browser. This worked in zope 2.6.1 and apparently stopped working in 2.6.2. Anybody know why? I don't see ANY changes to Image.py between 2.6.1 and 2.6.2. In 2.6.2, 2.6.4, and 2.7.0 I get the missing docstring

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Sidnei da Silva
On Thu, Mar 04, 2004 at 04:38:46PM -0500, Paul Winkler wrote: | It's very inconvenient, I used this technique to embed zope images | in JSP's and all those pages are now broken. | Any clue would be appreciated. Wild guess: does the Image class have a docstring? -- Sidnei da Silva [EMAIL

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Chris McDonough
On Thu, 2004-03-04 at 16:38, Paul Winkler wrote: In 2.6.2, 2.6.4, and 2.7.0 I get the missing docstring error: The object at http://localhost:8080/foo.jpg/tag has an empty or missing docstring. Objects must have a docstring to be published. I have seen this message being raised in many

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Paul Winkler
On Thu, Mar 04, 2004 at 07:12:32PM -0300, Sidnei da Silva wrote: On Thu, Mar 04, 2004 at 04:38:46PM -0500, Paul Winkler wrote: | It's very inconvenient, I used this technique to embed zope images | in JSP's and all those pages are now broken. | Any clue would be appreciated. Wild guess:

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Paul Winkler
On Thu, Mar 04, 2004 at 05:14:37PM -0500, Chris McDonough wrote: On Thu, 2004-03-04 at 16:38, Paul Winkler wrote: In 2.6.2, 2.6.4, and 2.7.0 I get the missing docstring error: The object at http://localhost:8080/foo.jpg/tag has an empty or missing docstring. Objects must have a docstring

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Sidnei da Silva
| That was indeed a wild guess ;-) | Of course it does. Are you using Plone? Maybe it's monkey patching Image.tag. -- Sidnei da Silva [EMAIL PROTECTED] http://awkly.org - dreamcatching :: making your dreams come true http://plone.org/about/team#dreamcatcher 1: No code table for op: ++post

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Paul Winkler
On Thu, Mar 04, 2004 at 06:10:18PM -0500, Paul Winkler wrote: On Thu, Mar 04, 2004 at 05:14:37PM -0500, Chris McDonough wrote: On Thu, 2004-03-04 at 16:38, Paul Winkler wrote: In 2.6.2, 2.6.4, and 2.7.0 I get the missing docstring error: The object at http://localhost:8080/foo.jpg/tag

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Paul Winkler
On Thu, Mar 04, 2004 at 08:43:35PM -0300, Sidnei da Silva wrote: | That was indeed a wild guess ;-) | Of course it does. Are you using Plone? Maybe it's monkey patching Image.tag. You were lurking on #zope weren't you ;-) -- Paul Winkler http://www.slinkp.com Look! Up in the sky! It's

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Marc Lindahl
If you're using Plone, it monkeypatches Image.tag(). Caused me to add an Image.pil_tag() monkeypatch to my monkeypatch ImageTag_CorePatch :) On Thursday, March 4, 2004, at 04:38 PM, Paul Winkler wrote: I used to be able to browse to an image's tag method and see its output in my browser.

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Andy McKay
Marc Lindahl wrote: If you're using Plone, it monkeypatches Image.tag(). Caused me to add an Image.pil_tag() monkeypatch to my monkeypatch ImageTag_CorePatch :) Oh I wish we could get that into Zope so it actually puts out an image tag *by default* without a border. Sigh. -- Andy McKay

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Marc Lindahl
I changed ImageTag_CorePatch to also do the border=0 default patch. On Thursday, March 4, 2004, at 08:26 PM, Andy McKay wrote: Marc Lindahl wrote: If you're using Plone, it monkeypatches Image.tag(). Caused me to add an Image.pil_tag() monkeypatch to my monkeypatch ImageTag_CorePatch :)

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Paul Winkler
On Thu, Mar 04, 2004 at 05:26:59PM -0800, Andy McKay wrote: Marc Lindahl wrote: If you're using Plone, it monkeypatches Image.tag(). Caused me to add an Image.pil_tag() monkeypatch to my monkeypatch ImageTag_CorePatch :) Oh I wish we could get that into Zope so it actually puts out an

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Andy McKay
Paul Winkler wrote: Eh? I'm not sure what you want. No border attribute, or border=0? [snip] If you want to force no border attribute, you can pass it a false value. No border attribute at all. In Zope you have to specify you dont want a border you have to call tal:image replace=python:

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Paul Winkler
On Thu, Mar 04, 2004 at 07:25:02PM -0800, Andy McKay wrote: Right because the border attribute is not standards compliant, and is deprecated. So this way if you don't want to meet standards, great go fo it, but otherwise you'll get the right tag. Oh ok, I didn't know that about it being

Re: [Zope-dev] Image.tag() no longer publishable?

2004-03-04 Thread Marc Lindahl
On Thursday, March 4, 2004, at 10:14 PM, Paul Winkler wrote: From OFS.Image.tag in zope 2.7.0: if not 'border' in [ x.lower() for x in args.keys()]: result = '%s border=0' % result ... that's been in there for about 3 years! If you want to force no border attribute, you can