[Zope-dev] Re: [Zope-Checkins] CVS: Products/PluginIndexes/common - UnIndex.py:1.20.2.7

2005-05-31 Thread Chris Withers 

Tres Seaver wrote:

+if set is None:
+set = IISet(())
+elif type(set) is IntType: # isinstance(set, int) for 2.8


How come isinstance is only to be used for 2.8?

cheers,

Chris

--
Simplistix - Content Management, Zope  Python Consulting
   - http://www.simplistix.co.uk
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce

http://mail.zope.org/mailman/listinfo/zope )

Re: [Zope-dev] Re: [Zope-Checkins] CVS: Products/PluginIndexes/common- UnIndex.py:1.20.2.7

2005-05-31 Thread SER.RI-TIC-Alexis Roda 

Chris Withers wrote:

Tres Seaver wrote:


+if set is None:
+set = IISet(())
+elif type(set) is IntType: # isinstance(set, int) for 
2.8



How come isinstance is only to be used for 2.8?


Hi,
when I wrote the patch and the test case I tried to be consistent with 
the actual code. On 2.7 the check was done with type() while on 2.8 with 
isinstance(), so I added a comment. Probably I should have stated this 
in the collector entry.




Regards
--
   
  (@ @)
oOO(_)OOo--
   Ojo por ojo y el mundo acabara ciego
/\ Alexis Roda - Universitat Rovira i Virgili - Reus, Tarragona (Spain)
---

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce

http://mail.zope.org/mailman/listinfo/zope )