[Zope-dev] Re: Bugfix release?
Brian Lloyd wrote:
FYI I'd like to have a 2.6.1 beta out next week. Jeremy is still
looking at a few ZODB bug reports - as soon as he's done we'll
make the beta.
HelpSys DTML Reference node is broken. Please consider at least a two
line bugfix for 2.6.1.
-if id[:5]=='dtml-':
+if id[:5].lower()=='dtml-':
dtmltopics.append(topic)
-if (id[:5] in ('metal', 'tales') and id[5] in ('.', '-')) or \
+elif (id[:5] in ('metal', 'tales') and id[5] in ('.', '-')) or \
(id[:3]=='tal' and id[3] in ('.', '-')):
zpttopics.append(topic)
else:
topics.append(topic)
I uploaded a bigger patch to http://collector.zope.org/Zope/704, that
also takes care of other nodes.
Please let me know if it's ok to checkin the patch or at least the 2
line fix to branch and/or trunk.
Cheers,
Yuppie
___
Zope-Dev maillist - [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://lists.zope.org/mailman/listinfo/zope-announce
http://lists.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Bugfix release?
Yuppie wrote:
HelpSys DTML Reference node is broken. Please consider at least a two
line bugfix for 2.6.1.
-if id[:5]=='dtml-':
+if id[:5].lower()=='dtml-':
dtmltopics.append(topic)
-if (id[:5] in ('metal', 'tales') and id[5] in ('.', '-')) or \
+elif (id[:5] in ('metal', 'tales') and id[5] in ('.', '-')) or \
(id[:3]=='tal' and id[3] in ('.', '-')):
zpttopics.append(topic)
else:
topics.append(topic)
I have to cut back on my request:
The first point could be intended: Uppercase DTML help is used for DTML
Document and DTML Method help.
So really buggy is only the 'if' instead of 'elif'. This makes DTML
Reference show up twice.
See also http://collector.zope.org/Zope/704 .
Cheers,
Yuppie
___
Zope-Dev maillist - [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://lists.zope.org/mailman/listinfo/zope-announce
http://lists.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Bugfix release?
I'll drop in another (and final) plug for the one-line change needed to undo the harmful http://collector.zope.org/Zope/432 . Andreas, it looked like you were going to fix this for 2.6.0 . Did it slip through the cracks or are you having second thoughts ? Recap: Andreas made ' take precedence over everything including sgml tags, breaking dtml python expressions in zwiki stx pages. I've since found an easy way to work around this for zwiki, but it adds one more behavioural difference code duplication between zwiki's and zope's stx. Better to avoid this. Regards - Simon ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
