Wichert Akkerman wrote:
-if (self._utility_registrations.get((provided, name))
+if (self._utility_registrations.get((provided, name)[:2])
Excellent catch, fixed.
With a test I hope?
cheers,
Chris
--
Simplistix - Content Management, Zope Python Consulting
-
On Fri, 2008-07-25 at 16:58 +0100, Chris Withers wrote:
Wichert Akkerman wrote:
-if (self._utility_registrations.get((provided, name))
+if (self._utility_registrations.get((provided, name)[:2])
Excellent catch, fixed.
With a test I hope?
Uh. Lol?
To me this looks
Christian Theune wrote:
To me this looks like an inefficiency that's gonna be hard to test from
the outside. Or did I miss anything?
That's not the impression I got, which is why a test would be good...
cheers,
Chris
--
Simplistix - Content Management, Zope Python Consulting
-
Hello
This checkin contains the following change to
zope.component/trunk/src/zope/component/registry.py
which looks wrong to me (it's a noop). It looks to me as if the [:2]
should move outside the ) following it. I am surprised that this
doesn't break any tests, as it means that
Jacob Holm wrote:
Hello
This checkin contains the following change to
zope.component/trunk/src/zope/component/registry.py
which looks wrong to me (it's a noop). It looks to me as if the [:2]
should move outside the ) following it. I am surprised that this
doesn't break any tests, as it
