Re: [Zope-dev] Re: zope.sendmail grantma-retryfixes branch review

2008-03-26 Thread Chris Withers
Matthew Grant wrote: FYI - Test coverage in zope.sendmail was originally pretty thin. Hmmm, apply some svn blame, find the culprite and lets arrange some burning at the stake... Seriously, am I right in remembering "Zope 3" and all things related to have been "test first" from day 1? Zope3

Re: [Zope-dev] Re: zope.sendmail grantma-retryfixes branch review

2008-03-25 Thread Matthew Grant
Chris, FYI - Test coverage in zope.sendmail was originally pretty thin. The work I have done is a big improvement. Zope.sendmail is a corner of Zope3 which has not been implemented that well, and this show up in the terms of its quality and sparse unit test coverage. Patience please! Cheers,

Re: [Zope-dev] Re: zope.sendmail grantma-retryfixes branch review

2008-03-25 Thread Chris Withers
Matthew Grant wrote: Just done edits you suggested. Some Unit tests still to be written. If you wrote the tests first *AS YOU SHOULD* this wouldn't be a problem. Tests written after the case have a tendency to omit edge cases... Won't be doing one for that /1000 as tehre are more important t

[Zope-dev] Re: zope.sendmail grantma-retryfixes branch review

2008-03-24 Thread Matthew Grant
Hi! Just done edits you suggested. Some Unit tests still to be written. Won't be doing one for that /1000 as tehre are more important things to check like exception functionality. On Wed, 2008-03-19 at 23:32 +0200, Marius Gedminas wrote: > There are two checkins on the branch. > > = >

[Zope-dev] Re: zope.sendmail grantma-retryfixes branch review

2008-03-23 Thread Matthew Grant
Working on this. tehre are some things I will get back to you about, because what you suggest breaks the unit test code... Cheers, Matthew On Wed, 2008-03-19 at 23:32 +0200, Marius Gedminas wrote: > I'm starting a new thread, because the original one got hijacked by the > doctest/unittest flam