Re: [Zope-dev] Zope 2.8: ZODB fix breaks undoable_transactions

2005-06-29 Thread Tim Peters 
[yuppie]
> http://svn.zope.org/?view=rev&rev=30334 changed the behavior of
> undoInfo() in a way that is not backwards compatible.

That's true, or at least "off-by-one" different than recent ZODB 3.2s.
 Rev 30334 fixed two bugs in the implementation, so that the behavior
matched what the documentation has always said undoInfo() did.  I
don't know when the implementation got out of synch with the docs, but
however people want to resolve this I will not leave the
implementation disagreeing with the docs.

> See http://www.zope.org/Collectors/Zope/1822 for details.

I added details there.
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )

[Zope-dev] Zope 2.8: ZODB fix breaks undoable_transactions

2005-06-29 Thread yuppie 

Hi!


http://svn.zope.org/?view=rev&rev=30334 changed the behavior of 
undoInfo() in a way that is not backwards compatible. See 
http://www.zope.org/Collectors/Zope/1822 for details.



I can see 3 ways to resolve this:

1.) restoring the old behavior of undoInfo() in ZODB

2.) restoring the old behavior of undoable_transactions()

3.) propagating the change to all the code that depends on 
undoable_transactions()



I don't know all the reasons why undoInfo() was changed, so I don't know 
if reverting the change is an option.


If 1.) is no option, I would prefer solution 2.) over 3.)


Any opinions?

Cheers,

Yuppie

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce

http://mail.zope.org/mailman/listinfo/zope )