Re: [Zope-dev] small manuel bugfix

2010-01-06 Thread Benji York
On Fri, Dec 25, 2009 at 9:37 PM, Chris McDonough chr...@plope.com wrote: I added a branch of manuel to the Zope SVN that fixes the codeblock plugin when you use codeblock roles such as: I've released Manuel 1.0.3 which includes this fix. -- Benji York

Re: [Zope-dev] small manuel bugfix

2009-12-26 Thread Benji York
On Fri, Dec 25, 2009 at 10:31 PM, Chris McDonough chr...@plope.com wrote: Yeah.  I'm a fan of unit tests. Yep, me too. To be clear, I do want unit tests in the form of a doctest (like http://svn.zope.org/manuel/trunk/src/manuel/bugs.txt?view=markup). Which may be the best place for this test.

Re: [Zope-dev] small manuel bugfix

2009-12-26 Thread Chris McDonough
Benji York wrote: On Fri, Dec 25, 2009 at 10:31 PM, Chris McDonough chr...@plope.com wrote: Yeah. I'm a fan of unit tests. Yep, me too. To be clear, I do want unit tests in the form of a doctest (like http://svn.zope.org/manuel/trunk/src/manuel/bugs.txt?view=markup). Which may be the

[Zope-dev] small manuel bugfix

2009-12-25 Thread Chris McDonough
I added a branch of manuel to the Zope SVN that fixes the codeblock plugin when you use codeblock roles such as: .. code-block:: python :linenos: Currently it only works without roles, e.g.: .. code-block:: python The branch is at

Re: [Zope-dev] small manuel bugfix

2009-12-25 Thread Chris McDonough
Ugh, that patch is rendered backwards... but you get the idea. Chris McDonough wrote: I added a branch of manuel to the Zope SVN that fixes the codeblock plugin when you use codeblock roles such as: .. code-block:: python :linenos: Currently it only works without roles, e.g.:

Re: [Zope-dev] small manuel bugfix

2009-12-25 Thread Benji York
On Fri, Dec 25, 2009 at 9:37 PM, Chris McDonough chr...@plope.com wrote: I added a branch of manuel to the Zope SVN that fixes the codeblock plugin when you use codeblock roles such as: Looks good. Add tests and I'll merge and release your branch. I'm not sure what form the tests should

Re: [Zope-dev] small manuel bugfix

2009-12-25 Thread Chris McDonough
Benji York wrote: On Fri, Dec 25, 2009 at 9:37 PM, Chris McDonough chr...@plope.com wrote: I added a branch of manuel to the Zope SVN that fixes the codeblock plugin when you use codeblock roles such as: Looks good. Add tests and I'll merge and release your branch. Sorry about the