[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/...

2006-05-31 Thread Florent Guillaume
Tres Seaver wrote: I agree with you that there should be BBB code that provides the old behavior and I agree with Philipp that not using that old behavior is a benefit for the CMF. Sure. I just don't want to *make* people upgrade CMF when upgrading Zope, unless there is a reason which is

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/...

2006-05-31 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Florent Guillaume wrote: Tres Seaver wrote: I agree with you that there should be BBB code that provides the old behavior and I agree with Philipp that not using that old behavior is a benefit for the CMF. Sure. I just don't want to *make*

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/...

2006-05-31 Thread Florent Guillaume
On 31 May 2006, at 19:20, Tres Seaver wrote: I uploaded a similar one, except with deprecation warning, to the collector issue I added: http://www.zope.org/Collectors/Zope/2118 Ah thanks, I missed it. My variation also creates an expression which would raise a KeyError if evaluated,

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testZopePageTemplate.py A recent fix in the zope 3 traversing code now requires the ITraversable

2006-05-30 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Philipp von Weitershausen wrote: Tres Seaver wrote: Basically: * we hardly see a use case for empty path elements. They don't work right now, at least not in the way that you expected them to work. So, we're not really breaking anything if we take

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/...

2006-05-30 Thread yuppie
Hi! Tres Seaver wrote: - CMFDefault/skin/configure.zcml blows up because the syntax of the 'browser:skin' directive has changed in a BBB-incompatible way. The now-failing directive is:: browser:skin name=cmf layers=cmf default / and the traceback is *very* weird::

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/...

2006-05-30 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: Hi! Tres Seaver wrote: - CMFDefault/skin/configure.zcml blows up because the syntax of the 'browser:skin' directive has changed in a BBB-incompatible way. The now-failing directive is:: browser:skin name=cmf

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/...

2006-05-30 Thread yuppie
Hi! Tres Seaver wrote: yuppie wrote: Tres Seaver wrote: - CMFDefault/skin/configure.zcml blows up because the syntax of the 'browser:skin' directive has changed in a BBB-incompatible way. The now-failing directive is:: browser:skin name=cmf layers=cmf default /

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/...

2006-05-30 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: Yes. The 'no traverser' problems were not caused by the missing 'default' layer, so the Five fix doesn't resolve them. They are caused by the fact that Five traversing is now used in more places, so more tests need

Re: [Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testZopePageTemplate.py A recent fix in the zope 3 traversing code now requires the ITraversable

2006-05-30 Thread Dieter Maurer
Philipp von Weitershausen wrote at 2006-5-29 18:42 +0200: ... The CMF (and Plone on top of it) work *fine* as they are today for completely empty expressions. Reverting the BBB-incompatible cahnge, and adding deprecation warnings, is our standard practice here. Yes, for changes that ripped

Re: [Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/...

2006-05-30 Thread Lennart Regebro
On 5/30/06, Tres Seaver [EMAIL PROTECTED] wrote: Lennart, do you have a sense about what it would take to fix that in OFS.Traversable? Nope, and I have no time until Saturday to check it. -- Lennart Regebro, Nuxeo http://www.nuxeo.com/ CPS Content Management

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testZopePageTemplate.py A recent fix in the zope 3 traversing code now requires the ITraversable

2006-05-29 Thread Philipp von Weitershausen
Tres Seaver wrote: Philipp von Weitershausen wrote: Log message for revision 68328: A recent fix in the zope 3 traversing code now requires the ITraversable adapter to be present even when traversing just dicts. No problem, we can set it up quite easily. This basically finishes

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testZopePageTemplate.py A recent fix in the zope 3 traversing code now requires the ITraversable

2006-05-29 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Philipp von Weitershausen wrote: Tres Seaver wrote: Philipp von Weitershausen wrote: Log message for revision 68328: A recent fix in the zope 3 traversing code now requires the ITraversable adapter to be present even when traversing just

Re: [Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/test ZopePageTemplate.py A recent fix in the zope 3 traversing code now requires the ITraversable

2006-05-29 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Jung wrote: --On 28. Mai 2006 22:06:27 -0400 Tres Seaver [EMAIL PROTECTED] wrote: These problems aren't blockers for a 2.10 beta, but they must be resolved before a final release. I agree that these issues should be fixed. But it

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testZopePageTemplate.py A recent fix in the zope 3 traversing code now requires the ITraversable

2006-05-29 Thread Philipp von Weitershausen
Tres Seaver wrote: Basically: * we hardly see a use case for empty path elements. They don't work right now, at least not in the way that you expected them to work. So, we're not really breaking anything if we take away something that didn't work in the first place. The CMF (and Plone on

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testZopePageTemplate.py A recent fix in the zope 3 traversing code now requires the ITraversable

2006-05-28 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Philipp von Weitershausen wrote: Log message for revision 68328: A recent fix in the zope 3 traversing code now requires the ITraversable adapter to be present even when traversing just dicts. No problem, we can set it up quite easily.

Re: [Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/test ZopePageTemplate.py A recent fix in the zope 3 traversing code now requires the ITraversable

2006-05-28 Thread Andreas Jung
--On 28. Mai 2006 22:06:27 -0400 Tres Seaver [EMAIL PROTECTED] wrote: These problems aren't blockers for a 2.10 beta, but they must be resolved before a final release. I agree that these issues should be fixed. But it is now time to get 2.10 beta 1 out of the door as soon as possible. We

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testExpressions.py Fix a test that was testing wrong behaviour: primitive types

2006-05-25 Thread Philipp von Weitershausen
Tres Seaver wrote: If a subexpression returns a callable, you're telling me that you think the top-level expression is supposed to call it? That's nuts! The spec[1] says: When a TALES path expression is evaluated, it attempts to traverse each path, from left to right, until it succeeds or

Re: [Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/Expressions.py Officially deprecate the BBB methods on the iterator and add a note

2006-05-23 Thread Chris Withers
Philipp von Weitershausen wrote: maintained in Zope 3. Plus, the goal is to use the Zope 3 implementation everywhere so there must be some advantages in the Zope 3 implementation over the Zope 2 one... otherwise we wouldn't be doing this... This logic is faulty. The merge is desirable because

Re: [Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/Expressions.py Officially deprecate the BBB methods on the iterator and add a note

2006-05-22 Thread Chris Withers
Tres Seaver wrote: +@deprecate(The 'last' method has been deprecated and will disappear + in Zope 2.12. Use the 'end' property instead.) def last(self, name=None): if self.end: return True I don't think deprecating 'first' and 'last' is

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/Expressions.py Officially deprecate the BBB methods on the iterator and add a note

2006-05-22 Thread Philipp von Weitershausen
Tres Seaver wrote: +@deprecate(The 'first' method has been deprecated and will disappear + in Zope 2.12. Use the 'start' property instead.) def first(self, name=None): if self.start: return True return not self.same_part(name,

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/Expressions.py Officially deprecate the BBB methods on the iterator and add a note

2006-05-22 Thread Philipp von Weitershausen
Philipp von Weitershausen wrote: Tres Seaver wrote: +@deprecate(The 'first' method has been deprecated and will disappear + in Zope 2.12. Use the 'start' property instead.) def first(self, name=None): if self.start: return True

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/Expressions.py Officially deprecate the BBB methods on the iterator and add a note

2006-05-22 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Philipp von Weitershausen wrote: Philipp von Weitershausen wrote: Tres Seaver wrote: +@deprecate(The 'first' method has been deprecated and will disappear + in Zope 2.12. Use the 'start' property instead.) def first(self,

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testExpressions.py Fix a test that was testing wrong behaviour: primitive types

2006-05-22 Thread Philipp von Weitershausen
Tres Seaver wrote: Philipp von Weitershausen wrote: Log message for revision 68244: Fix a test that was testing wrong behaviour: primitive types werent' called if they were the result of a path expression, while all other callables were called. This tests now tests the correct

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/Expressions.py Officially deprecate the BBB methods on the iterator and add a note

2006-05-22 Thread Philipp von Weitershausen
Tres Seaver wrote: Philipp von Weitershausen wrote: Philipp von Weitershausen wrote: Tres Seaver wrote: +@deprecate(The 'first' method has been deprecated and will disappear + in Zope 2.12. Use the 'start' property instead.) def first(self, name=None): if

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testExpressions.py Fix a test that was testing wrong behaviour: primitive types

2006-05-22 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Philipp von Weitershausen wrote: Tres Seaver wrote: Philipp von Weitershausen wrote: Log message for revision 68244: Fix a test that was testing wrong behaviour: primitive types werent' called if they were the result of a path expression,

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/Expressions.py Officially deprecate the BBB methods on the iterator and add a note

2006-05-22 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Philipp von Weitershausen wrote: Tres Seaver wrote: Philipp von Weitershausen wrote: Philipp von Weitershausen wrote: Tres Seaver wrote: +@deprecate(The 'first' method has been deprecated and will disappear + in Zope 2.12.

[Zope-dev] Re: SVN: Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/Expressions.py Officially deprecate the BBB methods on the iterator and add a note

2006-05-21 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Philipp von Weitershausen wrote: Log message for revision 68231: Officially deprecate the BBB methods on the iterator and add a note regarding our plans for the other iterator BBB code Changed: U