RE: [Zope-dev] bug in RESPONSE.appendHeader

[Brian Lloyd]

> Glad to help.
> 
> The error in the documentation string seems to have propagated to other
> locations.  It appears in /lib/python/Products/OFSP/Response.py(line 130)
> and in the Zope Book
> .

Ok - I've fixed the help system .py file and added a comment to 
the book site so that this should get fixed for the next rev.

Thanks!


Brian Lloyd[EMAIL PROTECTED]
V.P. Engineering   540.361.1716   
Zope Corporation   http://www.zope.com




___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )

RE: [Zope-dev] bug in RESPONSE.appendHeader

[Chris Gray]

Glad to help.

The error in the documentation string seems to have propagated to other
locations.  It appears in /lib/python/Products/OFSP/Response.py(line 130)
and in the Zope Book
.

Chris

On Wed, 12 Jun 2002, Brian Lloyd wrote:

> > First off, the on-line documentation description of this method is 'Append
> > a value to a cookie'.
> > 
> > Second, it breaks if you are in fact adding a second value to a header
> > that already exists.
> 
> Thanks - I've checked in the fix for 2.6 and on the 2.5 branch.



___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )

RE: [Zope-dev] bug in RESPONSE.appendHeader

[Brian Lloyd]

> First off, the on-line documentation description of this method is 'Append
> a value to a cookie'.
> 
> Second, it breaks if you are in fact adding a second value to a header
> that already exists.

Thanks - I've checked in the fix for 2.6 and on the 2.5 branch.


Brian Lloyd[EMAIL PROTECTED]
V.P. Engineering   540.361.1716   
Zope Corporation   http://www.zope.com




___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )

[Zope-dev] bug in RESPONSE.appendHeader

[Chris Gray]

First off, the on-line documentation description of this method is 'Append
a value to a cookie'.

Second, it breaks if you are in fact adding a second value to a header
that already exists.

Either:




or:




causes an error because of what looks like a typo.

/lib/python/ZPublisher/HTTPResponse.py(line 391)

reads: h=self.header[name]

but should be: h=self.headers[name]

Chris



___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )