Re: [Zope-dev] is this how we fix test breakage in tests? :-S
Benji York wrote: But, that doesn't really matter much, because test in question has never run, and can never have passed (since the time when zope.testing's doctest was forked from Python). It expects to call functions in the current module (which is zope.testing.doctest) to mutate module globals and see the results in the globals of the module imported by import doctest (which will be the doctest from the standard library). If it's from the globals, surely it just needs to be changed to see the globals in zope.testing.doctest have the results instead. anything worth testing as far as I can tell. Then we should make bin/test run the tests in doctest.py. Do they not currently? :-S Ultimately we'd really like to defork doctest, but that's a non-trivial task. Hmm, but then this would tie us to the python release cycle, which isn't the fastest in the world, especially for new feature releases... cheers, Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] is this how we fix test breakage in tests? :-S
Hi Benji, Was a bit shocked to see your name against the rather disappointing commenting out of a doctest in doctest.py (lines 2214-2218). What gives? So if tests don't pass now we just comment them out? Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] is this how we fix test breakage in tests? :-S
On Mon, Aug 18, 2008 at 3:19 PM, Chris Withers [EMAIL PROTECTED] wrote: Hi Benji, Was a bit shocked to see your name against the rather disappointing commenting out of a doctest in doctest.py (lines 2214-2218). Commenting out that test was an accident of a merge. But, that doesn't really matter much, because test in question has never run, and can never have passed (since the time when zope.testing's doctest was forked from Python). It expects to call functions in the current module (which is zope.testing.doctest) to mutate module globals and see the results in the globals of the module imported by import doctest (which will be the doctest from the standard library). I suggest deleting the test in question. It doesn't really test anything worth testing as far as I can tell. Then we should make bin/test run the tests in doctest.py. Ultimately we'd really like to defork doctest, but that's a non-trivial task. -- Benji York Senior Software Engineer Zope Corporation ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
