Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-09 Thread Michael Howitz
Am 08.12.2008 um 21:05 schrieb Fred Drake:
[...]
 - add configuration support, so this can be set per-user, rather than
 polluting buildout.cfg for everyone.


+1

I reverted the change in zc.sourcefactory.


Yours sincerely,
-- 
Michael Howitz · [EMAIL PROTECTED] · software developer
gocept gmbh  co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1
Zope and Plone consulting and development

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-09 Thread Marius Gedminas
On Mon, Dec 08, 2008 at 10:56:15AM -0500, Benji York wrote:
 On Mon, Dec 8, 2008 at 2:22 AM, Michael Howitz [EMAIL PROTECTED] wrote:
  Log message for revision 93766:
   color by default
 
 This setting apparently causes problems for people who use Emacs, so
 for zope. and zc. packages at least, we don't use --auto-color.

Two comments:

  * on Unix it is possible to detect whether your terminal supports
color: curses.tigetnum('colors') returns 8 in gnome-terminal and -1
in emacs's dumb terminal). zope.testing.testrunner already uses
curses.tigetnum() to detect the terminal width with graceful
fallbacks on Win32 and other crippled platforms that don't have
'curses'.  Making --auto-color do the Right Thing should be easy.
https://bugs.launchpad.net/zope.testing/+bug/306476

  * it's a rather strong personal preference whether people want
colors or not; enabling them by default is not a good decision,
having a global config file in $HOME for that setting would be a
good choice.
https://bugs.launchpad.net/zope.testing/+bug/306478

Marius Gedminas
-- 
Attempts to stick to simple on-or-off options lead to monsters like gcc, which
now has so many flags that programmers are using genetic algorithms to explore
them.
-- http://www.third-bit.com/~gvwilson/xmlprog.html


signature.asc
Description: Digital signature
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-08 Thread Benji York
On Mon, Dec 8, 2008 at 2:22 AM, Michael Howitz [EMAIL PROTECTED] wrote:
 Log message for revision 93766:
  color by default

This setting apparently causes problems for people who use Emacs, so
for zope. and zc. packages at least, we don't use --auto-color.

 Changed:
  U   zc.sourcefactory/trunk/buildout.cfg

 -=-
 Modified: zc.sourcefactory/trunk/buildout.cfg
 ===
 --- zc.sourcefactory/trunk/buildout.cfg 2008-12-08 07:21:10 UTC (rev 93765)
 +++ zc.sourcefactory/trunk/buildout.cfg 2008-12-08 07:22:06 UTC (rev 93766)
 @@ -4,4 +4,5 @@

  [test]
  recipe = zc.recipe.testrunner
 +defaults = [--auto-color]
  eggs = zc.sourcefactory [test]

-- 
Benji York
Senior Software Engineer
Zope Corporation
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-08 Thread Zvezdan Petkovic
On Dec 8, 2008, at 10:56 AM, Benji York wrote:

 On Mon, Dec 8, 2008 at 2:22 AM, Michael Howitz [EMAIL PROTECTED] wrote:
 Log message for revision 93766:
 color by default

 This setting apparently causes problems for people who use Emacs, so
 for zope. and zc. packages at least, we don't use --auto-color.

That argument is really lame.
Should we now go back to VT100 terminals because _some_ Emacs users  
are annoyed that ANSI colors break their shell window display?

They should read about ansi-color-for-comint-mode-on and add-hook.
There are probably other ways to do this.

It is equally annoying when _some_ Emacs users leave lines filled with  
nothing but spaces all over the Zope code base.  Yet, nobody asked for  
a rule that would somehow prevent that.

The Emacs users can easily prevent these spaces by setting
show-trailing-whitespace in python-mode-hook or simply using
delete-trailing-whitespace from time to time.
Setting next-line-add-newlines to nil in the .emacs file is also a  
good idea.

Anyway, why enforce an ancient terminal style on all of us when Emacs  
users could actually set their shell window style?

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-08 Thread Benji York
On Mon, Dec 8, 2008 at 12:37 PM, Zvezdan Petkovic [EMAIL PROTECTED] wrote:
 On Dec 8, 2008, at 10:56 AM, Benji York wrote:

 On Mon, Dec 8, 2008 at 2:22 AM, Michael Howitz [EMAIL PROTECTED] wrote:
 Log message for revision 93766:
 color by default

 This setting apparently causes problems for people who use Emacs, so
 for zope. and zc. packages at least, we don't use --auto-color.

 That argument is really lame.

It may be, but I'm not much persuaded by fix your tools arguments.  If
it causes other people pain and doesn't convey a huge benefit, then
there's no need to impose on others.
-- 
Benji York
Senior Software Engineer
Zope Corporation
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-08 Thread Martijn Pieters
On Mon, Dec 8, 2008 at 18:37, Zvezdan Petkovic [EMAIL PROTECTED] wrote:
 On Mon, Dec 8, 2008 at 2:22 AM, Michael Howitz [EMAIL PROTECTED] wrote:
 Log message for revision 93766:
 color by default

 This setting apparently causes problems for people who use Emacs, so
 for zope. and zc. packages at least, we don't use --auto-color.

 That argument is really lame.
 Should we now go back to VT100 terminals because _some_ Emacs users
 are annoyed that ANSI colors break their shell window display?

Is there no way auto-color can set as be a local default in a
configuration file in your $HOME or something? Then everyone can make
their own choices instead of having them made for them.

-- 
Martijn Pieters
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-08 Thread Fred Drake
On Mon, Dec 8, 2008 at 10:56 AM, Benji York [EMAIL PROTECTED] wrote:
 This setting apparently causes problems for people who use Emacs, so
 for zope. and zc. packages at least, we don't use --auto-color.

I've been using this under Emacs for a while, and haven't experienced
any tool-related problems with colorization.

I *have* generally objected to adding settings like this in
buildout.cfg: some of us (including myself!) think it makes the output
harder to read.

The only right way to deal with this seems to be to either:

- require users wanting color to ask for it from the command line, or

- add configuration support, so this can be set per-user, rather than
polluting buildout.cfg for everyone.


  -Fred

-- 
Fred L. Drake, Jr.fdrake at gmail.com
Chaos is the score upon which reality is written. --Henry Miller
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-08 Thread Benji York
On Mon, Dec 8, 2008 at 3:05 PM, Fred Drake [EMAIL PROTECTED] wrote:
 On Mon, Dec 8, 2008 at 10:56 AM, Benji York [EMAIL PROTECTED] wrote:
 This setting apparently causes problems for people who use Emacs, so
 for zope. and zc. packages at least, we don't use --auto-color.

 I've been using this under Emacs for a while, and haven't experienced
 any tool-related problems with colorization.

 I *have* generally objected to adding settings like this in
 buildout.cfg: some of us (including myself!) think it makes the output
 harder to read.

Good point (I really like colorized output, but typeing -c has become
reflex at this point, so it doesn't bother me).

 The only right way to deal with this seems to be to either:

 - require users wanting color to ask for it from the command line, or

 - add configuration support, so this can be set per-user, rather than
 polluting buildout.cfg for everyone.

+1
-- 
Benji York
Senior Software Engineer
Zope Corporation
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zc.sourcefactory/trunk/buildout.cfg color by default

2008-12-08 Thread Aaron Lehmann
On Mon, Dec 8, 2008 at 3:05 PM, Fred Drake [EMAIL PROTECTED] wrote:
 On Mon, Dec 8, 2008 at 10:56 AM, Benji York [EMAIL PROTECTED] wrote:
 This setting apparently causes problems for people who use Emacs, so
 for zope. and zc. packages at least, we don't use --auto-color.

 I've been using this under Emacs for a while, and haven't experienced
 any tool-related problems with colorization.

 I *have* generally objected to adding settings like this in
 buildout.cfg: some of us (including myself!) think it makes the output
 harder to read.

+1
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )