Re: [Zope-dev] Request for review: z3c.recipe.i18n (branch: baijum-zcml-path)
On Mon, Aug 9, 2010 at 2:04 PM, Michael Howitz wrote: > Am 09.08.2010 um 09:38 schrieb Baiju M: > [...] > > Incidentally, can you use > > zcml = > > without specifying a package? In other words, is this just syntactic > > sugar for something that's already possible, or a way to do something > > that wasn't possible before? > > Thanks for the review! > > I can use "file" option without specifying the package. > > So, I am not going to merge my branch. > > But could you please document this in the package for the next one who wants > this feature? I just added a note like this: Note: To include a ZCML file outside package, you can use, ``include`` directive with ``file`` option. For example: Thanks for reminding! Regards, Baiju M ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Request for review: z3c.recipe.i18n (branch: baijum-zcml-path)
Am 09.08.2010 um 09:38 schrieb Baiju M:[...]Incidentally, can you usezcml = without specifying a package? In other words, is this just syntacticsugar for something that's already possible, or a way to do somethingthat wasn't possible before?Thanks for the review!I can use "file" option without specifying the package.So, I am not going to merge my branch.But could you please document this in the package for the next one who wants this feature?Thanks in advance.Yours sincerely,-- Michael Howitz · m...@gocept.com · software developergocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germanyhttp://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1Zope and Plone consulting and development___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Request for review: z3c.recipe.i18n (branch: baijum-zcml-path)
On Sun, Aug 8, 2010 at 12:56 AM, Marius Gedminas wrote: > On Sat, Aug 07, 2010 at 03:51:20PM +0530, Baiju M wrote: >> Hi Roger, >> I have created a branch to add a small feature addition to >> i18n recipe (z3c.recipe.i18n) here: >> svn://svn.zope.org/repos/main/z3c.recipe.i18n/branches/baijum-zcml-path > > I'm not Roger, but I looked at > http://zope3.pov.lt/trac/log/z3c.recipe.i18n/branches/baijum-zcml-path > anyway. > >> Now the value of `zcml` option could be specified as a path to ZCML file. >> The old behaviour, which was expecting a ZCML string is retained. > > I'm not sure it makes sense to me: if you make a mistake and your ZCML > is not well-formed, it will be treated as a filename? I don't think > > IOError: [Errno 2] No such file or directory: ' package="z3c.recipe.tests" file="extract.zcml" />"' > > is very friendly, and could lead the user on a wild-goose chase assuming > that extract.zcml is somehow missing in the z3c.recipe.tests package > (instead of noticing the stray " and removing it). > > I'd rather see an alternative option name > > zcml-file = /path/name > >> Please let me know, if I can merge this branch to trunk and make a >> new release. Since this is feature addition, I will be giving >> version number as 0.8.0. > > Incidentally, can you use > > zcml = > > without specifying a package? In other words, is this just syntactic > sugar for something that's already possible, or a way to do something > that wasn't possible before? Thanks for the review! I can use "file" option without specifying the package. So, I am not going to merge my branch. Regards, Baiju M ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Request for review: z3c.recipe.i18n (branch: baijum-zcml-path)
On Sat, Aug 07, 2010 at 03:51:20PM +0530, Baiju M wrote: > Hi Roger, > I have created a branch to add a small feature addition to > i18n recipe (z3c.recipe.i18n) here: > svn://svn.zope.org/repos/main/z3c.recipe.i18n/branches/baijum-zcml-path I'm not Roger, but I looked at http://zope3.pov.lt/trac/log/z3c.recipe.i18n/branches/baijum-zcml-path anyway. > Now the value of `zcml` option could be specified as a path to ZCML file. > The old behaviour, which was expecting a ZCML string is retained. I'm not sure it makes sense to me: if you make a mistake and your ZCML is not well-formed, it will be treated as a filename? I don't think IOError: [Errno 2] No such file or directory: '"' is very friendly, and could lead the user on a wild-goose chase assuming that extract.zcml is somehow missing in the z3c.recipe.tests package (instead of noticing the stray " and removing it). I'd rather see an alternative option name zcml-file = /path/name > Please let me know, if I can merge this branch to trunk and make a > new release. Since this is feature addition, I will be giving > version number as 0.8.0. Incidentally, can you use zcml = without specifying a package? In other words, is this just syntactic sugar for something that's already possible, or a way to do something that wasn't possible before? Regards, Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting and development signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
