Re: [Zope-dev] zope-tests - FAILED: 17, OK: 91

2011-06-08 Thread Gediminas Paulauskas
2011/5/25 Gediminas Paulauskas :
> 2011/5/25 Marius Gedminas :
>> On Wed, May 25, 2011 at 09:18:46AM -0400, Tres Seaver wrote:
>>> > [3]    FAILED  Zope Buildbot / zopetoolkit-1.0-py2.5 slave-osx
>>> >        https://mail.zope.org/pipermail/zope-tests/2011-May/041867.html
>>>
>>> The is an FTP test failure, similar to others which have showed up::
>>>
>>> -- $< -
>>> Failure in test testHELP (zope.server.ftp.tests.test_ftpserver.Tests)
>>> Traceback (most recent call last):
>>>   File
>>> "/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
>>> line 260, in run
>>>     testMethod()
>>>   File
>>> "/Users/buildslave/.buildout/eggs/zope.server-3.6.2-py2.5.egg/zope/server/ftp/tests/test_ftpserver.py",
>>> line 278, in testHELP
>>>     self.assertEqual(self.execute('HELP', 1), result)
>>>   File
>>> "/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
>>> line 334, in failUnlessEqual
>>>     (msg or '%r != %r' % (first, second))
>>> AssertionError: '214-The following commands are recognized\r\n' !=
>>> '214-The following commands are recognized\r\nHelp goes here
>>> somewhen.\r\n214 Help done.\r\n'
>>> -- $< -
>>>
>>> I have no idea why this failure is only occasionaly, and only on OS/X.
>>
>> I had a theory and proposed a possible fix a while ago, but had no way
>> of testing it:
>> https://mail.zope.org/pipermail/zope-dev/2010-December/042138.html
>
> I have tested this and committed an equivalent patch:
>
> http://zope3.pov.lt/trac/changeset/121089/zope.server/trunk
>
> This was released recently as zope.server 3.8.3 (that has a new test
> failing on Python < 2.6)

I have released the fix for Python < 2.6 as 3.8.4.

> Have to backport to 3.6 branch for ZTK 1.0... and make new bugfix release

Branch created, minor fixes backported, including this testHELP
failure, and released as 3.6.3:

http://zope3.pov.lt/trac/log/zope.server/branches/3.6

-- 
Gediminas
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 17, OK: 91

2011-05-25 Thread yuppie
Hi!


Marius Gedminas wrote:
> On Wed, May 25, 2011 at 09:18:46AM -0400, Tres Seaver wrote:
>>> [17]   FAILED  winbot / ztk_dev py_270_win64
>>> https://mail.zope.org/pipermail/zope-tests/2011-May/041897.html
>>
>> These are all the same bug::
>>
>> -- $<  -
>> Error in test testNoTargetLanguage
>> (zope.app.i18n.tests.test_translationdomain.TestTranslationDomain)
>> Traceback (most recent call last):
>>File "c:\Python27_64\lib\unittest\case.py", line 318, in run
>>  testMethod()
>>File
>> "c:\buildslave\ztk_dev_py_270_win64\build\src\zope.i18n\src\zope\i18n\tests\test_itranslationdomain.py",
>> line 99, in testNoTargetLanguage
>>  eq(translate('short_greeting', context=context, default=42), 42)
>>File
>> "c:\buildslave\ztk_dev_py_270_win64\build\src\zope.app.i18n\src\zope\app\i18n\translationdomain.py",
>> line 74, in translate
>>  catalog_names = self._catalogs.get(target_language, [])
>> TypeError: Object has default comparison
>> -- $<  -
>>
>> WTF?  We have tests for zope.i18n which pull in code from zope.app.i18n?
>> Not only that, but we have an error being raised from the OOBTree
>> changes Jim landed in October, in a code base which hasn't changed since
>> March.
>
> Buildout egg caches, maybe?  Insufficient version pinning?  newest = false
> in a buildout.cfg?  Who can tell?

I'm afraid I did break this: I added some sources for ZTK dependencies, 
including ZODB/trunk.


This seems to be wrong in two ways:


1.) ZTK trunk obviously doesn't work with ZODB/trunk, it requires 
ZODB/branches/3.10

I already changed this to make the tests pass again: 
http://svn.zope.org/?rev=121808&view=rev (Maybe ZTK trunk *should* work 
with ZODB/trunk and that needs to be fixed instead?)


2.) maybe the ZTK should be tested with released versions of its 
dependencies

My goal was to sync the list of sources with the list of versions and to 
make it possible to extend ztk-sources.cfg in similar way as 
ztk-versions.cfg. This way projects like Zope 2 don't have to maintain 
redundant lists.

So instead of reverting my change I propose to make auto-checkout in 
development.cfg an explicit list of all tested packages instead of using 
a wildcard. Or to decide explicitly that we want to test the ZTK against 
checkouts of its dependencies.

Any opinions?


Cheers,

Yuppie
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 17, OK: 91

2011-05-25 Thread Adam GROSZER
Hello,

On Wed, 25 May 2011 19:04:45 +0300 you wrote:
>
> Buildout egg caches, maybe?

packages on pypi are a rock, aren't they?

Insufficient version pinning?  newest = false
> in a buildout.cfg?  Who can tell?

It's building
svn://svn.zope.org/repos/main/zopetoolkit/trunk

config is at
svn://svn.zope.org/repos/main/zope.wineggbuilder/trunk/master.cfg
def ztk_dev_builder()

>
> Marius Gedminas


-- 
Best regards,
  Adam GROSZER
--
Quote of the day:
Never tell people how to do things. Tell them what to do and they will 
surprise you with their ingenuity.
- General George S. Patton, Jr.
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 17, OK: 91

2011-05-25 Thread Gediminas Paulauskas
2011/5/25 Marius Gedminas :
> On Wed, May 25, 2011 at 09:18:46AM -0400, Tres Seaver wrote:
>> > [3]    FAILED  Zope Buildbot / zopetoolkit-1.0-py2.5 slave-osx
>> >        https://mail.zope.org/pipermail/zope-tests/2011-May/041867.html
>>
>> The is an FTP test failure, similar to others which have showed up::
>>
>> -- $< -
>> Failure in test testHELP (zope.server.ftp.tests.test_ftpserver.Tests)
>> Traceback (most recent call last):
>>   File
>> "/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
>> line 260, in run
>>     testMethod()
>>   File
>> "/Users/buildslave/.buildout/eggs/zope.server-3.6.2-py2.5.egg/zope/server/ftp/tests/test_ftpserver.py",
>> line 278, in testHELP
>>     self.assertEqual(self.execute('HELP', 1), result)
>>   File
>> "/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
>> line 334, in failUnlessEqual
>>     (msg or '%r != %r' % (first, second))
>> AssertionError: '214-The following commands are recognized\r\n' !=
>> '214-The following commands are recognized\r\nHelp goes here
>> somewhen.\r\n214 Help done.\r\n'
>> -- $< -
>>
>> I have no idea why this failure is only occasionaly, and only on OS/X.
>
> I had a theory and proposed a possible fix a while ago, but had no way
> of testing it:
> https://mail.zope.org/pipermail/zope-dev/2010-December/042138.html

I have tested this and committed an equivalent patch:

http://zope3.pov.lt/trac/changeset/121089/zope.server/trunk

This was released recently as zope.server 3.8.3 (that has a new test
failing on Python < 2.6)

Have to backport to 3.6 branch for ZTK 1.0... and make new bugfix release

-- 
Gediminas
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 17, OK: 91

2011-05-25 Thread Marius Gedminas
On Wed, May 25, 2011 at 09:18:46AM -0400, Tres Seaver wrote:
> > [3]FAILED  Zope Buildbot / zopetoolkit-1.0-py2.5 slave-osx
> >https://mail.zope.org/pipermail/zope-tests/2011-May/041867.html
> 
> The is an FTP test failure, similar to others which have showed up::
> 
> -- $< -
> Failure in test testHELP (zope.server.ftp.tests.test_ftpserver.Tests)
> Traceback (most recent call last):
>   File
> "/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
> line 260, in run
> testMethod()
>   File
> "/Users/buildslave/.buildout/eggs/zope.server-3.6.2-py2.5.egg/zope/server/ftp/tests/test_ftpserver.py",
> line 278, in testHELP
> self.assertEqual(self.execute('HELP', 1), result)
>   File
> "/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
> line 334, in failUnlessEqual
> (msg or '%r != %r' % (first, second))
> AssertionError: '214-The following commands are recognized\r\n' !=
> '214-The following commands are recognized\r\nHelp goes here
> somewhen.\r\n214 Help done.\r\n'
> -- $< -
> 
> I have no idea why this failure is only occasionaly, and only on OS/X.

I had a theory and proposed a possible fix a while ago, but had no way
of testing it:
https://mail.zope.org/pipermail/zope-dev/2010-December/042138.html

> > [17]   FAILED  winbot / ztk_dev py_270_win64
> >https://mail.zope.org/pipermail/zope-tests/2011-May/041897.html
> 
> These are all the same bug::
> 
> -- $< -
> Error in test testNoTargetLanguage
> (zope.app.i18n.tests.test_translationdomain.TestTranslationDomain)
> Traceback (most recent call last):
>   File "c:\Python27_64\lib\unittest\case.py", line 318, in run
> testMethod()
>   File
> "c:\buildslave\ztk_dev_py_270_win64\build\src\zope.i18n\src\zope\i18n\tests\test_itranslationdomain.py",
> line 99, in testNoTargetLanguage
> eq(translate('short_greeting', context=context, default=42), 42)
>   File
> "c:\buildslave\ztk_dev_py_270_win64\build\src\zope.app.i18n\src\zope\app\i18n\translationdomain.py",
> line 74, in translate
> catalog_names = self._catalogs.get(target_language, [])
> TypeError: Object has default comparison
> -- $< -
> 
> WTF?  We have tests for zope.i18n which pull in code from zope.app.i18n?
> Not only that, but we have an error being raised from the OOBTree
> changes Jim landed in October, in a code base which hasn't changed since
> March.

Buildout egg caches, maybe?  Insufficient version pinning?  newest = false
in a buildout.cfg?  Who can tell?

Marius Gedminas
-- 
http://pov.lt/ -- Zope 3/BlueBream consulting and development


signature.asc
Description: Digital signature
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 17, OK: 91

2011-05-25 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 05/25/2011 09:30 AM, Tres Seaver wrote:
>>> [13]   FAILED  winbot / ztk_dev py_254_win32
>>>https://mail.zope.org/pipermail/zope-tests/2011-May/041891.html
> 
> 
>>> [14]   FAILED  winbot / ztk_dev py_265_win32
>>>https://mail.zope.org/pipermail/zope-tests/2011-May/041892.html
> 
> 
>>> [15]   FAILED  winbot / ztk_dev py_265_win64
>>>https://mail.zope.org/pipermail/zope-tests/2011-May/041894.html
> 
> 
>>> [16]   FAILED  winbot / ztk_dev py_270_win32
>>>https://mail.zope.org/pipermail/zope-tests/2011-May/041895.html
> 
> 
>>> [17]   FAILED  winbot / ztk_dev py_270_win64
>>>https://mail.zope.org/pipermail/zope-tests/2011-May/041897.html
> 
>> These are all the same bug::
> 
>> -- $< -
>> Error in test testNoTargetLanguage
>> (zope.app.i18n.tests.test_translationdomain.TestTranslationDomain)
>> Traceback (most recent call last):
>>   File "c:\Python27_64\lib\unittest\case.py", line 318, in run
>> testMethod()
>>   File
>> "c:\buildslave\ztk_dev_py_270_win64\build\src\zope.i18n\src\zope\i18n\tests\test_itranslationdomain.py",
>> line 99, in testNoTargetLanguage
>> eq(translate('short_greeting', context=context, default=42), 42)
>>   File
>> "c:\buildslave\ztk_dev_py_270_win64\build\src\zope.app.i18n\src\zope\app\i18n\translationdomain.py",
>> line 74, in translate
>> catalog_names = self._catalogs.get(target_language, [])
>> TypeError: Object has default comparison
>> -- $< -
> 
>> WTF?  We have tests for zope.i18n which pull in code from zope.app.i18n?
>> Not only that, but we have an error being raised from the OOBTree
>> changes Jim landed in October, in a code base which hasn't changed since
>> March.
> 
> 
> We definitely have some kind of failed cleanup going on here:  the
> standalone buildout for zope.i18n does *not* pull in zope.app.i18n, and
> the tests all pass without it.

"Silly wabbit" -- I assumed that the traceback stack accurately
reflected the source of the failing test.  This failure is actually in
zope.app.i18n's tests, not zope.i18n's (ob. note on the evil of
frameworking out unit tests).  However, I cannot reproduce the failure
in a standalone checkout of zope.app.i18n.



Tres.
- -- 
===
Tres Seaver  +1 540-429-0999  tsea...@palladion.com
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3dB/AACgkQ+gerLs4ltQ6AuQCfY2gkcMk2D0tR367tf9rFa6dS
1pIAoIrY08cCem2lfTyZLoCP4pdY6uJP
=ankk
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 17, OK: 91

2011-05-25 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

>> [13]   FAILED  winbot / ztk_dev py_254_win32
>>https://mail.zope.org/pipermail/zope-tests/2011-May/041891.html
> 
> 
>> [14]   FAILED  winbot / ztk_dev py_265_win32
>>https://mail.zope.org/pipermail/zope-tests/2011-May/041892.html
> 
> 
>> [15]   FAILED  winbot / ztk_dev py_265_win64
>>https://mail.zope.org/pipermail/zope-tests/2011-May/041894.html
> 
> 
>> [16]   FAILED  winbot / ztk_dev py_270_win32
>>https://mail.zope.org/pipermail/zope-tests/2011-May/041895.html
> 
> 
>> [17]   FAILED  winbot / ztk_dev py_270_win64
>>https://mail.zope.org/pipermail/zope-tests/2011-May/041897.html
> 
> These are all the same bug::
> 
> -- $< -
> Error in test testNoTargetLanguage
> (zope.app.i18n.tests.test_translationdomain.TestTranslationDomain)
> Traceback (most recent call last):
>   File "c:\Python27_64\lib\unittest\case.py", line 318, in run
> testMethod()
>   File
> "c:\buildslave\ztk_dev_py_270_win64\build\src\zope.i18n\src\zope\i18n\tests\test_itranslationdomain.py",
> line 99, in testNoTargetLanguage
> eq(translate('short_greeting', context=context, default=42), 42)
>   File
> "c:\buildslave\ztk_dev_py_270_win64\build\src\zope.app.i18n\src\zope\app\i18n\translationdomain.py",
> line 74, in translate
> catalog_names = self._catalogs.get(target_language, [])
> TypeError: Object has default comparison
> -- $< -
> 
> WTF?  We have tests for zope.i18n which pull in code from zope.app.i18n?
> Not only that, but we have an error being raised from the OOBTree
> changes Jim landed in October, in a code base which hasn't changed since
> March.


We definitely have some kind of failed cleanup going on here:  the
standalone buildout for zope.i18n does *not* pull in zope.app.i18n, and
the tests all pass without it.


Tres.
- -- 
===
Tres Seaver  +1 540-429-0999  tsea...@palladion.com
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3dBHYACgkQ+gerLs4ltQ50ogCeLxr+nWgvyCDAcOq5hwn7lpFF
x7YAn07BlqEGF5pz/KlbuS+49k8BTn/G
=hLii
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 17, OK: 91

2011-05-25 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

> [1]FAILED  Zope Buildbot / zope2.13-py2.7 slave-ubuntu64
>https://mail.zope.org/pipermail/zope-tests/2011-May/041834.html
> 
> 
> [2]FAILED  Zope Buildbot / zope2.14-py2.7 slave-ubuntu64
>https://mail.zope.org/pipermail/zope-tests/2011-May/041836.html

Still the I-can't-reproduce-atexit-segfault:  can *anybody* except this
buildbot reproduce the issue?  What Python 2.7 version is the buildbot
running, and how was it built?


> [3]FAILED  Zope Buildbot / zopetoolkit-1.0-py2.5 slave-osx
>https://mail.zope.org/pipermail/zope-tests/2011-May/041867.html

The is an FTP test failure, similar to others which have showed up::

- -- $< -
Failure in test testHELP (zope.server.ftp.tests.test_ftpserver.Tests)
Traceback (most recent call last):
  File
"/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
line 260, in run
testMethod()
  File
"/Users/buildslave/.buildout/eggs/zope.server-3.6.2-py2.5.egg/zope/server/ftp/tests/test_ftpserver.py",
line 278, in testHELP
self.assertEqual(self.execute('HELP', 1), result)
  File
"/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
line 334, in failUnlessEqual
(msg or '%r != %r' % (first, second))
AssertionError: '214-The following commands are recognized\r\n' !=
'214-The following commands are recognized\r\nHelp goes here
somewhen.\r\n214 Help done.\r\n'
- -- $< -

I have no idea why this failure is only occasionaly, and only on OS/X.

> [4]FAILED  Zope Buildbot / zopetoolkit_win-py2.6 slave-win
>https://mail.zope.org/pipermail/zope-tests/2011-May/041857.html

Oddball build failure::

- -- $< -
remoteFailed: [Failure instance: Traceback (failure with no frames):
: Connection to the other
side was lost in a non-clean fashion.
- -- $< -


> [5]FAILED  Zope Buildbot / zopetoolkit_win-py2.6 slave-win
>https://mail.zope.org/pipermail/zope-tests/2011-May/041856.html

Ditto.


> [13]   FAILED  winbot / ztk_dev py_254_win32
>https://mail.zope.org/pipermail/zope-tests/2011-May/041891.html
> 
> 
> [14]   FAILED  winbot / ztk_dev py_265_win32
>https://mail.zope.org/pipermail/zope-tests/2011-May/041892.html
> 
> 
> [15]   FAILED  winbot / ztk_dev py_265_win64
>https://mail.zope.org/pipermail/zope-tests/2011-May/041894.html
> 
> 
> [16]   FAILED  winbot / ztk_dev py_270_win32
>https://mail.zope.org/pipermail/zope-tests/2011-May/041895.html
> 
> 
> [17]   FAILED  winbot / ztk_dev py_270_win64
>https://mail.zope.org/pipermail/zope-tests/2011-May/041897.html

These are all the same bug::

- -- $< -
Error in test testNoTargetLanguage
(zope.app.i18n.tests.test_translationdomain.TestTranslationDomain)
Traceback (most recent call last):
  File "c:\Python27_64\lib\unittest\case.py", line 318, in run
testMethod()
  File
"c:\buildslave\ztk_dev_py_270_win64\build\src\zope.i18n\src\zope\i18n\tests\test_itranslationdomain.py",
line 99, in testNoTargetLanguage
eq(translate('short_greeting', context=context, default=42), 42)
  File
"c:\buildslave\ztk_dev_py_270_win64\build\src\zope.app.i18n\src\zope\app\i18n\translationdomain.py",
line 74, in translate
catalog_names = self._catalogs.get(target_language, [])
TypeError: Object has default comparison
- -- $< -

WTF?  We have tests for zope.i18n which pull in code from zope.app.i18n?
Not only that, but we have an error being raised from the OOBTree
changes Jim landed in October, in a code base which hasn't changed since
March.


Tres.
- -- 
===
Tres Seaver  +1 540-429-0999  tsea...@palladion.com
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3dAbYACgkQ+gerLs4ltQ6n9wCbB9VXSzcYzm9qpQZ9KHPW+Yk8
R5wAoIpSKJOD2bRCcogzcOmIOlZzfMz/
=dLYh
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )