Re: [Zope3-dev], [Zope-dev] Import checking code

2004-04-16 Thread Martijn Faassen
Fred Drake wrote:
On Thursday 15 April 2004 13:22, Martijn Faassen wrote:
  If somebody lets me know which API they want implemented for retrieving
  imports (and use of imports) I could do this lifting work myself.
I'm not sure simply re-implementing one of the finddeps.py internal interfaces 
is the right thing to do; that's some incredibly cludgey code in Zope 3.  
There's a lot of confusion about what values are paths and which are module 
names, and that makes me very uncomfortable.

If you'd like to replace the code that locates imports, feel free to do so.  
It may be that conciseness wins; the tokenize-based approach certainly ended 
up being more code than I'd expected initially.
I'll try to find some time to take a look at it. Dependency checking is 
sort of a natural thing to use importchecker stuff for, but 
importchecker itself may need some refactoring. :)

On Thursday 15 April 2004 01:21 pm, Stephan Richter wrote:
  Fred has fixed that a while ago already (if I read the checkins
  correctly). :-)
No, Martijn's talking about something else... kinda.  I imagine he had even 
stronger feelings about your initial implementation.  ;-)
Right, I'd missed the transition to the tokenize based code, which 
probably is reasonably reliable. I did have objections to the regular 
expressions. :)

Regards,

Martijn

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope3-dev], [Zope-dev] Import checking code

2004-04-16 Thread Fred Drake
On Friday 16 April 2004 06:15 am, Martijn Faassen wrote:
  I'll try to find some time to take a look at it. Dependency checking is
  sort of a natural thing to use importchecker stuff for, but
  importchecker itself may need some refactoring. :)

Actually, the confusion I was referring to was in finddeps.py, not 
importfinder.py.  It was very difficult to follow the code.

  Right, I'd missed the transition to the tokenize based code, which
  probably is reasonably reliable. I did have objections to the regular
  expressions. :)

I'm confident that the tokenize-based code finds everything; what it replaced 
did not.


  -Fred

-- 
Fred L. Drake, Jr.  fred at zope.com
PythonLabs at Zope Corporation


___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )