[Zope-PAS] adding an image type to the set of known property types

[Rob Miller]

hi,

i'm working on implementing the Plone member data as user properties, but have 
hit a snag b/c PAS doesn't recognize images as a possible property type.  in 
the short term, does anyone object (with an alternate proposal, ideally) to 
the following patch:


Index: UserPropertySheet.py
===
--- UserPropertySheet.py(revision 70425)
+++ UserPropertySheet.py(working copy)
@@ -35,6 +35,8 @@

 from DateTime.DateTime import DateTime

+from OFS.Image import Image
+
 from Products.PluggableAuthService.utils import classImplements
 from Products.PluggableAuthService.interfaces.propertysheets \
 import IPropertySheet
@@ -73,6 +75,9 @@
 else:
 raise ValueError, 'Property %s: unknown class' % k

+elif isinstance( v, Image ):
+ptype = 'image'
+
 elif type( v ) not in StringTypes:
 raise ValueError, 'Property %s: unknown type' % k


in the longer term, in PlonePAS there seems to be the beginning of a more 
flexible property sheet schema implementation.  there are also a number of 
other niceties in PlonePAS (e.g. IMutablePropertySheet) that should probably 
be ported back to the PAS layer.  i seem to remember hearing at some point 
that there were plans to merge some of this.  anyone on this list know if 
that's true, and what the plans were?


thanks!

-r

___
Zope-PAS mailing list
Zope-PAS@zope.org
http://mail.zope.org/mailman/listinfo/zope-pas

[Zope-PAS] Re: adding an image type to the set of known property types

[Rob Miller]

Jens Vagelpohl wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


On 30 Sep 2006, at 02:00, Rob Miller wrote:


hi,

i'm working on implementing the Plone member data as user properties, 
but have hit a snag b/c PAS doesn't recognize images as a possible 
property type.  in the short term, does anyone object (with an 
alternate proposal, ideally) to the following patch:


I don't see a reason not to integrate that patch. Gotta love double 
negatives, even I have to think twice about what it is I am saying ;)


okay, i didn't not commit it.  ;-)

-r

___
Zope-PAS mailing list
Zope-PAS@zope.org
http://mail.zope.org/mailman/listinfo/zope-pas

[Zope-PAS] merge r70450 to 1.4 branch?

[Rob Miller]

hi all,

i made a very small fix on the trunk some while ago to allow PAS to support 
image type properties on UserPropertySheets 
(http://svn.zope.org/PluggableAuthService/trunk/UserPropertySheet.py?rev=70450view=rev).


i forgot, however, to merge it onto the 1.4 branch at the time.  is this 
change minimal enough to make it onto the maintenance branch?


-r

___
Zope-PAS mailing list
Zope-PAS@zope.org
http://mail.zope.org/mailman/listinfo/zope-pas

[Zope-PAS] merge r70450 to 1.4 branch?

[Rob Miller]

gmane appears to be lagging... apologies if this comes through twice...

hi all,

i made a very small fix on the trunk some while ago to allow PAS to support
image type properties on UserPropertySheets
(http://svn.zope.org/PluggableAuthService/trunk/UserPropertySheet.py?rev=70450view=rev).

i forgot, however, to merge it onto the 1.4 branch at the time.  is this
change minimal enough to make it onto the maintenance branch?

-r

___
Zope-PAS mailing list
Zope-PAS@zope.org
http://mail.zope.org/mailman/listinfo/zope-pas