Re: [Zope-PAS] Using Zope3 events

2007-06-10 Thread Wichert Akkerman
Previously Jens Vagelpohl wrote:
 On 9 Jun 2007, at 20:28, Wichert Akkerman wrote:
 I'm not quite happy with the current interfaces; I think it makes more
 sense to carry an IBasicUser instance in the event instead of the
 current userid and acl_users attributes.
 
 I'd do that if possible.

I've done that now.

Unless someone objects I'ld like to merge this into trunk.

Wichert.

-- 
Wichert Akkerman [EMAIL PROTECTED]It is simple to make things.
http://www.wiggy.net/   It is hard to make things simple.
___
Zope-PAS mailing list
Zope-PAS@zope.org
http://mail.zope.org/mailman/listinfo/zope-pas


Re: [Zope-PAS] Using Zope3 events

2007-06-10 Thread Jens Vagelpohl

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


On 11 Jun 2007, at 00:22, Wichert Akkerman wrote:


Previously Jens Vagelpohl wrote:

On 9 Jun 2007, at 20:28, Wichert Akkerman wrote:
I'm not quite happy with the current interfaces; I think it makes  
more

sense to carry an IBasicUser instance in the event instead of the
current userid and acl_users attributes.


I'd do that if possible.


I've done that now.

Unless someone objects I'ld like to merge this into trunk.


if it's all tested well then no objections from me.

jens



-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (Darwin)

iD8DBQFGbH/YRAx5nvEhZLIRAvnbAJ93PGjwytP5G+2AHR/cKwFjJtuDswCghFP7
9JilOarUZqL4lLYtheep090=
=g/As
-END PGP SIGNATURE-
___
Zope-PAS mailing list
Zope-PAS@zope.org
http://mail.zope.org/mailman/listinfo/zope-pas


[Zope-PAS] Using Zope3 events

2007-06-09 Thread Wichert Akkerman
I just recreated my z3-events branch based on the current trunk. This
branch defines a number of user-related events. I used two types of
events:

* events which are send by PAS when it has performed an action which may
  be interesting. There is only one of those: IUserCreatedEvent, which
  is send by _doAddUser if a new user has succesfully been added. Other
  candidates are IUserDeletedEvent (PAS has no API for user delation so
  I haven't implemented that one yet) and IUserPropertiesModifiedEvent.

* events which are send by other code which PAS can act on. I
  implemented IUserCredentialsUpdatedEvent and added a subscriber which
  just calls updateCredentials on a PAS instance.

I'm not quite happy with the current interfaces; I think it makes more
sense to carry an IBasicUser instance in the event instead of the
current userid and acl_users attributes.

Before I'm going to put more effort in this I would like to know if
there is an interest in adding events and if my current approach is
sane. In other words: feedback please!

Wichert.

-- 
Wichert Akkerman [EMAIL PROTECTED]It is simple to make things.
http://www.wiggy.net/   It is hard to make things simple.
___
Zope-PAS mailing list
Zope-PAS@zope.org
http://mail.zope.org/mailman/listinfo/zope-pas