Re: [Zope3-dev] Enhancement of HomeFolderManager: ok to checkin?

2006-01-22 Thread Florian Lindner
Am Donnerstag, 19. Januar 2006 18:49 schrieb Florian Lindner:
> Hello,
> I did a small enhancement to the HomeFolderManager.
>
> I've added a field containerObject that holds the object to be created as a
> home folder. The type is string. The default is zope.app.folder.Folder.
> The field is validated with:
>
> def _toFieldValue(self, input):
>   try:
> objectToCreate = resolve(input)
>   except ImportError, e:
> raise ConversionError(_('dotted name is not is not correct !'), e)
>   else:
> return input
>
> (from browser.py)
>
> The code that creates the folder is:
>
> objectToCreate = resolve(self.containerObject)
> self.homeFolderBase[name] = objectToCreate()
>
> (fron homefolder.py)
>
> Right now there are no tests yet.
>
> Is this ok to checkin after I've written tests for the new functionality?

Can I take no answers as no objections?

So I'll checkin the next days. If it's not ok, someone can still restore the 
changes in SVN.

Regards,

Florian
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com



[Zope3-dev] Enhancement of HomeFolderManager: ok to checkin?

2006-01-19 Thread Florian Lindner
Hello,
I did a small enhancement to the HomeFolderManager.

I've added a field containerObject that holds the object to be created as a 
home folder. The type is string. The default is zope.app.folder.Folder.
The field is validated with:

def _toFieldValue(self, input):
  try:
objectToCreate = resolve(input)
  except ImportError, e:
raise ConversionError(_('dotted name is not is not correct !'), e)
  else:
return input

(from browser.py)

The code that creates the folder is:

objectToCreate = resolve(self.containerObject)
self.homeFolderBase[name] = objectToCreate()

(fron homefolder.py)

Right now there are no tests yet.

Is this ok to checkin after I've written tests for the new functionality?

Regards,

Florian
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com