Re: [Zope3-dev] Re: Bare excepts in z3c.zalchemy

2007-03-05 Thread Chris Withers
Jürgen Kartnaller wrote: The fact that you get an error there is an indication that something in your tests still has a file open in some way, you should fix that ;-) The something was/is sqlite ! I don't know what that's supposed to mean, since I have little context on the tests, but if

[Zope3-dev] Re: Bare excepts in z3c.zalchemy

2007-03-05 Thread Jürgen Kartnaller
Chris Withers wrote: Jürgen Kartnaller wrote: The fact that you get an error there is an indication that something in your tests still has a file open in some way, you should fix that ;-) The something was/is sqlite ! I don't know what that's supposed to mean, since I have little

[Zope3-dev] Re: Bare excepts in z3c.zalchemy

2007-03-03 Thread Jürgen Kartnaller
Philipp von Weitershausen wrote: For the lack of a better mailinglist, I'm posting this to zope3-dev: z3c.zalchemy is pretty cool, but the tons of bare except clauses make me a bit uneasy. When I see them, I wonder what this code is expecting to fail and why. Plus, there are no comments as

[Zope3-dev] Re: Bare excepts in z3c.zalchemy

2007-03-03 Thread Jürgen Kartnaller
Philipp von Weitershausen wrote: Jürgen Kartnaller wrote: datamanager.py: 2 try/except They are there because it is possible that a table already exists when trying to create it or doesn't exist when trying to delete it. As I remember when I wrote this I couldn't find a better way, but I'm

Re: [Zope3-dev] Re: Bare excepts in z3c.zalchemy

2007-03-03 Thread Chris Withers
Jürgen Kartnaller wrote: Yes these stupid except's are because of windows :( I wrote the first version on windows and had the problem that windows didn't let me delete the files. It is possible to do this right, I've had to in the past... The fact that you get an error there is an indication

[Zope3-dev] Re: Bare excepts in z3c.zalchemy

2007-03-03 Thread Jürgen Kartnaller
Chris Withers wrote: Jürgen Kartnaller wrote: Yes these stupid except's are because of windows :( I wrote the first version on windows and had the problem that windows didn't let me delete the files. It is possible to do this right, I've had to in the past... The fact that you get an