HEADS UP: Re: [Zope3-dev] RFC: Stop form machinery from providing a default translation domain of "zope"
Jim Fulton wrote: Jim Fulton wrote: in zope/app/form/__init__.py there is a method used to translate widget labels that passes "zope" as a domain. This means that labels that are not message ids get the zope domain. At best, this hides i18n bugs. At worst, this will lead to undesired translations. I think it's a bad idea to provide a default domain. I'd like to fix this, but if I do, some tests will break. It appears that these tests are just trying to test that translation happens. I think I could just fix the tests by having them use message ids rather than using ordinary unicode strings. I'll do this in a couple of days if no one objects. :) Or better yet, we could stop having widgets translate their own labels and hints, since this seems to be getting done in the templates that use the labels and hints, leading to double translation. This is what I will do if I don't get any objections. :) I went ahead and did this last night. I can back it out of necessary. Jim -- Jim Fulton mailto:[EMAIL PROTECTED] Python Powered! CTO (540) 361-1714http://www.python.org Zope Corporation http://www.zope.com http://www.zope.org ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] RFC: Stop form machinery from providing a default translation domain of "zope"
On Tuesday 08 November 2005 15:36, Jim Fulton wrote: > This is what I will do if I don't get any objections. :) Is +1 from me pretty much canconical? :-) Regards, Stephan -- Stephan Richter CBU Physics & Chemistry (B.S.) / Tufts Physics (Ph.D. student) Web2k - Web Software Design, Development and Training ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] RFC: Stop form machinery from providing a default translation domain of "zope"
Jim Fulton wrote: in zope/app/form/__init__.py there is a method used to translate widget labels that passes "zope" as a domain. This means that labels that are not message ids get the zope domain. At best, this hides i18n bugs. At worst, this will lead to undesired translations. I think it's a bad idea to provide a default domain. I'd like to fix this, but if I do, some tests will break. It appears that these tests are just trying to test that translation happens. I think I could just fix the tests by having them use message ids rather than using ordinary unicode strings. I'll do this in a couple of days if no one objects. :) Or better yet, we could stop having widgets translate their own labels and hints, since this seems to be getting done in the templates that use the labels and hints, leading to double translation. This is what I will do if I don't get any objections. :) Jim -- Jim Fulton mailto:[EMAIL PROTECTED] Python Powered! CTO (540) 361-1714http://www.python.org Zope Corporation http://www.zope.com http://www.zope.org ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
