Re: [Zope3-dev] Re: zope.security problems related to Python 2.5 update? (Was: Removed zope.security 3.4b4)
Was this problem related to Python 2.5 update ?
I checked Nikhil's (GSoC student) commit (r78089), but cann't find any issue
with that changes.
Index: CHANGES.txt
===
--- CHANGES.txt(revision 78088)
+++ CHANGES.txt(revision 78089)
@@ -1,5 +1,8 @@
zope.security package changelog
===
+Next release
+
+- zope.security now works on Python 2.5
3.4.0b2 - 2007/06/15
Index: src/zope/security/checker.py
===
--- src/zope/security/checker.py(revision 78088)
+++ src/zope/security/checker.py(revision 78089)
@@ -701,6 +701,7 @@
type(iter([])): _iteratorChecker, # Same types in Python 2.2.1,
type(iter(())): _iteratorChecker, # different in Python 2.3.
type(iter({})): _iteratorChecker,
+type(iter(set())): _iteratorChecker,
type({}.iteritems()): _iteratorChecker,
type({}.iterkeys()): _iteratorChecker,
type({}.itervalues()): _iteratorChecker,
Index: src/zope/security/untrustedpython/tests.py
===
--- src/zope/security/untrustedpython/tests.py(revision 78088)
+++ src/zope/security/untrustedpython/tests.py(revision 78089)
@@ -16,13 +16,18 @@
$Id$
import unittest
-from zope.testing import doctestunit
+import re
+from zope.testing import doctestunit,renormalizing
def test_suite():
+checker = renormalizing.RENormalizing([
+ (re.compile(r'ImmutableModule' object),
+r'object'),
+ ])
return unittest.TestSuite((
doctestunit.DocFileSuite('builtins.txt',
'rcompile.txt',
- 'interpreter.txt',
+ 'interpreter.txt',checker=checker
),
))
Regards,
Baiju M
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: zope.security problems related to Python 2.5 update? (Was: Removed zope.security 3.4b4)
Am Donnerstag, den 16.08.2007, 17:36 +0530 schrieb Baiju M: Was this problem related to Python 2.5 update ? It was not, it was just a suspicion of me and it was wrong. ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: zope.security problems related to Python 2.5 update? (Was: Removed zope.security 3.4b4)
Am Mittwoch, den 15.08.2007, 17:52 +0200 schrieb Martijn Faassen: Wichert Akkerman wrote: Previously Christian Theune wrote: Am Mittwoch, den 15.08.2007, 14:15 +0200 schrieb Christian Theune: Hi, I saw the error reports about zope.security and got talked to from a few people that they had severe problems managing around this. I removed the 3.4b4 distribution from download.zope.org to allow them to continue using zopeproject and grokproject until we find a fix. I wasn't sure about that, so if someone has even worse problems now, please speak up and I'll put the package back into place again. I hope I didn't cause any more problems than exist already. This is deeper than I thought. b3 doesn't work either. It looks like the merge from the branch with support for Python 2.5 is causing the problems. I can confirm that the last release before the python 2.5 support was added (3.4.0-b2) works correctly. Just ran into this one. I think removing it is the right decision. b2 did work for me, but b4 just broke on me. b5 is available already, so the problem should be over. Just delete b3 and b4 from your egg caches. I'm not sure that we should have to rely on removing packages like those. As Tres pointed out we should just avoid that everybody gets those immediately anyway, but we should keep them as historic releases in general. Christian ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: zope.security problems related to Python 2.5 update? (Was: Removed zope.security 3.4b4)
On Aug 15, 2007, at 11:52 AM, Martijn Faassen wrote: Wichert Akkerman wrote: Previously Christian Theune wrote: Am Mittwoch, den 15.08.2007, 14:15 +0200 schrieb Christian Theune: Hi, I saw the error reports about zope.security and got talked to from a few people that they had severe problems managing around this. I removed the 3.4b4 distribution from download.zope.org to allow them to continue using zopeproject and grokproject until we find a fix. I wasn't sure about that, so if someone has even worse problems now, please speak up and I'll put the package back into place again. I hope I didn't cause any more problems than exist already. This is deeper than I thought. b3 doesn't work either. It looks like the merge from the branch with support for Python 2.5 is causing the problems. I can confirm that the last release before the python 2.5 support was added (3.4.0-b2) works correctly. Just ran into this one. I think removing it is the right decision. b2 did work for me, but b4 just broke on me. Try b5. Jim -- Jim Fulton mailto:[EMAIL PROTECTED]Python Powered! CTO (540) 361-1714 http://www.python.org Zope Corporationhttp://www.zope.com http://www.zope.org ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: zope.security problems related to Python 2.5 update? (Was: Removed zope.security 3.4b4)
On Aug 15, 2007, at 11:56 AM, Christian Theune wrote: I'm not sure that we should have to rely on removing packages like those. I'm fairly sure that removing them is *not* the right solution. For example, that might have broken other applications. (After all, I released b4 for a reason.) The right short-term fix in this case was to use b2 in grok until b5 was released. As Tres pointed out we should just avoid that everybody gets those immediately anyway, but we should keep them as historic releases in general. Only getting released versions would probably have just delayed the problem until it would have been harder to solve. I was able to address this quickly because the changes that caused it were fresh in my mind. It would have been harder if the problem were reported much later. This particular problem was due to a circular import, which is a very hard thing to test for sadly. We need to fix this. Jim -- Jim Fulton mailto:[EMAIL PROTECTED]Python Powered! CTO (540) 361-1714 http://www.python.org Zope Corporationhttp://www.zope.com http://www.zope.org ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: zope.security problems related to Python 2.5 update? (Was: Removed zope.security 3.4b4)
Am Mittwoch, den 15.08.2007, 17:59 +0200 schrieb Martijn Faassen: Where is this b5? I am still getting b4, not b5. I can't find b5 on the server. I've put it there now. The actual distribution was missing. I've created the b5 tag and uploaded the sdist package. ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: zope.security problems related to Python 2.5 update? (Was: Removed zope.security 3.4b4)
On Aug 15, 2007, at 12:00 PM, Martijn Faassen wrote: Jim Fulton wrote: [snip] Just ran into this one. I think removing it is the right decision. b2 did work for me, but b4 just broke on me. Try b5. I'd love to try the mysterious b5, but it's just not there. :) I tried to put it there, but my scp missfired. Christian uploaded it and it is there now. Jim -- Jim Fulton mailto:[EMAIL PROTECTED]Python Powered! CTO (540) 361-1714 http://www.python.org Zope Corporationhttp://www.zope.com http://www.zope.org ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: zope.security problems related to Python 2.5 update? (Was: Removed zope.security 3.4b4)
Am Mittwoch, den 15.08.2007, 12:02 -0400 schrieb Jim Fulton: On Aug 15, 2007, at 11:56 AM, Christian Theune wrote: I'm not sure that we should have to rely on removing packages like those. I'm fairly sure that removing them is *not* the right solution. For example, that might have broken other applications. (After all, I released b4 for a reason.) The right short-term fix in this case was to use b2 in grok until b5 was released. Right. I wasn't sure that people had a way to actually deal with this. I didn't like my approach either and it didn't help anyway. :/ As Tres pointed out we should just avoid that everybody gets those immediately anyway, but we should keep them as historic releases in general. Only getting released versions would probably have just delayed the problem until it would have been harder to solve. I was able to address this quickly because the changes that caused it were fresh in my mind. It would have been harder if the problem were reported much later. Hmm. Well. OTOH we just can't let *every* unsuspected user get that. That's bad from multiple points of view like experience, marketing, ... ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
