Re: [Zope3-dev] copied doctest in z3.zope3recipes for Windows support
On Thursday 16 August 2007 08:52, Martijn Faassen wrote: > Opinions? I agree with your assessment. Only differences to the original README.txt file should be in WINDOWS.txt. I would prefer two files over one file with conditions. Regards, Stephan -- Stephan Richter CBU Physics & Chemistry (B.S.) / Tufts Physics (Ph.D. student) Web2k - Web Software Design, Development and Training ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] copied doctest in z3.zope3recipes for Windows support
Previously Martijn Faassen wrote: > Hi there, > > I don't have any Windows knowledge, so my ability to review Roger's > changes to add (much needed!) windows support to z3.zope3recipes is > limited. > > I do however notice that an entire doctest was more or less copied > verbatim: README.txt got copied to WINDOWS.txt. The Windows version has > some changes, and a few additions, but it's almost exactly the same. > > Now if these were unit tests this would be less problematic, but this is > a document as well, and as a result we now have two virtually identical > documents to maintain. That seems wrong. I don't understand that. Having to maintain duplicate unit tests or duplicate documents sounds like the exact same amount of duplicate work and problems to me. Why do you consider duplicate documents to be more problematic? Wichert. -- Wichert Akkerman <[EMAIL PROTECTED]>It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] copied doctest in z3.zope3recipes for Windows support
Am Donnerstag, den 16.08.2007, 09:02 -0400 schrieb Benji York: > Martijn Faassen wrote: > > These are all the changes in the test code I can detect. It therefore > > seems quite feasible to merge them into a single test again, if at least > > we can work out the buildout output differences. > > +1 > > It may be possible through the use of a normalizer and different setup > code for the different platforms to unify the two tests. I personally > would prefer to not see conditionals in the doctest itself. +1 too. I suspect that the normalizer won't help in every case. ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] copied doctest in z3.zope3recipes for Windows support
Martijn Faassen wrote: These are all the changes in the test code I can detect. It therefore seems quite feasible to merge them into a single test again, if at least we can work out the buildout output differences. +1 It may be possible through the use of a normalizer and different setup code for the different platforms to unify the two tests. I personally would prefer to not see conditionals in the doctest itself. -- Benji York Senior Software Engineer Zope Corporation ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
