Re: [Zope] Re: PageTemplates len() of unsized object

2008-06-02 Thread Dieter Maurer
Philipp von Weitershausen wrote at 2008-5-28 21:52 +0200:
Dieter Maurer wrote:
 2008-05-24T09:31:32 ERROR Zope.SiteErrorLog 
 http://myurl/error_log/manage_main
 Traceback (innermost last):
   Module ZPublisher.Publish, line 119, in publish
   Module ZPublisher.mapply, line 88, in mapply
   Module ZPublisher.Publish, line 42, in call_object
   Module Shared.DC.Scripts.Bindings, line 313, in __call__
   Module Shared.DC.Scripts.Bindings, line 350, in _bindAndExec
   Module Products.PageTemplates.PageTemplateFile, line 129, in _exec
   Module Products.PageTemplates.PageTemplate, line 89, in pt_render
   Module zope.pagetemplate.pagetemplate, line 117, in pt_render
   Module zope.tal.talinterpreter, line 271, in __call__
   Module zope.tal.talinterpreter, line 346, in interpret
   Module zope.tal.talinterpreter, line 379, in do_startEndTag
   Module zope.tal.talinterpreter, line 412, in do_startTag
 TypeError: len() of unsized object
 ...
As far as I can tell, the code in zope.pagetemplate and zope.tales still 
has the same traceback information that Products.PageTemplate had. 
zope.tal, which contains the TAL interpreter, doesn't have any traceback 
supplements, but then again, Zope 2's TAL package doesn't either.

To conclude, I don't think there's a step backward at all.

The Zope 2.9 code had traceback support in PageTemplate.pt_render
which told us which template was affected.
As you can see in the traceback above, at least this traceback support
is lost in Zope 2.10.

To conclude: no step backward at all is incorrect.

Looking at Zope 2.11, the traceback support above seems to have
been resurrected.


Furthermore, I could not find the equivalent of the transback
support which formerly was in Expressions.py (I found the one
corresponding to TALES and PythonExpr).









-- 
Dieter
___
Zope maillist  -  Zope@zope.org
http://mail.zope.org/mailman/listinfo/zope
**   No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope-dev )


Re: [Zope] Re: PageTemplates len() of unsized object

2008-06-02 Thread Philipp von Weitershausen

On 2 Jun 2008, at 20:44 , Dieter Maurer wrote:

Philipp von Weitershausen wrote at 2008-5-28 21:52 +0200:

Dieter Maurer wrote:

2008-05-24T09:31:32 ERROR Zope.SiteErrorLog http://myurl/error_log/manage_main
Traceback (innermost last):
 Module ZPublisher.Publish, line 119, in publish
 Module ZPublisher.mapply, line 88, in mapply
 Module ZPublisher.Publish, line 42, in call_object
 Module Shared.DC.Scripts.Bindings, line 313, in __call__
 Module Shared.DC.Scripts.Bindings, line 350, in _bindAndExec
 Module Products.PageTemplates.PageTemplateFile, line 129, in _exec
 Module Products.PageTemplates.PageTemplate, line 89, in pt_render
 Module zope.pagetemplate.pagetemplate, line 117, in pt_render
 Module zope.tal.talinterpreter, line 271, in __call__
 Module zope.tal.talinterpreter, line 346, in interpret
 Module zope.tal.talinterpreter, line 379, in do_startEndTag
 Module zope.tal.talinterpreter, line 412, in do_startTag
TypeError: len() of unsized object

...
As far as I can tell, the code in zope.pagetemplate and zope.tales  
still

has the same traceback information that Products.PageTemplate had.
zope.tal, which contains the TAL interpreter, doesn't have any  
traceback

supplements, but then again, Zope 2's TAL package doesn't either.

To conclude, I don't think there's a step backward at all.


The Zope 2.9 code had traceback support in PageTemplate.pt_render
which told us which template was affected.
As you can see in the traceback above, at least this traceback support
is lost in Zope 2.10.

To conclude: no step backward at all is incorrect.

Looking at Zope 2.11, the traceback support above seems to have
been resurrected.


Furthermore, I could not find the equivalent of the transback
support which formerly was in Expressions.py (I found the one
corresponding to TALES and PythonExpr).


Thank you for that careful analysis. I was only comparing Zope 2.9  
with Zope 3 (which are AFAICT equivalent in their traceback info) but  
I didn't take 2.10 into consideration. I've now filed a bug report at https://bugs.launchpad.net/zope2/+bug/236938 
 to make sure the issue isn't lost. I will look into it a.s.a.p.


___
Zope maillist  -  Zope@zope.org
http://mail.zope.org/mailman/listinfo/zope
**   No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce

http://mail.zope.org/mailman/listinfo/zope-dev )


[Zope] Re: PageTemplates len() of unsized object

2008-05-28 Thread Philipp von Weitershausen

Dieter Maurer wrote:

Giampiero Benvenuti wrote at 2008-5-24 11:47 +0200:

...
after the upgrade from zope2.9.7 to 2.10.6 i get this error in the  
event log:


2008-05-24T09:31:32 ERROR Zope.SiteErrorLog http://myurl/error_log/manage_main
Traceback (innermost last):
  Module ZPublisher.Publish, line 119, in publish
  Module ZPublisher.mapply, line 88, in mapply
  Module ZPublisher.Publish, line 42, in call_object
  Module Shared.DC.Scripts.Bindings, line 313, in __call__
  Module Shared.DC.Scripts.Bindings, line 350, in _bindAndExec
  Module Products.PageTemplates.PageTemplateFile, line 129, in _exec
  Module Products.PageTemplates.PageTemplate, line 89, in pt_render
  Module zope.pagetemplate.pagetemplate, line 117, in pt_render
  Module zope.tal.talinterpreter, line 271, in __call__
  Module zope.tal.talinterpreter, line 346, in interpret
  Module zope.tal.talinterpreter, line 379, in do_startEndTag
  Module zope.tal.talinterpreter, line 412, in do_startTag
TypeError: len() of unsized object


Looks as if the Zope 2.10 PageTemplate implementation made a big
step backward with respect to quality of traceback information :-((


As far as I can see, traceback information was never added within the 
TAL interpreter but always for TALES expression evalutation. The 
traceback above seems to be about something going wrong within the TAL 
interpreter which is probably why we don't see any further traceback info.



Shane had added lots of __traceback_info__ and __traceback_supplement__
declarations to the older code such that the tracebacks were
very informative
... unlike the traceback above.


As far as I can tell, the code in zope.pagetemplate and zope.tales still 
has the same traceback information that Products.PageTemplate had. 
zope.tal, which contains the TAL interpreter, doesn't have any traceback 
supplements, but then again, Zope 2's TAL package doesn't either.


To conclude, I don't think there's a step backward at all.

___
Zope maillist  -  Zope@zope.org
http://mail.zope.org/mailman/listinfo/zope
**   No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce

http://mail.zope.org/mailman/listinfo/zope-dev )