Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Chris Hillery
Review: Approve I cleaned up a few more references to XQuery in the doc, and a couple other doc bits. Looks good now. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-08-14 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch into lp:zorba. Commit message: 1. EBV on jsoniq items returns true instead of error 2. Updated signature (and implementation) of jn and libjn functions according to latest spec 3. Removed from libjn functions that

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Federico Cavalieri
Ready for review -- https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Ghislain Fourny
One of the tests uses ext:nomaterialization without dash. Is this intented? -- https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-08-14 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/180110 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/180110 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/180110 Your team

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/180110 Stage TestZorbaUbuntu failed. 2 tests failed (8401 total tests run). Check test results at http://jenkins.lambda.nu/job/TestZorbaUbuntu/216/testReport/ to view the results. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756 Stage CommitZorba failed. Check console output at http://jenkins.lambda.nu/job/CommitZorba/126/console to view the results. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/180110 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/180110 Your team

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/180110 Stage TestZorbaUbuntu failed. 1 tests failed (8401 total tests run). Check test results at http://jenkins.lambda.nu/job/TestZorbaUbuntu/219/testReport/ to view the results. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Federico Cavalieri
nope, let me fix it On Wed, Aug 14, 2013 at 3:14 PM, Ghislain Fourny ghislain.fou...@28msec.com wrote: One of the tests uses ext:nomaterialization without dash. Is this intented? -- https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Federico Cavalieri
Fixed and pushed On Wed, Aug 14, 2013 at 9:36 PM, Federico Cavalieri federico.cavali...@28msec.com wrote: nope, let me fix it On Wed, Aug 14, 2013 at 3:14 PM, Ghislain Fourny ghislain.fou...@28msec.com wrote: One of the tests uses ext:nomaterialization without dash. Is this intented?

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Matthias Brantner
Nice change. The modifications in the following files don't seem to be needed: - test/rbkt/Queries/zorba/updates/flwor1.xq - test/rbkt/Queries/zorba/scripting/flwor6.xq - test/rbkt/Queries/zorba/updates/flwor1.xq - test/rbkt/Queries/zorba/no-copy/dataguide-c.xq I'll add Markos as a second

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/bug-1026250 into lp:zorba has been updated. Description changed to: - annotation to turn on sequential flwor streaming - introduce support for pragmas and allows the body of a pragma to be a statement (recent scripting extension) - collections are

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-08-14 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-942161 into lp:zorba

2013-08-14 Thread Matthias Brantner
Review: Needs Information The functionality looks great. Is there a way to remove the following problem reported by valgrind? valgrind --tool=memcheck --leak-check=full --show-reachable=yes ./bin/zorba -q 'üöä' -z encoding=ISO-8859-1 -z method=text foo ==20323== Memcheck, a memory error

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-942161 into lp:zorba

2013-08-14 Thread Paul J. Lucas
Maybe. I think it's because the transcoder is never detached. The internal serializer is kind of a mess so I wanted to touch it as little as possible for now. -- https://code.launchpad.net/~zorba-coders/zorba/bug-942161/+merge/179969 Your team Zorba Coders is subscribed to branch lp:zorba.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1124374 into lp:zorba

2013-08-14 Thread Matthias Brantner
Review: Needs Fixing Looks good. However, there is one minor thing which seems to be an existing bug but only now becomes important. The uri attribute of the annotation namespace element is empty: xqdoc:custom tag=namespaces xqdoc:namespace prefix=an uri= isSchema=false/ --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 Your

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Commit Message changed to: Fixed stemmer files location in NOTICE. Removed unused base64 class. Fixed typos in comments. Clean-up. For more details, see:

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 Your team

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Description changed to: Fixed stemmer files location in NOTICE. Removed unused base64 class. Fixed typos in comments. Clean-up. For more details, see:

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-942161 into lp:zorba

2013-08-14 Thread Paul J. Lucas
Although I added the detach (and everything still seems to work), I don't think that was the cause of what you see. I think it's just an artifact of the register_callback() function. Unfortunately, standard streams has no way unregister a callback, so I think we're stuck with the (small) leak

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue starting for the following merge proposals: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 Your team Zorba Coders is

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-08-14 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180271 Your team Zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1124374 into lp:zorba

2013-08-14 Thread Sorin Marian Nasoi
Looks good. However, there is one minor thing which seems to be an existing bug but only now becomes important. The uri attribute of the annotation namespace element is empty: xqdoc:custom tag=namespaces xqdoc:namespace prefix=an uri= isSchema=false/ 1) please give me more